From nobody Mon Mar 10 17:35:43 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZBPDw06dsz5pPGN; Mon, 10 Mar 2025 17:35:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZBPDv6Bh0z3TSy; Mon, 10 Mar 2025 17:35:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741628143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3PikrNAj9PUrTIQpC4bbjYeCxdaBXMb7TUA9IFyi+/M=; b=XPUSCr/3vWySOnVVOFmjC91xdxcXUcXPvnoRMdMe+iPAelwkxCZ7VwzCKLnIzTMegeYlGF y3HaicpF+CErmTP8Y9Hy+nmRXfmKbr0c9wt6nLRXzj3kHnUcmCCvbZ132WOCul1O6dcQ83 mn5DwvxufJybbjM+vRabtEBmvfTCS7eOF8Upgse8WGDdkeFJsSwnSnrVGqbUtT/vC9VkyC BaUYTpZD6o8cHKYsop7Y8aRBhloiRAuTc4rwQyPXqTfh1rizAYUJWLaYz7s2FZLppH/R+E oCYw8qPrkzWD95sDAdcRGDnoICYq5m8gkRfbRqhuOgzDdXM6zDAvk090r22z9A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741628143; a=rsa-sha256; cv=none; b=MRv1Mola70Z4yuv7b5yV2YIrG+FKFuXy/ZEzup+fpAFUxC6xuv/SCks7q0MTwjzvTGqGr3 +j/vF8FTvhtC5xpvwZjNpOkAJgFO20QeEAreFoiFVfhmnMof8Mxdq9ZgUAMRhNLY9pKvx4 pAQbHjEf9BS9s1bFvPXzgWdQU2UDciX1h3uynGs7J57y5ZexLQpNsSP92EO4S48RGVk9d/ CfbCEUN+5IqT8iSLlVrD/zjU4islHADSSIt8mTpfIDbM9i2dzzBVVw8D+Mv+LaWN7qUH4a l+xJsS2j+J69SeGX6Wjmq7oB2ICrPmeQ3dKMrkRlPzQ8AqOaZdctHEWKye1ENA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741628143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3PikrNAj9PUrTIQpC4bbjYeCxdaBXMb7TUA9IFyi+/M=; b=cvXoX6UrQfBfi2n59GaUyTkE6nLCnSwSfslwhLSm/vJfcyWYD7wwSBMn1P6mPJvjnQqMGz 3/qbJOGJwkDV52uiZYkKfG5esnptxt/OMk+fgE6AR6nwkKMVAKQnG/iONUXCsJMvpjJnTm rZq5c62nsbE9lxSWzjRIq1QGBM+oJhM9f6dlP9lTfNXcbMobjdzGQ3zjzZ3PSYcUbdOVpk WeqOfMTrYxHbYyEvtrd8S9b8z2jq1KyqphrCkYzi5HMCnMkAz3LeeQJ8y/QFkM0+bJ/JCN vXnC19bz+frmS2L+KXmRLPhDbKiqKKYRZZTLlNNOiMXrL6tuIWN7yQ1/relxbA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZBPDv5pdczqNt; Mon, 10 Mar 2025 17:35:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52AHZhBr027180; Mon, 10 Mar 2025 17:35:43 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52AHZhtZ027177; Mon, 10 Mar 2025 17:35:43 GMT (envelope-from git) Date: Mon, 10 Mar 2025 17:35:43 GMT Message-Id: <202503101735.52AHZhtZ027177@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 02d61f27585f - main - hdaa: Don't hold a mutex while creating child devices List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 02d61f27585f52d422fc1e235ac6226e27145162 Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=02d61f27585f52d422fc1e235ac6226e27145162 commit 02d61f27585f52d422fc1e235ac6226e27145162 Author: John Baldwin AuthorDate: 2025-03-10 17:34:07 +0000 Commit: John Baldwin CommitDate: 2025-03-10 17:34:07 +0000 hdaa: Don't hold a mutex while creating child devices The lock is already not held while deleting child devices, and the bus_topo_lock is already held when child devices are created. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D49272 --- sys/dev/sound/pci/hda/hdaa.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/dev/sound/pci/hda/hdaa.c b/sys/dev/sound/pci/hda/hdaa.c index f53e93a2355b..ac62c04b5374 100644 --- a/sys/dev/sound/pci/hda/hdaa.c +++ b/sys/dev/sound/pci/hda/hdaa.c @@ -6200,7 +6200,9 @@ hdaa_configure(device_t dev) HDA_BOOTHVERBOSE( device_printf(dev, "Creating PCM devices...\n"); ); + hdaa_unlock(devinfo); hdaa_create_pcms(devinfo); + hdaa_lock(devinfo); HDA_BOOTVERBOSE( if (devinfo->quirks != 0) {