From nobody Fri Mar 07 16:44:38 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z8XFM3fbhz5pZdT; Fri, 07 Mar 2025 16:44:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z8XFM1Cq2z444q; Fri, 07 Mar 2025 16:44:39 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741365879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kShOcqKCUoNF7Fd1Tc9BsJksOd1zFaD2TEYOmNepOus=; b=fI66dZbu3dsZnPni2P+KQUcJG6SzcQg349VOA1O9yNKB50DrUQhKFFUk06pE3e8vlLEWQQ VspsoRIJW6yqChH2IHOPIf/YA/kojq3jkmTOlvcXbD3osrsN2ZsvV2Mc4yGCSLJPbnSPRZ JVec2rtWzxjMaNDcMQVj/T8sIdhfy+3vopRGXQqkGsuv9KxqhZu4x5hGITPme+h/GZYKoB tVX2wmQlp1BYt73+fU1hHeLssQ6Is4xvUf7ft5X69RZJ5BEgIFqWxy9ImN7tc5pZyCfceQ 6msl/C6yOwx4Yemlc2yAXcHw5vv0YVOzHXo6QK9vxf7sB6EnGemYmBJbcRN+og== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741365879; a=rsa-sha256; cv=none; b=QYxBTw4/X1+8V9gdxCZLBGyh6pJZIJeUYB+qER1qN5xvcjPgOv29V4WIugvMvjb22oxDqO 07NBXukpoHzyBh0FpTIniTf3ZisR1J8QKSN+Aq9yQ74TG9C14aExuoNqMzmcktDc/clUbo b6fEqvXw/RA6Ab0lGjkaXrZ7qZ/Z8NdJ02qqrnZ57bb+lN7XNqghc6l35td7HBc6zozxBi gG6VYlCDUtCHNIbAZvyXKQlUHo/J/alDe3dtlyXr3StCPmSjH1nhguS1e7xtV9/37zid7k z3AgWOjEt2Cw+popDDdoIMi9FduutNaHGAF2P6lWyxETVSKz2raL3MtaQJYZDQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741365879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kShOcqKCUoNF7Fd1Tc9BsJksOd1zFaD2TEYOmNepOus=; b=SbgeZlmFKz2nbKQ0l07Bxivqp74tm8Yeb7zVl5ZN7QQy7LvAJvT8VjLvSvTJhtjr0uoZn8 LNQwKIav7pgIHF/aTffZAKK6sSaKaEy8GaP6ycTK6DIr5J9frNlR6w8FiR1RmV/3dCLp6g 0UvSsm8pEYjawYO6mYbfiWHN315hVg7oQxm7mk7+mCJrndlqblcRyRM7uA+9UaItoaz5sf M7sScAX8NZjFU0I3gDzDp8DiO6crmWYeLq03gyI+E+TiMJZh3/YxHnVCXhvLZZH8XUlmYj rNqI7Rwk0qubzGq7YEuo8leNPVYZ8RFu71jnKBt+Cah5VAps20CDWPGqmQtWKQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Z8XFM0gRTzlpQ; Fri, 07 Mar 2025 16:44:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 527GicoJ052025; Fri, 7 Mar 2025 16:44:38 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 527Gic06052022; Fri, 7 Mar 2025 16:44:38 GMT (envelope-from git) Date: Fri, 7 Mar 2025 16:44:38 GMT Message-Id: <202503071644.527Gic06052022@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 67d510f0c07a - main - smbios: Unmap memory on error on identify List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 67d510f0c07afd89e51e337e5abec47f4483ecd9 Auto-Submitted: auto-generated The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=67d510f0c07afd89e51e337e5abec47f4483ecd9 commit 67d510f0c07afd89e51e337e5abec47f4483ecd9 Author: Olivier Certner AuthorDate: 2025-02-28 17:19:37 +0000 Commit: Olivier Certner CommitDate: 2025-03-07 16:42:45 +0000 smbios: Unmap memory on error on identify While here, de-indent most of the code by simply bailing out if 'addr' is still 0 after the various detection methods have been tried. Reviewed by: emaste, imp MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D49180 --- sys/dev/smbios/smbios.c | 82 ++++++++++++++++++++++++------------------------- 1 file changed, 41 insertions(+), 41 deletions(-) diff --git a/sys/dev/smbios/smbios.c b/sys/dev/smbios/smbios.c index e960cb951f5a..561196a3d4b6 100644 --- a/sys/dev/smbios/smbios.c +++ b/sys/dev/smbios/smbios.c @@ -113,53 +113,53 @@ smbios_identify (driver_t *driver, device_t parent) } #endif - if (addr != 0) { - ptr = pmap_mapbios(addr, map_size); - if (ptr == NULL) - return; - if (map_size == sizeof(*eps3)) { - eps3 = ptr; - length = eps3->length; - if (memcmp(eps3->anchor_string, - SMBIOS3_SIG, SMBIOS3_LEN) != 0) { - printf("smbios3: corrupt sig %s found\n", - eps3->anchor_string); - return; - } - } else { - eps = ptr; - length = eps->length; - if (memcmp(eps->anchor_string, - SMBIOS_SIG, SMBIOS_LEN) != 0) { - printf("smbios: corrupt sig %s found\n", - eps->anchor_string); - return; - } + if (addr == 0) + return; + + ptr = pmap_mapbios(addr, map_size); + if (ptr == NULL) + return; + if (map_size == sizeof(*eps3)) { + eps3 = ptr; + length = eps3->length; + if (memcmp(eps3->anchor_string, + SMBIOS3_SIG, SMBIOS3_LEN) != 0) { + printf("smbios3: corrupt sig %s found\n", + eps3->anchor_string); + goto unmap_return; } - if (length != map_size) { - u_int8_t major, minor; - - major = eps->major_version; - minor = eps->minor_version; - - /* SMBIOS v2.1 implementation might use 0x1e. */ - if (length == 0x1e && major == 2 && minor == 1) { - length = 0x1f; - } else { - pmap_unmapbios(eps, map_size); - return; - } + } else { + eps = ptr; + length = eps->length; + if (memcmp(eps->anchor_string, + SMBIOS_SIG, SMBIOS_LEN) != 0) { + printf("smbios: corrupt sig %s found\n", + eps->anchor_string); + goto unmap_return; } + } + if (length != map_size) { + u_int8_t major, minor; - child = BUS_ADD_CHILD(parent, 5, "smbios", DEVICE_UNIT_ANY); - device_set_driver(child, driver); + major = eps->major_version; + minor = eps->minor_version; - /* smuggle the phys addr into probe and attach */ - bus_set_resource(child, SYS_RES_MEMORY, 0, addr, length); - device_set_desc(child, "System Management BIOS"); - pmap_unmapbios(ptr, map_size); + /* SMBIOS v2.1 implementation might use 0x1e. */ + if (length == 0x1e && major == 2 && minor == 1) + length = 0x1f; + else + goto unmap_return; } + child = BUS_ADD_CHILD(parent, 5, "smbios", DEVICE_UNIT_ANY); + device_set_driver(child, driver); + + /* smuggle the phys addr into probe and attach */ + bus_set_resource(child, SYS_RES_MEMORY, 0, addr, length); + device_set_desc(child, "System Management BIOS"); + +unmap_return: + pmap_unmapbios(ptr, map_size); return; }