From nobody Fri Mar 07 07:00:50 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z8HHl4Myrzt5Np; Fri, 07 Mar 2025 07:00:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z8HHk5DChz3gVy; Fri, 07 Mar 2025 07:00:50 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741330850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LktReU4WbwhxAHiQjCNj0FPzmDUkV1m4XTWijyOC4+I=; b=ahmkZ73dXRj5bELrfZveAcgdFhOLVPNkaHV9DAcpicKYjrDe8AO+0pAu/1/VqXkIdOAWPp VG04Xqvd1dQZwdraWAvlCtn7vLV1ZPNSwod77ZkVb+nLKls5Q4D/z5QQ1x3EPaPbIb9q5z Mqf1mYurRdXO3ugfmhF8bVcQLDlOB4ERicBBe3yE/ZzSTFxFdXBigfxjA+LPv/VePgXkC2 3qdPHe6du7IhrZ75q0EgV/2gBRnq+6ombsFdbw/NNjXRTmr3Bb+iZv30szR4FXViVvW/5a dNY4LYnu8iWOEbtLriJ8Q7MZtK2DxukrJ6IiUqlYISe8kb22itkGYVFfj8w0iA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741330850; a=rsa-sha256; cv=none; b=n7NLEXimrFlHF8TRIVRKF8lryuME/N3XNCE7Wr/QQyERiTODzxLtxdjbpLUUtWZecTtbi4 +FlFskLXMBURlPy6kULYnZNH8LyeHavVES1mmdf/GdgJGzusbFYr9h6OeFfKTv1dfVOI9l Bkg7b1vmFzaqxu97ADLK+ICXGzQS+YLPd/2XxWuupjUmx0gt1M8g9z7rkyzl88HwTdE4l4 P0v7vV5D7euilRToFGg06AaK6jZDH3rWoAUDJ/P/w5RP6A9wvfD/ZrW5y31nJ9UkGLJ0fP 4xMWtHvvZSmdUHo10Dx/cZvUe2je2pKsrS7E9pIDHdyjzeaLFM1mEGUQp5/f3w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741330850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LktReU4WbwhxAHiQjCNj0FPzmDUkV1m4XTWijyOC4+I=; b=mOVXcgayfxIs3mNnI2jWsP51KXAKYC0HY/nqB+ywFP6oWZzivfuEafLBeQgk/mPvCBYPm5 kpuuxiivu7NwL5LfGoX86JrXSnjbMxI/bAmE+sZGbQDP8uqEFVINORrawhC6Dhveh5bDum Gy4ZTRB2uDLbAb097kZoPnZ12RDix/Yx5F4kD6EeDqBfXWVJWljyO3s7yN03etfKzulKdy TlXIhnavia8tbJX/e6UVwWMwxF5P6L1dznXKAbpKR7T63FB/D6FsFQRy8gY7j8V9ZoMcwg qJxqifdaM3GYD3O/f9cFF0OJxlV8E5dCju3Bw6SI5y5USdcFpGNT0TH3W4+ZHQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Z8HHk4l2fzB7q; Fri, 07 Mar 2025 07:00:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52770o49060646; Fri, 7 Mar 2025 07:00:50 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52770oH1060643; Fri, 7 Mar 2025 07:00:50 GMT (envelope-from git) Date: Fri, 7 Mar 2025 07:00:50 GMT Message-Id: <202503070700.52770oH1060643@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: e92a78ad7a77 - main - tcp: return EOPNOTSUPP on attempt to connect(2) a listening socket List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e92a78ad7a778feb60f634ceda245f8b761a76ff Auto-Submitted: auto-generated The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=e92a78ad7a778feb60f634ceda245f8b761a76ff commit e92a78ad7a778feb60f634ceda245f8b761a76ff Author: Gleb Smirnoff AuthorDate: 2025-03-07 06:57:11 +0000 Commit: Gleb Smirnoff CommitDate: 2025-03-07 06:57:11 +0000 tcp: return EOPNOTSUPP on attempt to connect(2) a listening socket This is the error code specified by SUS. Only the TCP over IPv6 required this fix. Fixes: bd4a39cc93d9faf8b5c000855d5aa90df592dd49 Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D49275 --- sys/netinet/tcp_usrreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netinet/tcp_usrreq.c b/sys/netinet/tcp_usrreq.c index 0b4a93390f1b..03687c1d3515 100644 --- a/sys/netinet/tcp_usrreq.c +++ b/sys/netinet/tcp_usrreq.c @@ -594,7 +594,7 @@ tcp6_usr_connect(struct socket *so, struct sockaddr *nam, struct thread *td) goto out; } if (SOLISTENING(so)) { - error = EINVAL; + error = EOPNOTSUPP; goto out; } #ifdef INET