From nobody Tue Mar 04 15:25:01 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z6fct2RKPz5qDj5; Tue, 04 Mar 2025 15:25:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z6fct0hmnz3pBX; Tue, 04 Mar 2025 15:25:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741101902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=deI8bh15sX2iTg7jW5FF39oFVK+8sg/AzxDhiwdwSMc=; b=N7Vtg7iCjnRo7ZDCZZc4s84V3we5euKYdVZAMyviNURSjGWUFVHfCmZhq8SDw73khTAtaU c+50+kiX2DPgeE9weB7xIW+aFihE5WkQFdt5PqGhMoCNo9bNo4IKb9K4WvfZ9SIbQ3cIJ6 TiOCyKZLg72oAWm6hSDxqLEHWKcCsT78LaZjYzuVM8jxc8gAY+sd2WsHxPwvisUOkJPx7m X9sAZrIBOTXMZwy+FWsFviuZF4coB/lTem5wUoG/pKRSbl513SXv+R0E4VI3eCPxOQG4TV 5tantGDLZ2T1NtkH9xbu+YK8LorVWy6KwUbuA7Yu90o+Tcem0RuxgJ5HuHdzEA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741101902; a=rsa-sha256; cv=none; b=ecWTMVlGaHkBIaavoeZced6sZlfZqRtTOJheaf5Hi722NGwTc6MxCM6QReG/F9yY2M+lXa 4k1ni7xm5qUJxGDO5KW9ri3g0BI17OEB0Uzb8hHeRKDit4V5xtOgCIcdglETOFpuB5XIAi L43rjoWu+Lq1UtABPbBlfeftiHLxwjPAJxdwuGJ67+LkMBvlRLfrN9zoeBJv/jSzbcXJfR bRR+Ey9bGfpl5gBdqOGlPBPqslVVa8R4JDbcBegEKK4uiwGvokRUVqH4IHzHOu/e8kJgZ2 ECnWs/yqyev8+6GYpx+PqHRkP75sx59X1q6YHn8eQsFTb3O+Xvedt2oWuM4w/w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741101902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=deI8bh15sX2iTg7jW5FF39oFVK+8sg/AzxDhiwdwSMc=; b=KEc2LjvO6S3DnvfjotmqRPLksM8L1qsYTRnEGzt554VrJUx+BoqdXlBCEDNj1cTBv825Uc d6+U/Sva6bYqYp1Z1xAx0d0PtnQOelmdziiOvMB+n/oJCtQRiFTPdQBZV4J256GjKM+m2i E597zZSSyHHkJMf1301RMjd75hjXje6Ibw3lkzriSnB7UhwHfKYVbvn2XhjXylXaZWB1dd 2YI7bh0cYe96ewFV98p1a8/Id/zFwXBUQPrnkmY6iFqbsVYZKeFiGbITlwrFQ8k/nhOzqO qcayDRGFHIofu1tcdT+FktR5VJbWx3h8r1Y4f6FgkDiYXImryXEhGMBvb+pGxw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Z6fct0FXrz7w5; Tue, 04 Mar 2025 15:25:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 524FP1vE011567; Tue, 4 Mar 2025 15:25:01 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 524FP1gm011564; Tue, 4 Mar 2025 15:25:01 GMT (envelope-from git) Date: Tue, 4 Mar 2025 15:25:01 GMT Message-Id: <202503041525.524FP1gm011564@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: d1a37f280be4 - main - LinuxKPI: 802.11: remove ieee80211_node_get_txrate_dot11rate() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d1a37f280be46a707b42c3eca5f8b6a38ecf726b Auto-Submitted: auto-generated The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=d1a37f280be46a707b42c3eca5f8b6a38ecf726b commit d1a37f280be46a707b42c3eca5f8b6a38ecf726b Author: Bjoern A. Zeeb AuthorDate: 2025-03-04 15:20:06 +0000 Commit: Bjoern A. Zeeb CommitDate: 2025-03-04 15:24:05 +0000 LinuxKPI: 802.11: remove ieee80211_node_get_txrate_dot11rate() net80211 ieee80211_node_get_txrate_dot11rate() does not yet support VHT and that means we get a lot of log lines when doing VHT for a debugging statement even if it's not active. Remove the calls to ieee80211_node_get_txrate_dot11rate() as with hw/fw based rate control (modern iwlwifi) they are pointless anyway as they are currently. Sponsored by: The FreeBSD Foundation X-MFC: only if net80211 gets MFCed Reported by: J.R. Oldroyd (jr opal.com) Fixes: 706745001093 (I should have noticed during review) --- sys/compat/linuxkpi/common/src/linux_80211.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/sys/compat/linuxkpi/common/src/linux_80211.c b/sys/compat/linuxkpi/common/src/linux_80211.c index 14c7bab163b6..33b33651b6ad 100644 --- a/sys/compat/linuxkpi/common/src/linux_80211.c +++ b/sys/compat/linuxkpi/common/src/linux_80211.c @@ -6921,12 +6921,6 @@ linuxkpi_ieee80211_tx_status_ext(struct ieee80211_hw *hw, } if (ni != NULL) { -#ifdef LINUXKPI_DEBUG_80211 - int old_rate; - - old_rate = - ieee80211_node_get_txrate_dot11rate(ni->ni_vap->iv_bss); -#endif txs.pktlen = skb->len; txs.flags |= IEEE80211_RATECTL_STATUS_PKTLEN; if (info->status.rates[0].count > 1) { @@ -6943,16 +6937,13 @@ linuxkpi_ieee80211_tx_status_ext(struct ieee80211_hw *hw, txs.flags |= IEEE80211_RATECTL_STATUS_RSSI; } - IMPROVE("only update of rate matches but that requires us to get a proper rate"); + IMPROVE("only update rate if needed but that requires us to get a proper rate from mo_sta_statistics"); ieee80211_ratectl_tx_complete(ni, &txs); ieee80211_ratectl_rate(ni->ni_vap->iv_bss, NULL, 0); #ifdef LINUXKPI_DEBUG_80211 if (linuxkpi_debug_80211 & D80211_TRACE_TX) { - printf("TX-RATE: %s: old %d new %d " - "long_retries %d\n", __func__, - old_rate, - ieee80211_node_get_txrate_dot11rate(ni->ni_vap->iv_bss), + printf("TX-RATE: %s: long_retries %d\n", __func__, txs.long_retries); } #endif