From nobody Mon Jun 16 21:05:41 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bLjGC1m59z5yQDF; Mon, 16 Jun 2025 21:05:55 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4bLjGB4VJXz3vL0; Mon, 16 Jun 2025 21:05:54 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 55GL5ffN048882; Tue, 17 Jun 2025 00:05:44 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 55GL5ffN048882 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 55GL5fIZ048881; Tue, 17 Jun 2025 00:05:41 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 17 Jun 2025 00:05:41 +0300 From: Konstantin Belousov To: Gleb Smirnoff Cc: Mark Johnston , John Baldwin , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4e207e3849d4 - main - exterr: make SET_ERRORX() macros an expression evaluating to the errno Message-ID: References: <202506131940.55DJeTa1046740@gitrepo.freebsd.org> <0003a97e-60ed-4868-8844-0a0346bc97ee@FreeBSD.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on tom.home X-Rspamd-Queue-Id: 4bLjGB4VJXz3vL0 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] On Mon, Jun 16, 2025 at 02:01:26PM -0700, Gleb Smirnoff wrote: > On Sat, Jun 14, 2025 at 08:59:39AM -0400, Mark Johnston wrote: > M> If your suggestion is implemented, then it would be sensible to use a > M> different name to avoid collisions, maybe SET_EXTERROR() or just > M> EXTERROR(). > > I'd vote for EXTERROR(). But now with the function existing, why would > we recommend to use the macro instead of the function at all? Because there is an option to not bloat the kernel with strings. Also there is a desire to provide more info, like amount of the arguments supplied, automatically. It is already EXTERROR(). See vm/vm_mmap.c for exemplary usage. > IMHO, the > function shall be the right use and that will make any macro collisions > with ZFS or whatever void.