Re: git: 948078b65c27 - main - pf: fix !VIMAGE build
- In reply to: Gleb Smirnoff : "git: 948078b65c27 - main - pf: fix !VIMAGE build"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 10 Jun 2025 18:35:48 UTC
On 9 Jun 2025, at 23:19, Gleb Smirnoff wrote: > The branch main has been updated by glebius: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=948078b65c275acfa55afe56a9bbdeb2f61f1e2a > > commit 948078b65c275acfa55afe56a9bbdeb2f61f1e2a > Author: Gleb Smirnoff <glebius@FreeBSD.org> > AuthorDate: 2025-06-10 03:19:04 +0000 > Commit: Gleb Smirnoff <glebius@FreeBSD.org> > CommitDate: 2025-06-10 03:19:04 +0000 > > pf: fix !VIMAGE build Thanks for the fix. I was sure I’d done a make universe, but given the NOINET6 breakage I must be misremembering. Still, that wouldn’t have caught this one. It looks like we don’t have a single kernel config without VIMAGE left, and that makes it a bit harder to detect this sort of breakage. I know that at least Netflix do care about that configuration, so I think we should have a LINT-NOVIMAGE to make it at least a bit more likely that we’ll detect such breakage before commits: https://reviews.freebsd.org/D50780 — Kristof