From nobody Mon Jul 28 14:03:49 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4brKw95g6pz6373D; Mon, 28 Jul 2025 14:04:09 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4brKw91j3Nz3CTB; Mon, 28 Jul 2025 14:04:09 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-60789b450ceso8222402a12.2; Mon, 28 Jul 2025 07:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753711443; x=1754316243; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ew1ho6yWwi5tSm1D8JIsW4uuZgIa3HzZAquj0BZg+b0=; b=JVRjtDm+26vMXHoQm5xG/GAV6aOMSEgn3adKSRKEWE7EfETI/gFqHin5pa0ocROvxp GdpAKbPGIGrdgoWlF0v4IOpG/r9hgGPUH2ro06ly7BbbBAKewpHm8J+80YPKDwnhwqhy wr7Zoa0IMJamN+myraTFz9t6x+GwZ7YYb/FH+p4Kjtxo/WTK+b1jZzd9pvf7RAVRJNiF d6rz3rM7U98jWjk+KLiMLebDJgx1tmT0XrKn1slVZ0JtlexwZ6j9x5kKeFiZh62HsgGW DvMp2jJCLce0iHB/5/Ff/0uBhcxwX4wKz/II5LAM5n5xPupgnjHKe/2F/V6FNehuPncd k6iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753711443; x=1754316243; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ew1ho6yWwi5tSm1D8JIsW4uuZgIa3HzZAquj0BZg+b0=; b=K1MXS9kFkJKm28XNQtVjsM9GgQ3PLQxgMa2cuYHVfTmZlPsOyBlH1BxlrZdJR1nBQt d3sF5mb3EDmZulRb1tqrnEPNhHnQOKwM/I8a6u7JH4Gs73SlQ2ihF+WfGXsRm2t/l0ss ychHzRUr3ccfGoDFBT7tE7IPOXXwqChk66LwQhHMKe/Hk2CW8xcyPPogRYklkqhsXMOE e2QJOWuSLSPX/M7gUxlC2Mnc1qmZbRLSzr9lk/kSVZiACa8TZm+pXth/7IsEIHq8H0Ve lMrHQC/RQRHPj87qRzmh51B+0PYTGcI6F+GCEf7feK65/q8onrBhSfAUiQWJRF1Bu2ar ZAGw== X-Forwarded-Encrypted: i=1; AJvYcCUNj+/zjuDzwfTbIZJyQUNrPasXgvz8GXSHpkdNvPhgrfVntibIFYgxoiI0RnUxC9ufXw==@freebsd.org, AJvYcCVsOIWw6uXvgPqDbLNAZpYg3fQC5jttoEOCT7MgQ2LR1jaKQm5klhOuXXjQhOEyfIoibhs0B3izHKOSw9IB4iQ=@freebsd.org, AJvYcCWc8J47zUGC5Wyie/hqr5snf6awRQTkinjQ1c/jphAr+W0A1dtz+ilmXCH7JWXuIHdmXS+8TUvA@freebsd.org, AJvYcCX+HuSCpjVzFD3HdWobwfW4eO1NRpyRYptY42qhQgoqPUwt/U+1C+06leThVZCdof7eGMCa3Yovq/MazG+VZAyK3saArg==@freebsd.org, AJvYcCX7j87yCwZeSAHf64qH4hhGsoQExSjtkGjFHg/AWOG9/4Z5WEmiUgInEFPTZLnK1akk8di9a7SiAqp+p77C44IINMO6PC8=@freebsd.org X-Gm-Message-State: AOJu0Yzv91sVQHiRX/A9RGsYBGYJXqDHgliHBGPTBhhjITSAp/d1T8fY YPuwBarblL54UQN+2JsBeXBXFXH3/H9jbtmycBDvLC+38L0MYc0OOVkwwop50yEJQ5YPNYRnVAR 7W53wMLEbw8IZiKGsVtZ2iY8TN7HajQ== X-Gm-Gg: ASbGncsTvfvzFAdeO9muZ00tbdvW9zdAdZFQOSgL+vSH7qGy6IyBOEpe9uRmOW/T9Gd r98YWh/BBB2xGdmFUfP1Q7tnkHLG7Wad0uqRHuHETMxkB/927Wg1nMjrdrJLy5K24l0y1wlz6gu NYgOpQd3wcgkdw3/pcHK+6kdwkvfIq94CEhqXMBhOrPQc1cM0GHoxnUX3Rf7TEZopej3A3KfOoq hgsK3dY4KNoAAqO4S31+c4igMHvwhFMtaEA3iU= X-Google-Smtp-Source: AGHT+IHakBJr2tOpZMUhlBwI6XegXZFnQSJUJF9PRr/c+NPdK+8uY8YQ9utVjB4mi4Vj+3uxkdURXcCelqnEa5GA/MI= X-Received: by 2002:a05:6402:40c2:b0:615:5bec:1d5 with SMTP id 4fb4d7f45d1cf-6155bec52eamr1171726a12.7.1753711442027; Mon, 28 Jul 2025 07:04:02 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202507211410.56LEAD6J066633@gitrepo.freebsd.org> <47C3CC37-6F32-4376-900A-B5387B9817D5@freebsd.org> <20250721144645.3BA391BE@slippy.cwsent.com> <20250722155941.AC7EB121@slippy.cwsent.com> In-Reply-To: From: Rick Macklem Date: Mon, 28 Jul 2025 07:03:49 -0700 X-Gm-Features: Ac12FXznyARnWc8CBGhARlv45lH2XaDDKu2BxryfaEMSMnunoJYSh4Eg3yVIol8 Message-ID: Subject: Re: git: c7da9fb90b0b - main - KRB5: Enable MIT KRB5 by default To: Konstantin Belousov Cc: Cy Schubert , Jessica Clarke , Cy Schubert , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4brKw91j3Nz3CTB X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] On Mon, Jul 28, 2025 at 1:20=E2=80=AFAM Konstantin Belousov wrote: > > CAUTION: This email originated from outside of the University of Guelph. = Do not click links or open attachments unless you recognize the sender and = know the content is safe. If in doubt, forward suspicious emails to IThelp@= uoguelph.ca. > > On Sun, Jul 27, 2025 at 08:26:03PM -0700, Rick Macklem wrote: > > On Tue, Jul 22, 2025 at 9:00=E2=80=AFAM Cy Schubert wrote: > > > > > > CAUTION: This email originated from outside of the University of Guel= ph. Do not click links or open attachments unless you recognize the sender = and know the content is safe. If in doubt, forward suspicious emails to ITh= elp@uoguelph.ca. > > > > > > In message , Konstantin Belousov writes= : > > > > On Mon, Jul 21, 2025 at 07:46:45AM -0700, Cy Schubert wrote: > > > > > In message <47C3CC37-6F32-4376-900A-B5387B9817D5@freebsd.org>, Je= ssica > > > > > Clarke w > > > > > rites: > > > > > > On 21 Jul 2025, at 15:10, Cy Schubert wrote: > > > > > > >=3D20 > > > > > > > The branch main has been updated by cy: > > > > > > >=3D20 > > > > > > > URL: =3D > > > > > > https://cgit.FreeBSD.org/src/commit/?id=3D3Dc7da9fb90b0b6385e99= bb7747476359 > > > > b=3D > > > > > > 712993fa > > > > > > >=3D20 > > > > > > > commit c7da9fb90b0b6385e99bb7747476359b712993fa > > > > > > > Author: Cy Schubert > > > > > > > AuthorDate: 2025-07-19 14:11:18 +0000 > > > > > > > Commit: Cy Schubert > > > > > > > CommitDate: 2025-07-21 14:07:22 +0000 > > > > > > >=3D20 > > > > > > > KRB5: Enable MIT KRB5 by default > > > > > > >=3D20 > > > > > > > Set WITH_MITKRB5=3D3Dyes as the default. > > > > > > >=3D20 > > > > > > > Rebuild all USES=3D3Dgssapi ports is recommended. > > > > > > >=3D20 > > > > > > > A clean buildworld is required. > > > > > > > > > > > > That=3DE2=3D80=3D99s going to be quite annoying and cause a lot= of issues =3D > > > > > > given > > > > > > WITH_CLEAN is now the default. Can we do something in depend-cl= eanup.sh > > > > > > to delete everything from the obj tree that needs to be rebuilt= if we > > > > > > detect the wrong kerberos implementation was previously built? > > > > > > > > > > All binaries that depend on any kerberos libraries must be rebuil= t. > > > > > WITHOUT_CLEAN will fail at various spots. Meta mode should take c= are of > > > > > this for us. > > > > Does the statement mean that ABI for the base libraries was broken? > > > > If yes, and the new libs have the same name as the old, we must bum= p > > > > dso versions. > > > > > > Three new libs have the same names. Most don't. The three with the sa= me > > > names are libkrb5, libgssapi_krb5 and libcom_err. > > > > > > libgssapi_krb5 is a merge of the Heimdal libgssapi_* files. For examp= le, > > > there is no libgssapi_spnego in MIT. > > > > > > The libcom_err contains the same but updated MIT functions. > > > > > > libkrb5 removes Heimdal-only functions. > > > > > > There is no libasn1 nor libroken in MIT. > > > > > > The differences are outlined at https://k5wiki.kerberos.org/wiki/Samb= a%27s_u > > > se_of_Heimdal_symbols,_with_MIT_differences. > > I know diddly about how libraries are handled, but is it possible to pu= t the > > old Heimdal 1.5.2 libraries somewhere (semi-private) under different na= mes? > > > > I ask because it is going to be very difficult to port the gssd to the > > new libraries. > > > > The problem is that the KGSSAPI code assumes some stuff very specific > > to Heimdal. Take a look at sys/kgssapi/krb5/krb5_mech.c and you'll see > > what I mean. (There's code that parses the keys etc out of the internal= ly > > generated tokens. I have no idea where to even find the information on > > how/where the MIT code hides this stuff and it a large part of krb5_mec= h.c > > looks like it will have to be re-written to work with the MIT libraries= .) > > It might be better to extract the required bits and keep just them. > Perhaps even moving that bits from vendor to FreeBSD-owned code area. The problem is that the code in sys/kgssapi/krb5/krb5_mech.c does contain bits extracted from the Heimdal code. Basically, a detailed knowledge of an internal structure that the keys are extracted from. --> I am now thinking that adding an upcall to the gssd and letting it extr= act the keys might be a better plan. (At least it moves the maintenance t= o userland and, hopefully, library calls can replace the detailed knowl= edge about the internals of the implementation.) > > I do not think that keeping large pieces of code in vendor without update= s > is a good plan. Agreed. I'll work on it. (But no guarantees w.r.t. timeline.) Maybe doing a transition to Heimdal 7.8 (or 8.n) would be less painful? (It looks like Heimdal is getting maintenance these days. I think Debian is using it, which suggests it will get at least some TLC?) rick