From nobody Sat Jul 26 16:45:48 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bq9bc4K9gz62Bg5; Sat, 26 Jul 2025 16:45:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bq9bc3lp1z3Lyg; Sat, 26 Jul 2025 16:45:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753548348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9ohQ+qP0kr5e6eCgjMwfwfAK2mcaRKs22LJTn38JS1E=; b=LJiOm+wEE7wAznSPHPcAusliYdN4Pnqx4wdokwWWJh9ISZAw3eg5lxTx3Xvl2aKgK2oEWE io41wUgm8Dsri5C+rpbRdAjtuc+zP0eXhc9L7gbz7ShUHGBjkP40Po7DJOM9/H0T7xyHEH E7Ll2uPL3kZcuDMflsPLisF2kJHRKjR0MloAz6ZXJ4IkCE9Aij/ytjIsBr1+ioKUj0JtVV ZYf+rgMJsgAVOq99eOByJr2MTjQowpNnuBq7c4l2MCIUrGGhYvQ1ZYpF839bqIUJH+Ksj3 9VNlR5FzyH3rT0t60oCViz7cEyLymXjTabSIXWeOxPZr+o3ogTTU4GqZQ0AuXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753548348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9ohQ+qP0kr5e6eCgjMwfwfAK2mcaRKs22LJTn38JS1E=; b=JxxAgecpasP7TcRGs5UIQ5kObcYVVFCaebqcB/n+Mg8eINILJsgtKYWTBc3rpWD7s3UxIw EZVU7TVVmgVRiXTpSeExc6k+SLFLLpZ2XUkfbdLTO9z6zoZvUvZiz0xn/+e+Qyx9Pt1sWw hm7yTccvKnlASuUWzvRbdVvRfsHOxAQZt+OLZhjQhfPF1zIXyFkX6hRuXV7KxJ7p7S+2Qs 77/IKu/UcdmLt5dYB2DgwH4S7RYG4018LbF4CLWDFhtQoDsx8noUV3uWIcpCkhpdaFrY7I M8lqkp203xnyZD2lnfANXv2IakwI1EDwLhtV7Nd3KqZyv5m9/ortx/ZMMNNMAQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1753548348; a=rsa-sha256; cv=none; b=B8YX8STHZDh9v9/BpLDmrLL0kdDrcbOzvOqk5VvMoMaClM2kkTOKaXuE6MuRXV8Fh1S6pw GJQk+c2LV6GFGaiHF1cmLHHJX+H2Y2y6O6SC8iaX/dwCiEPjQqMpSAmF+3Xjq02SJUG8A6 l/u2z4r5PB8fjyidm2wFpCdRqi0LNQDRr+sSJAGHNotKqIfKycYytWxT1XZVU+Ft9J2b/D drEc7v6G7eyxgrTgM9tVnqX2+SKE5GFFPwAdX7cRQ76Owryqm+XKAYDERJhEb9Pn3p33z5 c9unCrGDddnZ4FYnq2ipGu0KP8Cfq3bAckyUeLcIq35FrJ1uatpOgQ4CsVVdqw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bq9bc3LhqzfBh; Sat, 26 Jul 2025 16:45:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56QGjmuE026427; Sat, 26 Jul 2025 16:45:48 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56QGjmcm026424; Sat, 26 Jul 2025 16:45:48 GMT (envelope-from git) Date: Sat, 26 Jul 2025 16:45:48 GMT Message-Id: <202507261645.56QGjmcm026424@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling =?utf-8?Q?Sm=C3=B8rgrav?= Subject: git: a7fa987abe1f - main - xargs: Limit -n to {ARG_MAX} List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a7fa987abe1fb0b25a7dd83dc81f14f64a82efc9 Auto-Submitted: auto-generated The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=a7fa987abe1fb0b25a7dd83dc81f14f64a82efc9 commit a7fa987abe1fb0b25a7dd83dc81f14f64a82efc9 Author: Dag-Erling Smørgrav AuthorDate: 2025-07-26 16:44:35 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2025-07-26 16:44:35 +0000 xargs: Limit -n to {ARG_MAX} Since it's not possible to pass more than {ARG_MAX} bytes on the command line, it's also not possible to pass more than {ARG_MAX} individual arguments. Therefore, {ARG_MAX} is a reasonable upper bound for the -n option. This resolves both the arithmetic overflow issue and the CI OOM issue, so we can safely re-enable the test. Fixes: eab91d008165 Fixes: 2682a1552724 MFC after: 1 week Reviewed by: jlduran, emaste Differential Revision: https://reviews.freebsd.org/D51536 --- ObsoleteFiles.inc | 3 +++ usr.bin/xargs/tests/Makefile | 2 +- .../xargs/tests/{regress.n2147483647.out => regress.nargmax.out} | 0 usr.bin/xargs/tests/regress.sh | 8 ++++---- usr.bin/xargs/xargs.c | 2 +- 5 files changed, 9 insertions(+), 6 deletions(-) diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc index 10f99c5d6047..00f889804013 100644 --- a/ObsoleteFiles.inc +++ b/ObsoleteFiles.inc @@ -51,6 +51,9 @@ # xargs -n1 | sort | uniq -d; # done +# 20250726: Test case renamed +OLD_FILES+=usr/tests/usr.bin/xargs/regress.n2147483647.out + # 20250726: This file is now installed in /etc/dma OLD_FILES+=usr/share/examples/dma/auth.conf diff --git a/usr.bin/xargs/tests/Makefile b/usr.bin/xargs/tests/Makefile index b1e6782069de..1a9265b88b4e 100644 --- a/usr.bin/xargs/tests/Makefile +++ b/usr.bin/xargs/tests/Makefile @@ -17,7 +17,7 @@ ${PACKAGE}FILES+= regress.R-1.out ${PACKAGE}FILES+= regress.in ${PACKAGE}FILES+= regress.n1.out ${PACKAGE}FILES+= regress.n2.out -${PACKAGE}FILES+= regress.n2147483647.out +${PACKAGE}FILES+= regress.nargmax.out ${PACKAGE}FILES+= regress.n2P0.out ${PACKAGE}FILES+= regress.n3.out ${PACKAGE}FILES+= regress.normal.out diff --git a/usr.bin/xargs/tests/regress.n2147483647.out b/usr.bin/xargs/tests/regress.nargmax.out similarity index 100% rename from usr.bin/xargs/tests/regress.n2147483647.out rename to usr.bin/xargs/tests/regress.nargmax.out diff --git a/usr.bin/xargs/tests/regress.sh b/usr.bin/xargs/tests/regress.sh index 9b4839d2a8ec..e65a5a703505 100644 --- a/usr.bin/xargs/tests/regress.sh +++ b/usr.bin/xargs/tests/regress.sh @@ -1,5 +1,5 @@ -echo 1..21 +echo 1..23 REGRESSION_START($1) @@ -12,9 +12,8 @@ REGRESSION_TEST(`R', `xargs -I% -R1 echo The % % % %% % % <${SRCDIR}/regress.in' REGRESSION_TEST(`R-1', `xargs -I% -R-1 echo The % % % %% % % <${SRCDIR}/regress.in') REGRESSION_TEST(`n1', `xargs -n1 echo <${SRCDIR}/regress.in') REGRESSION_TEST(`n2', `xargs -n2 echo <${SRCDIR}/regress.in') -# This test may consume a large amount of memory, making it unsuited to CI -# environments. Disable it for now. -#REGRESSION_TEST(`n2147483647', `xargs -n2147483647 <${SRCDIR}/regress.in') +argmax=$(sysctl -n kern.argmax) +REGRESSION_TEST(`nargmax', `xargs -n$argmax <${SRCDIR}/regress.in') REGRESSION_TEST(`n2P0',`xargs -n2 -P0 echo <${SRCDIR}/regress.in | sort') REGRESSION_TEST(`n3', `xargs -n3 echo <${SRCDIR}/regress.in') REGRESSION_TEST(`0', `xargs -0 -n1 echo <${SRCDIR}/regress.0.in') @@ -28,5 +27,6 @@ REGRESSION_TEST_FREEFORM(`parallel1', `echo /var/empty /var/empty | REGRESSION_TEST_FREEFORM(`parallel2', `echo /var/empty /var/empty/nodir | xargs -n1 -P2 test -d; [ $? = 1 ]') REGRESSION_TEST_FREEFORM(`parallel3', `echo /var/empty/nodir /var/empty | xargs -n1 -P2 test -d; [ $? = 1 ]') REGRESSION_TEST_FREEFORM(`parallel4', `echo /var/empty/nodir /var/empty/nodir | xargs -n1 -P2 test -d; [ $? = 1 ]') +REGRESSION_TEST_FREEFORM(`ntoobig', `seq 42 | xargs -n$((argmax+1)); [ $? = 1 ]') REGRESSION_END() diff --git a/usr.bin/xargs/xargs.c b/usr.bin/xargs/xargs.c index 237beff26504..2a7f026e5066 100644 --- a/usr.bin/xargs/xargs.c +++ b/usr.bin/xargs/xargs.c @@ -166,7 +166,7 @@ main(int argc, char *argv[]) break; case 'n': nflag = 1; - nargs = (int)strtonum(optarg, 1, INT_MAX, &errstr); + nargs = (int)strtonum(optarg, 1, arg_max, &errstr); if (errstr) errx(1, "-%c %s: %s", ch, optarg, errstr); break;