From nobody Wed Jul 23 06:22:07 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bn3vN1Zhdz5q11b; Wed, 23 Jul 2025 06:22:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bn3vM74jHz3tbP; Wed, 23 Jul 2025 06:22:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753251728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DDKrphTNDNiLqUO8eozrMTmlPXGr2guyY7yiMM/bLk0=; b=C1ldJ1/BJhy/2Zz4iIIBZdyFFLCUzAJDls8XyjK494kqAXCsEIFd9MXtt6I+K1wTBoKyL7 c6mcbH+PxcR5kCPVk93kgMIy2lC6aRfCOuBrpLqrNQzs8ni6DD5YpWXBgzOSaJb/CJro2m g/RCzml4+6Eb4bNaiSqwqJVH5Yqmx5vduv9W4p+QDQCK7caO5ORBG4fblZwj/ThV51YMYz rjP2B6RvQ/7OlANCj4f3pUKzODWttIc0EMUvr7AGK/CS109exputJomWpBRGuxNzt1x2T8 8SdqZwAwj5ok4RxQqtCEoO1kWlhRJrLGJ4tvYsDG87EtW5JvABimksCLPb82dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753251728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DDKrphTNDNiLqUO8eozrMTmlPXGr2guyY7yiMM/bLk0=; b=qTA5MmO1lV8VYCfAkxpW+bc5V4gVEeIM81LFu27sCudqvDxFrTp6WJTfcjrBhn9rB5byEd VKevArQ2HD0HtbB0sQDh0IeK5JztKLgE7wK6d4OYj6CQsipTifVQVq5pgNGz/niyaawsD8 eIeB5JlWYn1lwJOAd8SBzr+QVz+UwqLVMMQCFk4/bYc5AxkA4sMomoG53X3c0gErjWLfKr SR9FBC+MP4CHHuhWdQ1iOk9EL0fEhnpCBnQwbqpxdFuX8PnJMZ/GVlT+uwSCLHDTX7yM++ 50+vWKqYAycQkAi5U5YfFyKRjXw0UqpZGGJQLirWqENFPZrgkLTe4q/8/MPzfA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1753251728; a=rsa-sha256; cv=none; b=T7zU/hwVeMzJc5TfJVXeUTRm6NV2hEVtUVnguWQLH20dcQBTxxF8cJ/cmiGsxz5t6fZtM4 N6yKLrZHUzYrUKUv0J3I7fS0CTTvC1KChNHJB36b9Y/NvJMKZiGqo4TvUgSi+krhDFY4wH P53+/a4kOreQYN7Ts8/crjALG0XmwGwyWcqR3w2rza2VtR3IwQN5PZoxMkoFeOs+vBpd2c erpZKNOpOY4SioOtwFjzhJRGQriO2lOs5LXdPwlsBu645Ur7TCKdtlFBDtvlHmOfbvd8lu +DbJrOgsRIhjqVmQgK+cOg4PcPP69KNi2hYapa+OUd1sYliybp12mxtagOiYCA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bn3vM6dKTz11f6; Wed, 23 Jul 2025 06:22:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56N6M7B5020311; Wed, 23 Jul 2025 06:22:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56N6M7lE020308; Wed, 23 Jul 2025 06:22:07 GMT (envelope-from git) Date: Wed, 23 Jul 2025 06:22:07 GMT Message-Id: <202507230622.56N6M7lE020308@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: c599948cca4b - main - devd: accept new clients before notifying them List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c599948cca4b860cedc7b2a2b60c0ce81f9b1bd0 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=c599948cca4b860cedc7b2a2b60c0ce81f9b1bd0 commit c599948cca4b860cedc7b2a2b60c0ce81f9b1bd0 Author: Sludge AuthorDate: 2025-07-17 05:36:20 +0000 Commit: Warner Losh CommitDate: 2025-07-23 05:57:31 +0000 devd: accept new clients before notifying them Signed-off-by: Sludge! Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/1771 --- sbin/devd/devd.cc | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sbin/devd/devd.cc b/sbin/devd/devd.cc index 6705dcc0158e..1ff405244cde 100644 --- a/sbin/devd/devd.cc +++ b/sbin/devd/devd.cc @@ -1111,6 +1111,14 @@ event_loop(void) err(1, "select"); } else if (rv == 0) check_clients(); + /* + * Aside from the socket type, both sockets use the same + * protocol, so we can process clients the same way. + */ + if (FD_ISSET(stream_fd, &fds)) + new_client(stream_fd, SOCK_STREAM); + if (FD_ISSET(seqpacket_fd, &fds)) + new_client(seqpacket_fd, SOCK_SEQPACKET); if (FD_ISSET(fd, &fds)) { rv = read(fd, buffer, sizeof(buffer) - 1); if (rv > 0) { @@ -1139,14 +1147,6 @@ event_loop(void) break; } } - if (FD_ISSET(stream_fd, &fds)) - new_client(stream_fd, SOCK_STREAM); - /* - * Aside from the socket type, both sockets use the same - * protocol, so we can process clients the same way. - */ - if (FD_ISSET(seqpacket_fd, &fds)) - new_client(seqpacket_fd, SOCK_SEQPACKET); } cfg.remove_pidfile(); close(seqpacket_fd);