From nobody Wed Jul 23 06:22:12 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bn3vS4v4fz5q0W4; Wed, 23 Jul 2025 06:22:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bn3vS3Tf3z3tmV; Wed, 23 Jul 2025 06:22:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753251732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OID1lg1nC37qzUGlhmlTcJMSFlkgRNH3DcuEVh0jXu0=; b=l8n4b7vpzSukftXUriYBvHRvnTnqq+l7Tuvdd5YzoE8h8uOY47Ev9czY2p5w5kdn05Rsjq F5UykSlBn0Fdtp1MfHmakV3q/Dz0ZWUfr5JWrQ+z9bO7uY6DXyWe+GtZozH2xBUH9c/K2Q e8MbWWxe5aYrt92ZTkhHSnRpLiMU+TgtVLkCs7rNwe9ONQkWDFW0r/gGvs5I51q2bJ1oyv dPKKFA5XOo1vrFt3PN0Hec0Bpjz88keMxKZrz43wuSl8qGIGdaIaoEZqs2vLXLk9JybS5A CUen6je1M+7j20ms59EZcPlEMxPo0pSGlFiwYWUp57Xkh0QWpBHD4ewhDgLUaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753251732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OID1lg1nC37qzUGlhmlTcJMSFlkgRNH3DcuEVh0jXu0=; b=WvMyz375qQK7qrlD2Kn45S7/oXT5/w/dtQY6QG7mhO6XdLHAEc+CtOPe7FH+25oGrf1Uzh i+wrLrYkwS4hR4VACv49H5FCxxt+1Gr7pb1U0oBAde7Dp2RjdFkQqPECbDLcHAhIe4Apae 63hK3SUO4x0EtQSEqZr78HQwcVjuOscml+E/DtzxTI7hyIZNK15/zkqC7y1a06U84ji3vR Eg4dSPTBnXwr7N0JO72berbtly/R4c06ln5HZg7UIeTFDnWTG4CXumDx20JW+f5PyffqcJ O1Ub1oke8NEJ10TzxnzALa3Dpk4Ri1rmrEFo3PMniQO7ITcK/HENSZZmBU1sGw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1753251732; a=rsa-sha256; cv=none; b=wH+NFrT9fDD9CnuzUuvPAXycfBsTtnrjUDFaGtNw4SDkgBJWoEZdClBfAwCFsodNgOGnI3 pk6bt8bfC+wzTwj++0cIsrip1LjrHY7QZjaL+LvnOyUD7ND2uX/yoRsmcKXLdpxcsSZgIF O7uaWkhqLTCsvDal5SBE9xkDhBBa3JtIar7yUPWziLHx/PsAAKWEDEojjLnkr3Wrnfiy9D GTxeH6dKMIOaqGKjZqxJZnbfJJ/NBvLwVHOySMgDCPs1prlS8ARdxIXsEBjWGMvzctGTry sn/R0u0RVfRbKb2mqsHW7vLzcb0tdyGi8AKtmxLwdM1KJl6BuJ9J/VXrW3h13A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bn3vS2rvbz11N8; Wed, 23 Jul 2025 06:22:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56N6MCgN020448; Wed, 23 Jul 2025 06:22:12 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56N6MCIO020445; Wed, 23 Jul 2025 06:22:12 GMT (envelope-from git) Date: Wed, 23 Jul 2025 06:22:12 GMT Message-Id: <202507230622.56N6MCIO020445@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: f4e7cb535b9c - main - gvirstor: in virstor_ctl_remove() the copy length of the second bcopy might be wrong. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f4e7cb535b9cb1ddd608b382f29d8123931d5212 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=f4e7cb535b9cb1ddd608b382f29d8123931d5212 commit f4e7cb535b9cb1ddd608b382f29d8123931d5212 Author: Wuyang Chung AuthorDate: 2025-07-12 16:09:36 +0000 Commit: Warner Losh CommitDate: 2025-07-23 06:03:48 +0000 gvirstor: in virstor_ctl_remove() the copy length of the second bcopy might be wrong. Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/1763 --- sys/geom/virstor/g_virstor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/geom/virstor/g_virstor.c b/sys/geom/virstor/g_virstor.c index b8cf32875660..73bd9f73055a 100644 --- a/sys/geom/virstor/g_virstor.c +++ b/sys/geom/virstor/g_virstor.c @@ -589,7 +589,7 @@ virstor_ctl_remove(struct gctl_req *req, struct g_class *cp) M_GVIRSTOR, M_WAITOK | M_ZERO); bcopy(sc->components, newcomp, found * sizeof(*sc->components)); bcopy(&sc->components[found + 1], newcomp + found, - found * sizeof(*sc->components)); + (sc->n_components - (found + 1)) * sizeof(*sc->components)); if ((sc->components[j].flags & VIRSTOR_PROVIDER_ALLOCATED) != 0) { LOG_MSG(LVL_ERROR, "Allocated provider %s cannot be " "removed from %s",