From nobody Mon Jul 21 15:35:04 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bm4GJ5GLNz62nJt; Mon, 21 Jul 2025 15:35:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bm4GJ3fpJz3m8R; Mon, 21 Jul 2025 15:35:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753112104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=f/0g6OFtE2ZogROjbNjKTOIE7ur0JDpvjFPo4qX9itk=; b=ce4ZK9ZlL6qwo0GPuWJ4CjZ7Md8IszDSkDQkQniR+NEttjiKxQuHNog6grAoBPX40deT9l vjp0fN7MktFvmXrMk1U9WQ92j7F8QqZBuRv7cg4/mZKAVh8AV9WouhUu+9kOZj59WXz1w4 m8BeuERt9iL/3EjP2OlfXXUG8+z/Dtp/hBEY512TGu/UG1sjlbsfs/oIiH0Jba2xqrtpRV b8epee1ZNiYgQ9FFD6hSRjU6n7XZHqTPwj09FY5LR6AwHwmWfK5qF9fdEQVADmEgCvtQSM OhzQXFs7TZVPy8QoLytfnZmRsXGm9bQ2/S7kKE4MuwzbOMSNKrcduKxX6xgWLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753112104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=f/0g6OFtE2ZogROjbNjKTOIE7ur0JDpvjFPo4qX9itk=; b=AHFONCds40Fp8mVUYwnVzZBrJFkFIs3BKWJIrHBfNmQ9pAMY9LOdS/PVuAqgsQRno9PmvU Cr0w46p69awQbPzDFQEb3Zjgcsoy2Giqihx1XW7/1gMdE8G3pJERFlTXwd0DGqHODbtWD/ r0ieUv+yVdqJHwB2DpKtgWQxHu0aSrZXmSOixtQ7JaWyzl29xwNwmEaH5qf4T8sn1hzuuS hIp7/mAPwujdGeVNVruPqJC+15E/5IN5Ml0NcPBcuHONIqY9ES8yzhpJfbXHueXQ2s46I5 8aYqLTpi57N1mgGKZ4j2OziDtCMqOa3JHo2vA9NVpiZOG8JL3qb6wQ7jBClApg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1753112104; a=rsa-sha256; cv=none; b=drJITSjLVvNQowoEOMpEc5UDESvYOLiM3roDKH89Ke+IAaJdIGg71syJhh1lhsC3o2h1y6 YJkjveFAPBt/J9PmMok/0zaSOlil+F6aCVY3dwP+TEYaFZ8NOJbCxr2MGM/25m8mGqGmBf reWQLPGG08bcrfriYRDEvcv2dMc02ZYVb5xrhILGqGpLjIjIiIMIyWr6151gMEUlP3BsrV AH+NhDCzo2DGVZp7w0/m1r1Nbr2UHyEIMLIv4uuZm+Pb/0dYF11Xu5CU8OQpJ2Do0+bVV1 7lqwkXCv3k2/YUXjfKXPNEJARAoq9xvsfzrlrhwgCIDssSplv8UmvHIMxig2cw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bm4GJ30wgz12hk; Mon, 21 Jul 2025 15:35:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56LFZ4T9028465; Mon, 21 Jul 2025 15:35:04 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56LFZ4xI028462; Mon, 21 Jul 2025 15:35:04 GMT (envelope-from git) Date: Mon, 21 Jul 2025 15:35:04 GMT Message-Id: <202507211535.56LFZ4xI028462@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: de2936aa3675 - main - tcp rack: fix clearing of app limited periods List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: de2936aa36754d1b63475f41a1d1429ae6fdfad8 Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=de2936aa36754d1b63475f41a1d1429ae6fdfad8 commit de2936aa36754d1b63475f41a1d1429ae6fdfad8 Author: Peter Lei AuthorDate: 2025-07-21 14:01:43 +0000 Commit: Michael Tuexen CommitDate: 2025-07-21 14:01:43 +0000 tcp rack: fix clearing of app limited periods Use the correct variable in the correct way. The app limited period is cleared when gp_seq is greater than or equal to cleared_app_ack_seq. Reviewed by: rrs, tuexen, Nick Banks MFC after: 1 week Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D51441 --- sys/netinet/tcp_stacks/rack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c index 5280f18dc983..834e1347a152 100644 --- a/sys/netinet/tcp_stacks/rack.c +++ b/sys/netinet/tcp_stacks/rack.c @@ -17987,7 +17987,7 @@ start_set: tp->gput_ack = tp->gput_seq + rack_get_measure_window(tp, rack); rack->r_ctl.rc_gp_cumack_ts = 0; if ((rack->r_ctl.cleared_app_ack == 1) && - (SEQ_GEQ(rack->r_ctl.cleared_app_ack, tp->gput_seq))) { + (SEQ_GEQ(tp->gput_seq, rack->r_ctl.cleared_app_ack_seq))) { /* * We just cleared an application limited period * so the next seq out needs to skip the first