From nobody Tue Jul 08 06:03:00 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bbrBG5cFdz61h3l; Tue, 08 Jul 2025 06:03:02 +0000 (UTC) (envelope-from herbert@gojira.at) Received: from mail.bsd4all.net (mail.bsd4all.net [94.130.200.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4bbrBG1WFNz3nTn; Tue, 08 Jul 2025 06:03:02 +0000 (UTC) (envelope-from herbert@gojira.at) Authentication-Results: mx1.freebsd.org; none Date: Tue, 8 Jul 2025 08:03:00 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=gojira.at; s=mail202005; t=1751954580; bh=qLIvuLYlOuv7tFrDyCNfrouZvOi/S0wwd7M6jovdamk=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type; b=Q1PLETA0/a/jZb9ctRSIV2lJjluqIZevgd8KriYohYPrgFW7PkNzfI434GkqkXQF+ WR/Yx8dg8Ab81hwv0NiYcI8DkDsLQYCKmMQ9sB3vBF++eCwncrNa76G1fmQiU+TOlP REinvUTM77z2I+18CK03S6sia7Yr1mceurCf/pPuILE5vNxXVSOlqeLKI8x7eyX4ny 6iGQ/GF6AvYFCiE9KQsqtAxC+fAJwphdAreIX0xfmxgIrxvUF5Ec/ycd7pzt1rqJET fP7pIZIRSlaxLVqkm00fLIUkwCZvQhJk/m9wVb555FD5ITTNZPRagEu1LTtLP8/J4c m67y1FMR/pBYg== From: "Herbert J. Skuhra" To: Cy Schubert Cc: Dima Panov , Cy Schubert , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 7e35117eb07f - main - Makefile: Hook MIT KRB5 into the build Message-ID: References: <202506160251.55G2pwx4063231@gitrepo.freebsd.org> <20250620073050.7f03f74e@slippy> <20250707230446.F279E3A1@slippy.cwsent.com> <20250708042825.669BF20E@slippy.cwsent.com> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250708042825.669BF20E@slippy.cwsent.com> X-Rspamd-Queue-Id: 4bbrBG1WFNz3nTn X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:24940, ipnet:94.130.0.0/16, country:DE] On Mon, Jul 07, 2025 at 09:28:25PM -0700, Cy Schubert wrote: > In message , "Herbert J. Skuhra" writes: > > On Mon, Jul 07, 2025 at 04:04:46PM -0700, Cy Schubert wrote: > > > In message , "Herbert J. Skuhra" writes: > > > > On Mon, Jul 07, 2025 at 10:36:31PM +0300, Dima Panov wrote: > > > > > Hello! > > > > > > > > > > > > > > > BTW, it looks like symlink for libkadm5clnt.so is broken and produced a > > bad > > > > file > > > > > $ ls -la libkadm5clnt > > > > > lrwxr-xr-x 1 root wheel 13 7 Jul 20:40 libkadm5clnt -> kadm5clnt_mit > > > > > > > > > > instead of assumed libkadm5clnt.so -> kadm5clnt_mit.so > > > > > > > > > > > > > > > Please review: > > > > > > > > > > diff --git a/krb5/lib/kadm5clnt/Makefile b/krb5/lib/kadm5clnt/Makefile > > > > > index e377f95f5b6e..be09dd3e210e 100644 > > > > > --- a/krb5/lib/kadm5clnt/Makefile > > > > > +++ b/krb5/lib/kadm5clnt/Makefile > > > > > @@ -88,7 +88,7 @@ ${CHPASS_UTIL_STRINGS_ERR_C}: ${CHPASS_UTIL_STRINGS_E > > RR} > > > > > rm -f et-c-${.PREFIX}.et et-c-${.PREFIX}.c > > > > > > > > > > afterinstall: > > > > > - ${INSTALL_LIBSYMLINK} ${SHLIB} ${DESTDIR}${LIBDIR}/libkadm5clnt > > > > > + ${INSTALL_LIBSYMLINK} ${SHLIB_NAME} ${DESTDIR}${LIBDIR}/libkadm > > 5cln > > > > t.so > > > > > > > > > > .include > > > > > > > > This produces a valid symlink that 'make delete-old' wants to > > > > remove again: > > > > > > > > lrwxr-xr-x 1 root wheel 23 Jul 7 22:26 /usr/lib/libkadm5clnt.so -> > > > > libkadm5clnt_mit.so.121 > > > > > > > > # make delete-old > > > > >>> Removing old files (only deletes safe to delete libs) > > > > remove /usr/lib/libkadm5clnt.so? > > > > > > Thanks Dima and Herbert for reporting this. It's been fixed. > > > > Cy, I am sorry for not being more precise. > > > > Dima's change, which hasn't been commited yet, fixes the real issue of > > creating a bad symlink. > > > > I just wanted to add that his fix also needs removal of > > usr/lib/libkadm5clnt.so in tools/build/mk/OptionalObsoleteFiles.inc. > > > > Maybe usr/lib/libkadm5clnt should be added to OptionalObsoleteFiles.inc? ^^^ no .so And maybe ObsoleteFiles.inc is the correct file to add this entry to. > libkadm5clnt.so is a legitimate symlink for both MIT and Heimdal. In the > case of Heimdal it points to libkadm5clnt.so.11. Whereas for MIT it points > to libkadm5clnt_mit.so.121. There is o libkadm5clnt in MIT. It is > libkadm5clnt_mit. You can see this in the port with pkg info -l as follows: > > slippy$ pkg info -l krb5 | grep libkadm5clnt > /usr/local/lib/libkadm5clnt.so > /usr/local/lib/libkadm5clnt_mit.so > /usr/local/lib/libkadm5clnt_mit.so.12 > /usr/local/lib/libkadm5clnt_mit.so.12.0 > slippy$ Without Dima's fix the following symlink is created: lrwxr-xr-x 1 root wheel 13 Jul 8 02:51 /usr/lib/libkadm5clnt -> kadm5clnt_mit No .so extension and /usr/lib/kadm5clnt_mit does not exist. $ file /usr/lib/libkadm5clnt /usr/lib/libkadm5clnt: broken symbolic link to kadm5clnt_mit With Dima's fix the following symlink is created: lrwxr-xr-x 1 root wheel 23 Jul 8 03:11 /usr/lib/libkadm5clnt.so -> libkadm5clnt_mit.so.121 This fix hasn't been committed yet. Commit aad5020c709ac4231af88d4b74588a28f87c9497 only removed /usr/lib/libkadm5clnt.so from OptionalObsoleteFiles. In my previous e-mail I was only suggesting to remove the broken symlink: usr/lib/libkadm5clnt. I really hope I don't add more confusion to this issue.