Re: git: f8a8bb7bade9 - main - pfctl: Improve duplicate table name warning
- In reply to: Kristof Provost : "git: f8a8bb7bade9 - main - pfctl: Improve duplicate table name warning"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 07 Jul 2025 17:26:22 UTC
> On Jul 7, 2025, at 11:07 AM, Kristof Provost <kp@FreeBSD.org> wrote: > > The branch main has been updated by kp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=f8a8bb7bade9575c549cbc94500ba706b712c650 > > commit f8a8bb7bade9575c549cbc94500ba706b712c650 > Author: Kristof Provost <kp@FreeBSD.org> > AuthorDate: 2025-07-01 10:02:03 +0000 > Commit: Kristof Provost <kp@FreeBSD.org> > CommitDate: 2025-07-07 15:06:48 +0000 > > pfctl: Improve duplicate table name warning > > When creating tables inside anchors, pfctl warned about namespace > collisions with global tables, but only in certain cases and with > limited information sometimes leaving users clueless. > > Deferring the check to process_tabledefs() where tables are eventually > created, both anchor and table name are known which allows for checking > all existing anchors. > > With this, warn on all duplicates even in dry-runs (`-n') and print > quoted names so they can be copied to fix configurations right away. > > No functional change in parsing or ruleset production. Based only on the commit message, this may fix PR #262295. Thanks, Matteo