From nobody Mon Jul 07 15:08:08 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bbSKh6bfcz61w3K; Mon, 07 Jul 2025 15:08:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bbSKh2j9Pz3wXB; Mon, 07 Jul 2025 15:08:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751900888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QUXy/pKRFYw9Ib7SwcJ3Gj08zkN0jp6/x0aqc4bcwMw=; b=Dc/YrCBVyHakzZdffxeD0eLOKrZHBq8FDXIbDmH2YzsMVcPggOGR/GC5jdi3mJeI8MxGaI v8zQnJl0S/UGFN7cqPVj7i5D/aKXV8oiguhzlNFoIk6l9AHUCi+BnX9mYinweYuM6Z3QNw 25R8NCkc64c9uPS9Rajco92f05dD6UBoZVSAFn4q/WgVhg+V7M1EjdInTtvy5fwCBKB7xC eK6F+IAHmo4s5K54YDBR1sDh9hxLLqANMdOZ+Gjbi0JvUHr+gbSiLYORGdrfOlNRFnGQdE 9piUq4gnM7csNfj+VbJRE36FRM56hVfnDqnTt2Cybmd4srJN6RvAoTkDtlNtSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751900888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QUXy/pKRFYw9Ib7SwcJ3Gj08zkN0jp6/x0aqc4bcwMw=; b=GTmoTd186R5jpZqq9eZz/FWRpA/4jUsbGrAGehAoaI8aMVIN8jD9ZfEjsG4SrK7MDynfdg 0tGW+PobDcAHRZsEijHXbh7jO8mS3giLgk4VKfiuCgTM3JP1WZ6ut4voi5YPk+vsAwrIu2 Yz2Bzk39QjyyQHhqqK+L6ugDHhXZ5NVil9y1cIJgktVT5pXiB6kNaFEUgqFp8jb350brP6 SqGl/qM8mkuFXSWvN8Hv3DfjMDUuXG8VWpNZOoXUtWgNzuA5H4VLcYKTdMvZYVngzWO/mZ ukikaCWugS2Bzv3XKbBPJBlRUeg3t+LFC3t4+L4UGsOsZsLXz8rO5+WMheaoyw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751900888; a=rsa-sha256; cv=none; b=Puo3owIaDAXjeyNIwU4xIOVi/7upQPA0LxjcIfqJm/QiBIz+oXlPPiDW9JxUVfwkj+b9HF FR5+lmMMy6gjIe8OSoTYqeTfatcJteppTVCj907Dh5bDG8ArEAlNkztMo8njIsweGMeXmE mLLPWyVXN3iDRCaNq9JICqShcUhJ69RljHhuDM3Ap5MRwbIpYSi+BZSipc2MLLXD5EPjn2 1CwXMcCJb7ooIxNkas/nwj4sOJ6sU+Bvu/jzPwltB+sf/fwOveOfhhCZt73UnCLyO76R4j 9ChYQ0vsgy1k+hVY75f0KlOBShwR5ENTNjDyyxx2Hfwb+nBKSt6++5Qa6JINYg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bbSKh2HjQzw4r; Mon, 07 Jul 2025 15:08:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 567F88C4017040; Mon, 7 Jul 2025 15:08:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 567F88kZ017037; Mon, 7 Jul 2025 15:08:08 GMT (envelope-from git) Date: Mon, 7 Jul 2025 15:08:08 GMT Message-Id: <202507071508.567F88kZ017037@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 27626ff49ada - main - pfctl: Add parentheses for readability List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 27626ff49ada57f1978c893f21743e312dd40106 Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=27626ff49ada57f1978c893f21743e312dd40106 commit 27626ff49ada57f1978c893f21743e312dd40106 Author: Kristof Provost AuthorDate: 2025-07-03 08:51:43 +0000 Commit: Kristof Provost CommitDate: 2025-07-07 15:06:52 +0000 pfctl: Add parentheses for readability Prompted by and OK deraadt Obtained from: OpenBSD, kn , ff93619fa5 Sponsored by: Rubicon Communications, LLC ("Netgate") --- sbin/pfctl/pfctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sbin/pfctl/pfctl.c b/sbin/pfctl/pfctl.c index 8c20c8250ed1..738c89069383 100644 --- a/sbin/pfctl/pfctl.c +++ b/sbin/pfctl/pfctl.c @@ -3145,7 +3145,7 @@ main(int argc, char *argv[]) if ((opts & PF_OPT_NODNS) && (opts & PF_OPT_USEDNS)) errx(1, "-N and -r are mutually exclusive"); - if (tblcmdopt == NULL ^ tableopt == NULL) + if ((tblcmdopt == NULL) ^ (tableopt == NULL)) usage(); if (tblcmdopt != NULL) {