From nobody Mon Jul 07 15:07:59 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bbSKW5cQ7z61wB2; Mon, 07 Jul 2025 15:07:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bbSKW37mfz3wYS; Mon, 07 Jul 2025 15:07:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751900879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LuZDUmFocXmvScTnCq26kzQESGMJQDJT1zrHOxhC/E8=; b=xwlhgyM0ouMDbUVa2FvrQGQmh4muQ/aEYBQqXq90lkr7/7sinARgRuPd1CEkNajLRUKMRy +nOK/wzQY6bZ+3JBQkcV04Jd8WvrnzzheMflc+GKv+B94aERqITPTOR9eR0jIFKkYfBscf HsFQv7QhSdI1UN6D6b5Y3Q0299ftuIciDkEF9ebgNEhfR3l4f3jR27gc2otJ9RSlONzccZ 3atZZ2MRR+ieIuORHBd1XTCkInC2fgNMGrS+lLzX8aj+K+X6rVGs591nWvZbq3m4DGHve8 unS+T4V1fKgf7ov81FaNF9OaEC0HF9LLE6EByZq/bFGw8XNH96T3amv3uT+TiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751900879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LuZDUmFocXmvScTnCq26kzQESGMJQDJT1zrHOxhC/E8=; b=NYk5Ses3CF7plrLZlGABe0PfqH6oPcF8oKyVYLsxNdvnJqCa7nrL37Mt41A2Q0PEYoG/g0 dxxeKEdx77+IMRBKhpDJEt+6nG06HIVm5dtWy8riIFnqs+fO9lwp9OF1ZbuH+gImR3tnA4 YX40XB+TGYPQI9BSmgtoaCRPckuIi8L8IOjA6sKg0z4Hd6+BJX1u4ZB9FlJ0Elq65HiGx1 bDZa6J5YSW8PBa0Ipk0EKe33NWzJH9iVn9i6y6r2P7IAAONU+l9pM7jnJWvYyjKY5UqhyQ fmOqQhBkf3Qz4gGpOIvi9aljXmSg+bGIrfWRrG0ghDKApWPKwRkHonTp2zJ1rg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751900879; a=rsa-sha256; cv=none; b=W42Q3S4BPJKIqGbMXlA51/XyCCmdp+YWv9X5XMnLPfxpBMSQiWNjWx0Pf6AKbmpkLRtszq 3EIaUf128SUTzQG062HY5QqxNWiz931A8QLpvedwNXyrPVxL3G/w3G+eM9oHnzlRJhTffb xxPcvrl5t+4skAvRXrrHtr+cW9JD5o/cfmMtGHDHUaKyj2EXCcNdv5+vSoVemKgQ4iGDpd Ceufb9YWXmvP6CROURxTL6LTLaJmDW+OBF3Dosq7JC8pVORJvA5PtTv2v0mxeoTAqntVH5 0e/RoNu7il8+l7hqXM214uvwR1JDTC7EN69v7uG+rXfk6H/+esjKSAW3APsbFQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bbSKW2C0czwNx; Mon, 07 Jul 2025 15:07:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 567F7xrc016731; Mon, 7 Jul 2025 15:07:59 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 567F7xP6016728; Mon, 7 Jul 2025 15:07:59 GMT (envelope-from git) Date: Mon, 7 Jul 2025 15:07:59 GMT Message-Id: <202507071507.567F7xP6016728@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 6bbee85e48f6 - main - pfctl: Don't use unsigned for ptrdiff_t List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6bbee85e48f6829e23cbb85b3de385244c6f0df0 Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=6bbee85e48f6829e23cbb85b3de385244c6f0df0 commit 6bbee85e48f6829e23cbb85b3de385244c6f0df0 Author: Kristof Provost AuthorDate: 2025-07-02 13:02:33 +0000 Commit: Kristof Provost CommitDate: 2025-07-07 15:06:50 +0000 pfctl: Don't use unsigned for ptrdiff_t (unsigned) means (unsigned int) which on ptrdiff_t or size_t or other larger types really is a range reduction... Almost any cast to (unsigned) is a bug. ok millert tb benno Obtained from: OpenBSD, deraadt , 915c3f33d3 Sponsored by: Rubicon Communications, LLC ("Netgate") --- sbin/pfctl/parse.y | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sbin/pfctl/parse.y b/sbin/pfctl/parse.y index 5c6102db3b55..ca3ca28475d7 100644 --- a/sbin/pfctl/parse.y +++ b/sbin/pfctl/parse.y @@ -6929,7 +6929,7 @@ top: if (c == '-' || isdigit(c)) { do { *p++ = c; - if ((unsigned)(p-buf) >= sizeof(buf)) { + if ((size_t)(p-buf) >= sizeof(buf)) { yyerror("string too long"); return (findeol()); } @@ -6968,7 +6968,7 @@ nodigits: if (isalnum(c) || c == ':' || c == '_') { do { *p++ = c; - if ((unsigned)(p-buf) >= sizeof(buf)) { + if ((size_t)(p-buf) >= sizeof(buf)) { yyerror("string too long"); return (findeol()); }