From nobody Sun Jul 06 20:22:12 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bZzLk1nG1z61j8x; Sun, 06 Jul 2025 20:22:22 +0000 (UTC) (envelope-from ahmadkhalifa570@gmail.com) Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bZzLh0bn9z3Tpt; Sun, 06 Jul 2025 20:22:20 +0000 (UTC) (envelope-from ahmadkhalifa570@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=UphNWpqV; spf=pass (mx1.freebsd.org: domain of ahmadkhalifa570@gmail.com designates 2607:f8b0:4864:20::b33 as permitted sender) smtp.mailfrom=ahmadkhalifa570@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-yb1-xb33.google.com with SMTP id 3f1490d57ef6-e7569ccf04cso1981176276.0; Sun, 06 Jul 2025 13:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751833333; x=1752438133; darn=freebsd.org; h=cc:to:subject:message-id:date:in-reply-to:references:from :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Gf2bDG251XWdjGKZcJl1N0RketrANiCjo81dg/wuWG4=; b=UphNWpqVYW2ORPepzrxU+vHd5YcYtk0Ke4Epn9ul1+42xWiMFFcM+tyfK2Z5uXvCYY Vk07q00XCHCR7tAWySMWosgJ/vhG2HqhmffxgRyqpWObpVU5F3FPzil3g77h0wMKInGU 1aDBuVQB76K+tWY6CkocGJAocKIhWsYNP4BMpxTY2ao/O0jT5LJfAbfYStdWLgWNZVLs y8AuVT7atxEKfrffi0XednT5TUwTszZemTbajwqHpIHxO+XxtEBbHgJ7MHdlRF544Ob1 IW8AXN64dqpBK4UH/UIIUXqVvtlcezwkQfvVRcXNabKdHzzBq/SfeyRIy6a+vPA+cNJd avzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751833333; x=1752438133; h=cc:to:subject:message-id:date:in-reply-to:references:from :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Gf2bDG251XWdjGKZcJl1N0RketrANiCjo81dg/wuWG4=; b=Z/nJXkSOM9HuMzanzc5KYR5tPeT+ZAiFvyT1TumJcNp9+2A38rFsKLEJbsVOR6iDxs CgFQXqltRCA6ymLCu+wHPPNOKngytbARduqmoxN36Lfp+ALQCd+leQGylbjm5QTsluee i5zpvm5eC00D+GTkyCyIvnTsEgOyOj4dyIO7WG4WfgKy6GuXfJW70IRgj2PjbPGC24jB S+WjeFwEYis+mHmiDlFEh/Tw7ni8AqYWPZag2+KQZlX71X0U0NNIH1hW20e4brwGrOoK jSRRlvQ1TuragVVEGiCyVNE40ZHUVGMoUXgo4PGdlwdHxviQF9AYXP4/Kg2NJ5+mwNOa i/yw== X-Forwarded-Encrypted: i=1; AJvYcCUKZd0lWCKYy14LYAUqh9DRVrsN/iA/tqte6KT48c3A+2EWTsWiGhijVnddAmf4eTsVy8n6wxl+ZPbq26C5LaMnyojaJW8=@freebsd.org, AJvYcCXNb3zS8UJObDTQO/wOHH56Qg1X53uch4skjdFp841BgXzfEs5F+R+7Cc6dh2AE50Up3Rkotj5ZGg6uP0YqTDpetgAY@freebsd.org X-Gm-Message-State: AOJu0YzBC6+KdX5doZ6gDjUl7G0tYWkmq/w/9MEWoAZrPp7gOp+Tud5X cKBGPCXl1RZ6zQ/Wa3oLd8hdQRy0EZVkX9kN2XPQQo8bNp4YABRmqcbMkWkBu2OyRvBU+NniCyd 1ocZnboe2iTfic4oauHPEKPDZf+ipll/6LD0k X-Gm-Gg: ASbGnctjmK8dAwd/KcFQg4NhnMiPhm7kMdwo/GiZeyiDuQwa59plTiyC9w3iHHJ5LKa hTE4MY01Ac+1ZHGb1l3K9ft0sxByjZT5w7t/UzvQpd0jbSTIZCdmYRZswUc3yqU5p92setOux2o 6Ah839QjjzIpK5k2H5+nKpa5MqM+FxaEtTT3oeyxvfvTAk6A== X-Google-Smtp-Source: AGHT+IGR72B5FSNwptu8nIdzDRz8CnDrw9iuCOSlOekEKtQ6YYvs8fHo3e9HOVhc0kBBoZGRhRMO694eEGWTeO9aimM= X-Received: by 2002:a05:6902:1b0f:b0:e87:a679:6140 with SMTP id 3f1490d57ef6-e89a0cbe333mr11807696276.37.1751833333206; Sun, 06 Jul 2025 13:22:13 -0700 (PDT) Received: from 490177373942 named unknown by gmailapi.google.com with HTTPREST; Sun, 6 Jul 2025 13:22:12 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 From: Ahmad Khalifa X-Mailer: aerc 0.20.1 References: <202507061928.566JSLh9096963@gitrepo.freebsd.org> In-Reply-To: Date: Sun, 6 Jul 2025 13:22:12 -0700 X-Gm-Features: Ac12FXy5pJFtqm3Ew0IHalv_9S7OvVnuwhr8SaAhLWPejJN4AOQa_M8nVPy0nJA Message-ID: Subject: Re: git: 85dcdb7aad85 - main - amd64: allow the mapping of other regions for efirt To: Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Spamd-Result: default: False [-0.25 / 15.00]; NEURAL_SPAM_LONG(0.80)[0.799]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_MEDIUM(-0.45)[-0.448]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; NEURAL_HAM_SHORT(-0.11)[-0.105]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_TLS_LAST(0.00)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FREEMAIL_FROM(0.00)[gmail.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::b33:from]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MID_RHS_MATCH_FROMTLD(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-Rspamd-Queue-Id: 4bZzLh0bn9z3Tpt X-Spamd-Bar: / On Sun Jul 6, 2025 at 11:02 PM +0300, Ahmad Khalifa wrote: > On Sun Jul 6, 2025 at 10:43 PM +0300, Konstantin Belousov wrote: >> On Sun, Jul 06, 2025 at 07:28:21PM +0000, Ahmad Khalifa wrote: >>> The branch main has been updated by vexeduxr: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=85dcdb7aad85498b3f497b8752e69b8612b27cb7 >>> >>> commit 85dcdb7aad85498b3f497b8752e69b8612b27cb7 >>> Author: Ahmad Khalifa >>> AuthorDate: 2025-07-06 19:10:25 +0000 >>> Commit: Ahmad Khalifa >>> CommitDate: 2025-07-06 19:26:07 +0000 >>> >>> amd64: allow the mapping of other regions for efirt >>> >>> Some BIOSes access data outside of regions marked as "runtime" in their >>> runtime EFI functions. Allow the mapping and preservation of other >>> regions through a tunable. >>> >>> The tunable is a bitmap specifying the regions to map. e.g bit 3 would >>> be set to map BootServicesCode. >>> >>> Currently allowed regions are: >>> BootServicesCode >>> BootServicesData >>> RuntimeServicesCode >>> RuntimeServicesData >>> ACPIMemoryNVS >>> >>> PR: 287422 >>> Reviewed by: kib >>> Approved by: imp (mentor) >>> Differential Revision: https://reviews.freebsd.org/D51146 >>> --- >>> sys/amd64/amd64/efirt_machdep.c | 18 +++++++++++++++++- >>> sys/amd64/amd64/machdep.c | 8 ++++++-- >>> sys/amd64/include/efi.h | 4 ++++ >>> 3 files changed, 27 insertions(+), 3 deletions(-) >>> >>> diff --git a/sys/amd64/amd64/efirt_machdep.c b/sys/amd64/amd64/efirt_machdep.c >>> index 81a28ebe97ee..75c357f6e3df 100644 >>> --- a/sys/amd64/amd64/efirt_machdep.c >>> +++ b/sys/amd64/amd64/efirt_machdep.c >>> @@ -56,6 +56,15 @@ >>> #include >>> #include >>> >>> +/* The EFI regions we're allowed to map. */ >>> +#define EFI_ALLOWED_TYPES_MASK ( \ >>> + 1u << EFI_MD_TYPE_BS_CODE | 1u << EFI_MD_TYPE_BS_DATA | \ >>> + 1u << EFI_MD_TYPE_RT_CODE | 1u << EFI_MD_TYPE_RT_DATA | \ >>> + 1u << EFI_MD_TYPE_FIRMWARE \ >>> +) >>> + >>> +uint32_t efi_map_regs; >>> + >> >> Apparently efi_map_regs must be defined in amd64/machdep.c and not in >> efirt_machdep.c. If efirt is compiled as module, efo_map_regs gets >> undefined in the kernel. > > Ah, nice catch. Review opened. Hmm, apparently active_efi_ops has this issue too.