From nobody Tue Jul 01 07:02:57 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bWYrf1lddz60WZS; Tue, 01 Jul 2025 07:02:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bWYrd4B1Pz443n; Tue, 01 Jul 2025 07:02:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751353377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=V0mJ8IEcHRvVEwfg9Rvsuu2xy4/woo5+ZDq1Ah4wZQg=; b=iYvme0sDQo9XFxwml3ayHzeuv2qawdwQinlteK2K8F9cbae0oBp3/Wjy8rSyyZjfRNpog2 eh0mDUtkt+R3owiP4RUXARujGMBRfD7vic5T9zHkuDVRqTF8gL2IigkODd1uOqIfcYGEyw P/hFgi5WraeJh0ohZvRQcJpiLwqKq6wslFndccf3fmbpC/rIKOJ26JUPWEFSD0830NKm7T 4Cu4GaARFlcgHRdovCsXwJZimAkpNzUyTFhKRK4cQcHKDZ23NSygzLnQeU1njZYiFQSzVL 8fJ1eFy7tnt6nui+ob2T9iNyqw3tHlEx1H+lIgA3dEcZpihp391tnd6zjIg/xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751353377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=V0mJ8IEcHRvVEwfg9Rvsuu2xy4/woo5+ZDq1Ah4wZQg=; b=NzU2axnRw7ZkvP+uquvtV1MQudhBLDJIj57eAJx3kgzhe1wrU4owZRt/hqIATB1KNmOmur ON28ChhyYImUhq8XoofemzmgquJEbfHOjTfHggH0EwDIm8HuQghRLETU0vLsrzt1mLY0H6 VDspTSx1E/msFM5exSblZ6qBg4kExg7lQu3QDOOiVxoVeLnQCfMdSQ+gyPP0CqL1aaW7Gu /JiSoGMQTNxC9b5U3Z9OGzMVNdNuDNTY6zw2COQhDgvbXg56g0OiNl22XeZpwvr7KCk7LA porsj4UHeicSmW0Gbbi7r3xjaZJVmUe2NPUq2nzfynxQ8L0FYSSMHgHKTARIGw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751353377; a=rsa-sha256; cv=none; b=VcHUZhPFTFAMUbyUumbrOtaJcQLfmSWKkvfSwL3QLCsHTkD6BYP78Sa+t4RSLmYz4gh4/2 UsHeMb+FAk2BqXM6niKG8QVLdyyNj0XBibOm6RdOnrfz6LePMp0hIgSA3x3Ve1KxnEiZWz p8VQ2TfZ4WQye4cts+/hirMGCA/H6bHJZXrm3db/2RCoMv4Tlff8V4MaYDCjduX5ofc9Lh Kv+quMkj0ziLqPgPltipQztZTkSGUcq4jdteyihPwDyKMC0Dwpy4qht7mpjW4D46IMpj+G hgyJKziKiUG1TDVezRGqJBP18nErj29P0ut2vy9HGm2Lce098GAKXPUV+gzPDA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bWYrd3ktBz8Xp; Tue, 01 Jul 2025 07:02:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56172vaJ066865; Tue, 1 Jul 2025 07:02:57 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56172vSx066862; Tue, 1 Jul 2025 07:02:57 GMT (envelope-from git) Date: Tue, 1 Jul 2025 07:02:57 GMT Message-Id: <202507010702.56172vSx066862@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: e0f7e7324884 - main - tcp: remove an invalid KASSERT List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e0f7e732488476dc02ec771a5831715fbd7ca51a Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=e0f7e732488476dc02ec771a5831715fbd7ca51a commit e0f7e732488476dc02ec771a5831715fbd7ca51a Author: Michael Tuexen AuthorDate: 2025-07-01 07:00:24 +0000 Commit: Michael Tuexen CommitDate: 2025-07-01 07:00:24 +0000 tcp: remove an invalid KASSERT Since TCP endpoints in the TIME-WAIT state are no longer special, allow them to be switched over to the default stack. Reported by: syzbot+902d31bb0e68a1e8c088@syzkaller.appspotmail.com Reviewed by: cc MFC after: 1 week Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D51090 --- sys/netinet/tcp_subr.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sys/netinet/tcp_subr.c b/sys/netinet/tcp_subr.c index bbcd20b715ba..cd42a67294a6 100644 --- a/sys/netinet/tcp_subr.c +++ b/sys/netinet/tcp_subr.c @@ -1032,10 +1032,6 @@ tcp_default_fb_init(struct tcpcb *tp, void **ptr) /* We don't use the pointer */ *ptr = NULL; - KASSERT(tp->t_state < TCPS_TIME_WAIT, - ("%s: connection %p in unexpected state %d", __func__, tp, - tp->t_state)); - /* Make sure we get no interesting mbuf queuing behavior */ /* All mbuf queue/ack compress flags should be off */ tcp_lro_features_off(tp);