Re: git: 73281513fc85 - main - linuxkpi: Add `pci_wake_from_d3()`

On Fri, 31 Jan 2025, Jean-SébastienPédron wrote:

> The branch main has been updated by dumbbell:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=73281513fc8516c54ca30726498b282ca59a9fe8
>
> commit 73281513fc8516c54ca30726498b282ca59a9fe8
> Author:     Jean-Sébastien Pédron <dumbbell@FreeBSD.org>
> AuthorDate: 2025-01-01 15:43:44 +0000
> Commit:     Jean-Sébastien Pédron <dumbbell@FreeBSD.org>
> CommitDate: 2025-01-31 16:00:49 +0000
>
>    linuxkpi: Add `pci_wake_from_d3()`
>
>    [Why]
>    This is used by the amdgpu DRM driver starting with Linux 6.7.
>
>    [How]
>    The function just returns 0 for now.
>
>    Reviewed by:    manu
>    Sponsored by:   The FreeBSD Foundation
>    Differential Revision: https://reviews.freebsd.org/D48759
> ---
> sys/compat/linuxkpi/common/include/linux/pci.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/sys/compat/linuxkpi/common/include/linux/pci.h b/sys/compat/linuxkpi/common/include/linux/pci.h
> index 782f79080873..64f44812ee3e 100644
> --- a/sys/compat/linuxkpi/common/include/linux/pci.h
> +++ b/sys/compat/linuxkpi/common/include/linux/pci.h
> @@ -1500,4 +1500,11 @@ pci_irq_vector(struct pci_dev *pdev, unsigned int vector)
>         return (-ENXIO);
> }
>
> +static inline int
> +pci_wake_from_d3(struct pci_dev *pdev, bool enable)
> +{
> +

This smells like it wants a pr_debug so someone will see that it needs
implementation if needed in the future and not find it through debugging
by accident.

> +	return (0);
> +}
> +
> #endif	/* _LINUXKPI_LINUX_PCI_H_ */
>

-- 
Bjoern A. Zeeb                                                     r15:7