git: 36d7d2044b93 - main - mca_log: add missing breaks when handling thresholds
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 30 Jan 2025 03:42:39 UTC
The branch main has been updated by ngie:
URL: https://cgit.FreeBSD.org/src/commit/?id=36d7d2044b934103ad9254cd03ea61245c16ccda
commit 36d7d2044b934103ad9254cd03ea61245c16ccda
Author: Enji Cooper <ngie@FreeBSD.org>
AuthorDate: 2025-01-29 21:24:53 +0000
Commit: Enji Cooper <ngie@FreeBSD.org>
CommitDate: 2025-01-30 03:42:18 +0000
mca_log: add missing breaks when handling thresholds
Per the "Intel® 64 and IA-32 Architectures Software Developer’s Manual
Combined Volumes: Vol. 3B 17-7", the Green and Yellow threshold
indicators are mutually exclusive. Add the missing `break` statements so
they're treated that way.
MFC after: 1 week
Reported by: Coverity
Differential Revision: https://reviews.freebsd.org/D48722
---
sys/x86/x86/mca.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sys/x86/x86/mca.c b/sys/x86/x86/mca.c
index b293fcedbd84..4ba49469d3a2 100644
--- a/sys/x86/x86/mca.c
+++ b/sys/x86/x86/mca.c
@@ -453,8 +453,10 @@ mca_log(const struct mca_record *rec)
switch ((rec->mr_status & MC_STATUS_TES_STATUS) >> 53) {
case 0x1:
printf("(Green) ");
+ break;
case 0x2:
printf("(Yellow) ");
+ break;
}
}
}