From nobody Wed Jan 29 03:06:20 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YjRrX0rJBz5lfN8 for ; Wed, 29 Jan 2025 03:06:36 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YjRrW3Df5z3xVq for ; Wed, 29 Jan 2025 03:06:35 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43675b1155bso72285365e9.2 for ; Tue, 28 Jan 2025 19:06:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738119993; x=1738724793; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3RzDc33GWzrpaqnyXzh09kUNggm+6qi0++3/oUOZrco=; b=cFE4qJORkG87b+JfXpL1oh+BJ4dGZMPeEjkJsTJGppUnfasYYACifwaa+eSEq8bMzp +sd8r8qZQ1Zi9Mx+7cvBmJ54OeIun30IfFvfPcWua27Do2gZn0CuC3BVcSHubGZo3LCK vXXWQ0lc8mBNFDFUHV00X10PAhuzBYi9QRC8ZEutOfCDl3DkUAc/+K7mwNiBW34EDJHd 1U7qFjf0uIHdu58GyrftwQSNp0+frUi/aX41vyStTwKJks6KlwY1NYeZACsHMNyn03Jb /veG8loX9eR2QiIEAjxTGSWbBdhjEhE8SiY8YjVLEUbELFaoJZX/AdF5Y1sz78pg7YRg zZnw== X-Forwarded-Encrypted: i=1; AJvYcCXJci0x2zpHWFMQx2WxYHUb2haA8h8w/PB6OsHCwCCu39CCps7ESmn22tbSvBGcaR22lJhCAlSxdHkydCLJe7QUwRUeCQ==@freebsd.org X-Gm-Message-State: AOJu0YzOhx+xeFgeXsM3IM1zRKHRKHZKmMUw4PiGM+eNd/4AEv0sZucD MoAIjKgQ4lvaJtrdhpowESjGNf3Qe7yOSB0xwEjEpOwkDkMDjPm3VJLJ16yhmzmovi73aj19bmI 3 X-Gm-Gg: ASbGnct5hnTNxyuZh0gN7LeWh2XfWc+nJuZ9Uyt77zvn02jbZBtNi94JdRvJDZaYua5 4mwPkomUM7pjusG9msxG5lqrxc+WI/+MmB6sHS2M8/w013f3SsY+4/uqn94e62rIKiJG1ANb2Yd g3H3Mnyn2MrumOwkcVQOIH6MeR6BKnetSIUcmbVBq01EH+xNIRw3v3a0w+V06nuGrK0QafLhaka qzOgdfWZvwDegLwLpAwRBhRRNr37kyMnRjb53bULR24pigkLDsoWP48WQvHsNbA432VAHyzV8AY EayGIOKa+HuliirrVXZLKWyIhPSAHw== X-Google-Smtp-Source: AGHT+IHMdtAQ4SAUBWsJCjsFYXcIt1eWB2rq3HsipJQTtZxs6gec20JAeUeuqpVhnifkK38qBn4QnQ== X-Received: by 2002:a5d:54c2:0:b0:38a:88e2:e6aa with SMTP id ffacd0b85a97d-38c51960019mr831401f8f.29.1738119992752; Tue, 28 Jan 2025 19:06:32 -0800 (PST) Received: from smtpclient.apple ([131.111.5.201]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a17633dsm15893582f8f.15.2025.01.28.19.06.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Jan 2025 19:06:31 -0800 (PST) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.300.87.4.3\)) Subject: Re: git: 70c067062217 - main - dtrace/arm64: Simplify dtrace_getarg() slightly From: Jessica Clarke In-Reply-To: <202501290221.50T2LXRS006289@gitrepo.freebsd.org> Date: Wed, 29 Jan 2025 03:06:20 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <8086E5AF-1350-47D8-9010-6DFFFF7FA8D3@freebsd.org> References: <202501290221.50T2LXRS006289@gitrepo.freebsd.org> To: Mark Johnston X-Mailer: Apple Mail (2.3826.300.87.4.3) X-Rspamd-Queue-Id: 4YjRrW3Df5z3xVq X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] On 29 Jan 2025, at 02:21, Mark Johnston wrote: >=20 > The branch main has been updated by markj: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D70c067062217a5295ed321427b91cfd8= 57c18b77 >=20 > commit 70c067062217a5295ed321427b91cfd857c18b77 > Author: Mark Johnston > AuthorDate: 2025-01-29 01:05:03 +0000 > Commit: Mark Johnston > CommitDate: 2025-01-29 01:05:03 +0000 >=20 > dtrace/arm64: Simplify dtrace_getarg() slightly >=20 > The use of memcpy here is redundant, and also incorrect since = memcpy() > might be instrumented by fbt or kinst. dtrace_bcopy() exists, but = we > don't need it. >=20 > MFC after: 2 weeks > Sponsored by: Innovate UK > --- > sys/cddl/dev/dtrace/aarch64/dtrace_isa.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/sys/cddl/dev/dtrace/aarch64/dtrace_isa.c = b/sys/cddl/dev/dtrace/aarch64/dtrace_isa.c > index ff0e068006bd..3e36004c6f0d 100644 > --- a/sys/cddl/dev/dtrace/aarch64/dtrace_isa.c > +++ b/sys/cddl/dev/dtrace/aarch64/dtrace_isa.c > @@ -256,7 +256,6 @@ dtrace_getarg(int arg, int aframes __unused) > return (tf->tf_x[arg]); > } else { > uintptr_t p; > - uint64_t val; >=20 > p =3D (tf->tf_sp + (arg - 8) * sizeof(uint64_t)); > if ((p & 7) !=3D 0) { > @@ -269,8 +268,7 @@ dtrace_getarg(int arg, int aframes __unused) > cpu_core[curcpu].cpuc_dtrace_illval =3D p; > return (0); > } > - memcpy(&val, (void *)p, sizeof(uint64_t)); > - return (val); > + return (p); Doesn=E2=80=99t this change from dereferencing p to returning it? Surely = p should be a uint64_t * that is dereferenced? Jess