From nobody Wed Jan 29 02:21:33 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YjQrZ01dYz5lZyC; Wed, 29 Jan 2025 02:21:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YjQrY5Wnfz3rRV; Wed, 29 Jan 2025 02:21:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738117293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dnitiPxHvSuXh4N87q1vnsMaub4HD4TJ7uQwkLlXSPI=; b=N6zWS8yG5EfJfbJr2hKbceg2dk3xSHtze5MXMXsFA/m76ElwRdOQ1463Z99c5vg0aEI3tM y4C80NF4UKwT6F1Imd4UP8AgdNIsL5sbxtboICp/jInx1iJhp+t4n4GR2MUWl0hUB1L90E OKITVsHA/rPzOnqfFQhuyqYMRxLtONyCe3dL9jpzWod0WFqzILlhYCjUW2rZXhPrv+HL0j EB2TE72tBUFDXoCk+d+GrH92Po0B/qGYZy5hJapTmDuaZ80+jzR5OYAWr4aaV6PppmGZZx Y3OUDtUiKFpx8/UjvN6i0X372k5SZ2z1qGs0s4QOs5vXfpQ3RwZsNbjvfNqaCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738117293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dnitiPxHvSuXh4N87q1vnsMaub4HD4TJ7uQwkLlXSPI=; b=s4JIb/kFbN+HWEAW2mbyAB0xNJEMlPiN0punrs7itA7aywJPyjHXm5y/1VgtWfQINTnyCh JADHdu/G3RmZo18SwR9ZU3COokrmA3UIgFCtOOONTB76YJDyAIq2JNd1gV3mvVvUmNxKv7 AE8BiOE2RtHwRHGefYXyEDycuzW9zmOlHW0hQBxCKY6DmV6kHcyDFemWJHNzMWloFq2zbL uhjKNYzbCtOS0fTymgyOx3at90ri6LYzuVkqqWhV9Uyt7FIEVIz+HwXXOlFLhzlD079DlB eAUt8fpNqdoggz3D7xHy+eADEc1rQ9B0MKkh+svw1k2QWr05psYW2/oHCKM/qQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738117293; a=rsa-sha256; cv=none; b=oSEjh+8+mW6n/uW3qxTkDLRGn4vOnOtQCY4z5cAUniwnGLeDX39SmajnROMeWFqXllIFIE Pe7Ytn+TV/wgAO1Vh1/QUWf7JncLAHS/4VQh6U/+ThfbHtuOuLEFt2Dil+OBPQQAkYRhuz 9z+/tS/LeHjnsFy+xj4Dho/POd5CFKfaWxAyFs2yWGKFmdA0pyPJKE1brVUC93hV0MgzwC 9b8efEvipgFMdBLw6/zpu5C9A6W1BTo/sN2SS14NfRX6M58qDHs1Igxn798c/Vl//60dvW 1wKmYws/Mxlx9vBwBNX1dhiSm7J8JCpmYGL5SSPbvPYQAZnsQpwHwDXwBT0bSw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YjQrY4s3dzj9D; Wed, 29 Jan 2025 02:21:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50T2LXUB006292; Wed, 29 Jan 2025 02:21:33 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50T2LXRS006289; Wed, 29 Jan 2025 02:21:33 GMT (envelope-from git) Date: Wed, 29 Jan 2025 02:21:33 GMT Message-Id: <202501290221.50T2LXRS006289@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 70c067062217 - main - dtrace/arm64: Simplify dtrace_getarg() slightly List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 70c067062217a5295ed321427b91cfd857c18b77 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=70c067062217a5295ed321427b91cfd857c18b77 commit 70c067062217a5295ed321427b91cfd857c18b77 Author: Mark Johnston AuthorDate: 2025-01-29 01:05:03 +0000 Commit: Mark Johnston CommitDate: 2025-01-29 01:05:03 +0000 dtrace/arm64: Simplify dtrace_getarg() slightly The use of memcpy here is redundant, and also incorrect since memcpy() might be instrumented by fbt or kinst. dtrace_bcopy() exists, but we don't need it. MFC after: 2 weeks Sponsored by: Innovate UK --- sys/cddl/dev/dtrace/aarch64/dtrace_isa.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sys/cddl/dev/dtrace/aarch64/dtrace_isa.c b/sys/cddl/dev/dtrace/aarch64/dtrace_isa.c index ff0e068006bd..3e36004c6f0d 100644 --- a/sys/cddl/dev/dtrace/aarch64/dtrace_isa.c +++ b/sys/cddl/dev/dtrace/aarch64/dtrace_isa.c @@ -256,7 +256,6 @@ dtrace_getarg(int arg, int aframes __unused) return (tf->tf_x[arg]); } else { uintptr_t p; - uint64_t val; p = (tf->tf_sp + (arg - 8) * sizeof(uint64_t)); if ((p & 7) != 0) { @@ -269,8 +268,7 @@ dtrace_getarg(int arg, int aframes __unused) cpu_core[curcpu].cpuc_dtrace_illval = p; return (0); } - memcpy(&val, (void *)p, sizeof(uint64_t)); - return (val); + return (p); } }