From nobody Fri Feb 28 08:54:08 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z427y3czlz59Lwh for ; Fri, 28 Feb 2025 08:54:22 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z427y0WKCz3RBs for ; Fri, 28 Feb 2025 08:54:22 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qt1-x836.google.com with SMTP id d75a77b69052e-472039adb9bso23348351cf.0 for ; Fri, 28 Feb 2025 00:54:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kev009.com; s=google; t=1740732861; x=1741337661; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=H8fKMpzSYGiWY2xWlAr/vgsLROlvzPfThcGGrc9JAmw=; b=pF09AXntMZk8H/Ey2RzIP4bCteX5yAUS/KA7TIxv0bx0F8cg9D9dKvU427bIrbP6xQ X2k+jaH2rXecZaOowlfR6thJMUzsju8P9RKYvZvLPIgjSRFhtuMvBYO7MplcpXu8X0VR sebIUhFnrHekZyuFYfffZobjCyUqkMufX5Yxk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740732861; x=1741337661; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H8fKMpzSYGiWY2xWlAr/vgsLROlvzPfThcGGrc9JAmw=; b=QuGQCToVLDU4yOI1V/6kwPKM0ctu/3Jz0VIvdB4oVIWs3tequGOon3sq1giv3QYrkg PdqG64aSVGZpECh1dKqpp4dyz1CZ7lzvPJ5R8ogXO+GGKeCcXYos4hi6FqYgaJdcYA8P iZm2haR0I/NWfPfuRyir2bu9AGBrI77/o/kpiGyhYl81/yzJFh/Rv0sw16EiGOpHHY9S 4/gRalCiyIZ+HXS+tBMJbvfR63TFw4LNYA/l5+4kz7zS+1fIYQuDKtWdarNw+x6OaUcZ axGKu1Y3bZQM3D3Xipv9FNmtnW25L8iNQvgUJ8VlKliZTdDjX+l57I+CJS7eOdbIP7MC pD4w== X-Forwarded-Encrypted: i=1; AJvYcCXW8/fE41ZPzMkxCKyHqeoJiErV7rR4n2GrhM9U+6PcJ5zAQ8n1CD0bDQFZn40ei4TQKqYv8GZeNh6HSBoE0c0GJ/c4qg==@freebsd.org X-Gm-Message-State: AOJu0YwTLi55DgIfS81NNaQTNMHDbkJ8UwO4B9guZaIiiRfRcJTFN7mw jzMt1SBGndP9gqHVyp8YoHZc2vg4ucJVLjf0YabUZhbYldoQaKAWmlmvp9LDDQOkWZ5YxM3FPyK 632bkLwcFIaVXNLtCOKAXWEMJhuYLeaJkC834 X-Gm-Gg: ASbGncvSNgIfxnxGH+eXvOsqBLYSJbrtfzyfqOONRk+P9ZC1B/Z8jjUv9eMwkVb4daV 5iay+JDTUX3114Ume8h/vk02/4VbQiWoYTLGmapG+COVFxbA9mgylOiPCeDOxq6xYJrZO4kfEEG o4HdyP8KRG X-Google-Smtp-Source: AGHT+IG4OE6XK2iDR8tOQiVd1//Lhn3WoNvRL+rjwI2+UnwToixP2fZII2MUvfU5T0vOUGC/ltc6eB8Bs1Hhs3wFwNw= X-Received: by 2002:ac8:5a82:0:b0:471:cfa9:2612 with SMTP id d75a77b69052e-474bc0fdc44mr30736231cf.32.1740732861238; Fri, 28 Feb 2025 00:54:21 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202502280813.51S8DQiZ037985@gitrepo.freebsd.org> In-Reply-To: <202502280813.51S8DQiZ037985@gitrepo.freebsd.org> From: Kevin Bowling Date: Fri, 28 Feb 2025 01:54:08 -0700 X-Gm-Features: AQ5f1Jr76GqwPhHbItb0i6IYOYc-q37SUz7CcgcHltpPd6rl1HkIS2Bj2PJ-ulc Message-ID: Subject: Re: git: 5c7087c349fc - main - ixgbe: Fix a logic error in ixgbe_read_mailbox_vf() Reviewed by: kbowling Differential Revision: https://reviews.freebsd.org/D49156 To: Kevin Lo Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4Z427y0WKCz3RBs X-Spamd-Bar: ---- MFC? On Fri, Feb 28, 2025 at 1:13=E2=80=AFAM Kevin Lo wrote: > > The branch main has been updated by kevlo: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D5c7087c349fc1d826807aa1a11= 912c9e774e3321 > > commit 5c7087c349fc1d826807aa1a11912c9e774e3321 > Author: Kevin Lo > AuthorDate: 2025-02-28 08:12:00 +0000 > Commit: Kevin Lo > CommitDate: 2025-02-28 08:12:00 +0000 > > ixgbe: Fix a logic error in ixgbe_read_mailbox_vf() > Reviewed by: kbowling > Differential Revision: https://reviews.freebsd.org/D49156 > --- > sys/dev/ixgbe/ixgbe_mbx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sys/dev/ixgbe/ixgbe_mbx.c b/sys/dev/ixgbe/ixgbe_mbx.c > index 5f1f64e02b82..0b866e7a39af 100644 > --- a/sys/dev/ixgbe/ixgbe_mbx.c > +++ b/sys/dev/ixgbe/ixgbe_mbx.c > @@ -297,7 +297,7 @@ static u32 ixgbe_read_mailbox_vf(struct ixgbe_hw *hw) > u32 vf_mailbox =3D IXGBE_READ_REG(hw, IXGBE_VFMAILBOX); > > vf_mailbox |=3D hw->mbx.vf_mailbox; > - hw->mbx.vf_mailbox |=3D vf_mailbox % IXGBE_VFMAILBOX_R2C_BITS; > + hw->mbx.vf_mailbox |=3D vf_mailbox & IXGBE_VFMAILBOX_R2C_BITS; > > return vf_mailbox; > }