From nobody Wed Feb 26 16:35:21 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z30Sq2znWz52dtv; Wed, 26 Feb 2025 16:35:23 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z30Sq2SLcz438m; Wed, 26 Feb 2025 16:35:23 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740587723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vYzoCfbr21bbJJfnCILrH4U5UGGDWGltDGaUEAtTA3g=; b=OIt6Es94cvD+sAaOLqBhpsLiQXavIOhlMr4mZ+FURow7wsV+jKWb3xYUfVnKh8hU6kEI/O 8WXVAAdiXsxK3MVsZs6PTBU5jseeysoPx+8j6cerj+6uf6GWSgPkyDXu36T7mEcraZugeb sW6hOns0ob+NzTaiPyUNyyGOnZcpAJJQa72xz+pFYcf5kfZfRWGhRTDw0zpsp5jZsOz6qV yXCujUD0MI9+0xjULL9GcXDAWYXqmIL1T5NL7kW60PD1u7BowSayhVH8WAeoPCRJllZobU nzTTmE0QO7bsFJhNM8UxF4Iamzz0GX/GVxykn3N/s8uStMYuYfM7svWWP57ISA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1740587723; a=rsa-sha256; cv=none; b=QCRpULLVQSn+18MVWOBrODe9Nt3vx8o4nda3FfEDwBdiXVyW7lMhU8jyRBb7l+zy5T8cns /W8ODSzcZZQLkkp6An8Zy6iQuBCSQtfgAKHH3tFEO+RzvIfdKttvok4qzRUQG56lklVoqO q4WtqnmiV/FihMJ9wKDnlNWXJYFArgJos02K87XyNRma7S743FP+zpjWDthkgBrM7lb/0E OZp3uSkNq5i6mzFh96rPrwz/d+zMvIBrvn7djXSrfN4L0WVwJX8RwGywoOXLyIGmT+cW4u SkEBKSuC7hR5dMX7b++8LhvuNSZf5lb04n3nr/c/xl+/4kMWBfz3na3ZzVVr6A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740587723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vYzoCfbr21bbJJfnCILrH4U5UGGDWGltDGaUEAtTA3g=; b=Q6xD2BndNuMshMJ437M4/O5i13WMzg3Vrb22yipiB92qGne11wychak0rxOw58tKeMTl5X DgtHU6rGrwvrGgU4/OpIgd/amT2pqn7+gVOiTCg9ol1qjXVMTu2qmhk2Ie787e6rvRrmFs 9cCvBgs7ofBx4UoEgE/3LyIeV5H0axpW6vzqBNIyPhkv8mgd7KdU6E+fWlCRuZhY60Zvcd YTERG8lNMvM4QCkDbAClM/zRb+xBYdGTEco8fe06Ajm+tNJNHwwFEzvxHxDG1InYpeDU// mbYiDi0qliUjK9qqxfVOflQ8typW+A6V6EDmJG28nP2aBH/q4uPW9W5UYRD+Gw== Received: from [IPV6:2601:5c0:4200:b830:a15f:d124:4862:d27d] (unknown [IPv6:2601:5c0:4200:b830:a15f:d124:4862:d27d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Z30Sq00KRzxV0; Wed, 26 Feb 2025 16:35:22 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Wed, 26 Feb 2025 11:35:21 -0500 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 0e58542fd246 - main - tcp: remove unused field from struct tcpcb Content-Language: en-US To: "Bjoern A. Zeeb" , Michael Tuexen Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202502252048.51PKm4YX061305@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/25/25 21:23, Bjoern A. Zeeb wrote: > On Tue, 25 Feb 2025, Michael Tuexen wrote: > >> The branch main has been updated by tuexen: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=0e58542fd246242bc64bd03d8b2f28cf981c062b >> >> commit 0e58542fd246242bc64bd03d8b2f28cf981c062b >> Author: Peter Lei >> AuthorDate: 2025-02-25 20:37:48 +0000 >> Commit: Michael Tuexen >> CommitDate: 2025-02-25 20:37:48 +0000 >> >> tcp: remove unused field from struct tcpcb >> >> Reviewed by: tuexen >> Sponsored by: Netflix, Inc. >> --- >> sys/netinet/tcp_var.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/sys/netinet/tcp_var.h b/sys/netinet/tcp_var.h >> index e65e44840bd8..31663ed48f81 100644 >> --- a/sys/netinet/tcp_var.h >> +++ b/sys/netinet/tcp_var.h >> @@ -452,7 +452,6 @@ struct tcpcb { >> tcp_seq gput_seq; /* Outbound measurement seq */ >> tcp_seq gput_ack; /* Inbound measurement ack */ >> int32_t t_stats_gput_prev; /* XXXLAS: Prev gput measurement */ >> - uint32_t t_maxpeakrate; /* max peak rate set by user, bytes/s */ > > Is the tcpcb no longer KBI relevant these days? > In the old days we'd simply make this a spare and not move all offsets > below around. Only in stable branches would we do that sort of thing though. In main we keep all the spares at the end and never use them (they are reserved so they can be used for MFC of new fields in stable). -- John Baldwin