From nobody Tue Feb 25 11:48:23 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z2G8823Gbz5pjr9; Tue, 25 Feb 2025 11:48:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z2G8763n0z3kPY; Tue, 25 Feb 2025 11:48:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740484103; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=b/7+6OF8Y20GGsenMe+eFvbWbhgt5gSzNQ/gOdRa1nE=; b=EG4v+8KivFMMqpXNYzo9P4JMjReXVuOjbar6hRxDsSKE5zFs6uOCxrq6/p86xYHlOXEryC jF9A2gmR3pOpJVY06b8dbZJGbHF7POaRi7ZGbVMLc1h13OJnQPkTAeue+EqLCQiwtxJrAG M9s9YsIlm12HBq2AF5SliYM3CHENc8ylanWQc3uvZmalbVrtapOmIOQC2z+PB7T3zQejFv qSA7axyyyq4aO8MewUk9sSeghEwN2HzroDRQPPmtOjfaOn+cJy5dOaactVXV2jbPR5CtBW e3Yz4pygA0DqWWnxrpX9cdrwReeYONy1lPqOtsaZ+HaFUE3ux6PBbrP/qfGoYA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1740484103; a=rsa-sha256; cv=none; b=TLQYCHWpw9dFgYnz7whDVxBKIAkh2GgZHk3XDFFm3BQZcllglP+qeFSWr3FdEpNJddPOIR Ur6gWeh30e+Tmi0oxcgGDH8ZI4yQ2M/ZvoDZK3GGPWax+bbeU5N9Kn+NEBjPRCTKiAMfcY DgxEVj9uhCZFl9y2lWJG8XxGMxY25Kv821sMk/pTcZ9rkJ0DjO63s50xHMdr22/6j5xhaO Scx9Ha9ZQum4YSIycLW0ojEU+hoJQGY9As/fOB3lj2t6t4ZhAIGuKH1NipImbKw4TxFLbV aVP0DrFY1runRCeNlotbU3QuqlP3NvBfIsWSX+Mc2YuBuL63SGO7dECw+poadA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740484103; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=b/7+6OF8Y20GGsenMe+eFvbWbhgt5gSzNQ/gOdRa1nE=; b=ngoo7Y+zBa/PawOeKU/H30tJ6G7ny+VLzHenP/maxa9WJCnBu5YYxHkeQLXS/1mvquNGIJ cpUq18PLTVWbK6k25jikFbo2aFll6ph+BiymxcKjWJNcBxr/ziOB/VgWCklIT2dMJJ6dBJ ex372dlQdGls7sOg5rtby8SXXzTxyNIL63jwLDw6NB9A09FWO5SHr35ZbYebZwChK0T8Rk WwZH8gCaKUqj9//Jy/rNC0T+2pTTbe28zLZ3fzt1kseug4+rP6yOAPgIfyaSBPoAbauIh5 fGJ8Ki75Ah15eP2fGrUd3t+7vzlWqgy/YnZBjpZRKvnMjt5GxW3g/tOZAFWDAA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Z2G875Z1xz94M; Tue, 25 Feb 2025 11:48:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 51PBmNou051170; Tue, 25 Feb 2025 11:48:23 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 51PBmNnu051167; Tue, 25 Feb 2025 11:48:23 GMT (envelope-from git) Date: Tue, 25 Feb 2025 11:48:23 GMT Message-Id: <202502251148.51PBmNnu051167@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 2868776c9c6f - main - sound: Update comment and channel insertion in vchan_create() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2868776c9c6f5313a5676786f642b766f103d780 Auto-Submitted: auto-generated The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=2868776c9c6f5313a5676786f642b766f103d780 commit 2868776c9c6f5313a5676786f642b766f103d780 Author: Christos Margiolis AuthorDate: 2025-02-25 11:44:30 +0000 Commit: Christos Margiolis CommitDate: 2025-02-25 11:44:30 +0000 sound: Update comment and channel insertion in vchan_create() The comment and rationale behind choosing CHN_INSERT_SORT_DESCEND() instead of CHN_INSERT_SORT_ASCEND() are no longer relevant as of FILLME ("sound: Allocate vchans on-demand"). Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D48962 --- sys/dev/sound/pcm/vchan.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/sys/dev/sound/pcm/vchan.c b/sys/dev/sound/pcm/vchan.c index 45f0a8b00bd2..27739fe68852 100644 --- a/sys/dev/sound/pcm/vchan.c +++ b/sys/dev/sound/pcm/vchan.c @@ -644,12 +644,7 @@ vchan_create(struct pcm_channel *parent, struct pcm_channel **child) PCM_UNLOCK(d); CHN_LOCK(parent); - /* - * Add us to our parent channel's children in reverse order - * so future destruction will pick the last (biggest number) - * channel. - */ - CHN_INSERT_SORT_DESCEND(parent, ch, children); + CHN_INSERT_SORT_ASCEND(parent, ch, children); *child = ch;