From nobody Tue Feb 18 17:12:02 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Yy5fp3rxhz5ntCl; Tue, 18 Feb 2025 17:12:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Yy5fp297hz3Crj; Tue, 18 Feb 2025 17:12:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739898722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5Nh6w14V13dU0Yh3Mff5BibdDS/yJ4ffCrop/aO8d+8=; b=DmqXUxVO9/MrL+bFdU7HJl4oCMzkwcAxC8x8dDWD4Qw1OkOGDbAsTB/acmZThksypV7kqv 3C49MZOEHTJ6EIJTD17MulT6Dtx4eK0ImyJgPzOxyYji1e2HjZjQll+fWzIxKbvEM3yAqa L++gDjaPoy/h6+d3RvIkvUE5cPjxV+r59UVAle1la2Tue6QoL1EGfM9LjxtbviR5mnCxeJ birOyPVDeVAzfhC0SMS4/DzanUamreyjkc0u1R5nw0NMncKUanjf5k/CkEpiTf2mzDlcmS 5WzDaHZA+NQjqCjYMcQETHzZtKc7A8SzK1VJKD4DJc1b6BKEyMUvml/ldCgcbw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1739898722; a=rsa-sha256; cv=none; b=JTb4bNofG8zICRlgeNZUcmuzc+Q5bcqxp/+oBrTbnw0gd9IfQboLQkgJ9e7LpRAkMbb+Zp mwdIGMS3thLwsp8/2AWWtCJnY7tJ4L+qjwLFe9+2HZmbSrnVYR2LWH9qc+/BhQ7UENEd7x jaahEhVjyeDBqlDx2g+SK/ezDcYvOjBV7cexvYVgxmNSAtrzoDk199AQA1sGSLsDRZe3a4 stnG7q4UjTiO75lVAb0LMh6LKs8bofTt7HVMFKVjNqEev/bBhMbQgTe9pAT7QphjEqhdjR I0N9EM/9yQIRqlmdKv2dxnVQyVtkEghX1Nbibfq7ha57OhUr4qhXQMVtWyBsSg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739898722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5Nh6w14V13dU0Yh3Mff5BibdDS/yJ4ffCrop/aO8d+8=; b=ZLshDDQv2hB7/INfUGdikrgbcK5fm6EyoIGdhGM5lK8t5Q2IhH3PLxdAhY1twfZEadbh0/ l/EilyzIPo/5DSVssEv5QGbGgM8Drx9nTAFOULk4nLWF4bfbAHH5+GTzkgsA5dUrYeutsf f/fAWxrnf+gAThT0/jRjDhvhnYX07I5I2+03gJIGRPXHrAPZ05bbZ9ngA1/4QI5RKn2ATj nX0OzWMlQuHWpjSgxlsYurGKzN5jtYr8IIgdEN6TO/s/83yVMKmZAkNX5vmd5bi5wOr6N8 SvvlbHPCHJlo3LVsApizYHdfGhkiQk01J9CawUZsGF4OVw7FuwKq+R6g+8OJMQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Yy5fp1n5NzCd2; Tue, 18 Feb 2025 17:12:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 51IHC2hq064672; Tue, 18 Feb 2025 17:12:02 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 51IHC2Jk064669; Tue, 18 Feb 2025 17:12:02 GMT (envelope-from git) Date: Tue, 18 Feb 2025 17:12:02 GMT Message-Id: <202502181712.51IHC2Jk064669@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Cy Schubert Subject: git: 381956e26756 - main - ntp: ntpd does not connect to NTP server with link local IPv6 address List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 381956e267569031883a516e10446c29490ee41d Auto-Submitted: auto-generated The branch main has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=381956e267569031883a516e10446c29490ee41d commit 381956e267569031883a516e10446c29490ee41d Author: Cy Schubert AuthorDate: 2025-01-31 22:25:14 +0000 Commit: Cy Schubert CommitDate: 2025-02-18 17:11:45 +0000 ntp: ntpd does not connect to NTP server with link local IPv6 address Upstream bug 3943 (https://bugs.ntp.org/show_bug.cgi?id=3943) discusses: Starting with 4.2.8p18 ntp does not synchronize or even connect to the configured NTP server any more. ntp stays in .INIT. state indefinitely and checking the network traffic shows that ntp does not attempt to contact the NTP server. This is regression introduced by the fix for upstream bug 3913. This is a similar bug I reported upstream (ntp bug 3841). MFC after: 1 month --- contrib/ntp/ntpd/ntp_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/ntp/ntpd/ntp_io.c b/contrib/ntp/ntpd/ntp_io.c index 9d79fe493d9b..0df543c5af04 100644 --- a/contrib/ntp/ntpd/ntp_io.c +++ b/contrib/ntp/ntpd/ntp_io.c @@ -3205,7 +3205,7 @@ sendpkt( } do { - if (INT_LL_OF_GLOB & src->flags) { + if (ismcast && INT_LL_OF_GLOB & src->flags) { /* avoid duplicate multicasts on same IPv6 net */ goto loop; }