From nobody Mon Feb 17 17:08:18 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YxTd24Z3Cz5ntVb; Mon, 17 Feb 2025 17:08:22 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YxTd242Mwz3Kht; Mon, 17 Feb 2025 17:08:22 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739812102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zcVVUQI3kJKz3pWxsP7RCtUtuZHTB08Z1jNFE0/SD1k=; b=CiwqcMW25XbHZuLzK4uv5mm4Aq+bLZ+jN9hCg/tTmyHYuf5ubZC05F7AQkYCgkXlWAV0TN 4jCN7l1wfztSL1w3cuM04m88yLI3iwmZsd7fd9h+jSrbps3p2zdFbkZLe/aPpzWApMSzMb Ck+V1MBhYRXLqa/rBkZ72romM63WNZwq5NnFLbNi6KLbz3O1XWs6w0a3pz3nRWGDWc4J8l AKuITivcrya4vD8SmfoQkZ/YSnb2tHOd8e/LMVrOtVTEXWJR7dXRcINVIt27N+M2CQ1RYV MZGyTD7Iq40V1SeaM+evwIcODlddIhhBcG1k3/OozdgZy3ibe7EkRLtuJJ0D2Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1739812102; a=rsa-sha256; cv=none; b=cE4Jpwn4GHobWjo3IlbdDAFT4esrhhCa6rExwxxtNUEg+dyNVhdqfBx1S3en0JxWd2o/Ho hpXrTyzZkMw46VNkQGw2FJqpYF+EGxadQWI/vzb9dhP2k14RPGaH/K0qGCPs41lodCVwv3 x4vQ3cBBJpwMWl11o3vCvtqXKuThKe5WNiCZrsreVidmG6CDqkkFisvrkqfwIhOFhlRCei bIh30ZTwlOeH5CSaW5ulDpN3HllF9N9mH2hi/xbksTH0K0DyJShkPzMxuPk7etexxsSOT2 ck5bgXKnhOw/Ua8XNn3VQqtMD5Cly5i8IpzpqZ5XyfjvI9Tie4aoDtQpQS5BPQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739812102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zcVVUQI3kJKz3pWxsP7RCtUtuZHTB08Z1jNFE0/SD1k=; b=p8t/tnpPShNYqF2vEaXe0/X9BQ+BsUdJw7ZCJzfM/t3kWg8z0KMS3a5SOBBMDkxXgCBoDE 99zw7YubsqXBg6OG5nQ7ymXFFH+vk8fMJk8Bkn3GjDtHxLsMA//IO/YGsl3uEHCEbWa3nM xD9Ijo5/ErsNPW44EQIjdIl3e4R0jgJn8B8dyZoLfxVM4y/0uHp94R4m/FqrPd8c0kFC1L MEqehQUUG9cQ1vE1sEWbwb17xaWPTnZI3pRyDfzOErqu0T7QF98c4wPTjW5mkFnk9FbH+4 Bc9P6fiqbziN+vEHimhTZGZnHPEkNGvk+RZvlNbQiyj9m6jlj+8F9FW1bx8uKw== Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R10" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4YxTd2258Rz6Ww; Mon, 17 Feb 2025 17:08:22 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id EEDAE1F37C; Mon, 17 Feb 2025 18:08:19 +0100 (CET) From: Kristof Provost To: John Baldwin Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 7e7f88001d7d - main - pf: use time_t for storing time_t values Date: Mon, 17 Feb 2025 18:08:18 +0100 X-Mailer: MailMate (2.0r6222) Message-ID: <1B3E8B07-037B-4DA9-A8D7-81F866078A39@FreeBSD.org> In-Reply-To: <5c019c51-949b-4255-bc44-926ac973a1af@FreeBSD.org> References: <202502141750.51EHoOFm061342@gitrepo.freebsd.org> <5c019c51-949b-4255-bc44-926ac973a1af@FreeBSD.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=_MailMate_5AB2A4F1-D112-4BA4-A462-4755E187AB4C_=" --=_MailMate_5AB2A4F1-D112-4BA4-A462-4755E187AB4C_= Content-Type: text/plain; charset=UTF-8; format=flowed; markup=markdown Content-Transfer-Encoding: quoted-printable On 17 Feb 2025, at 16:24, John Baldwin wrote: > On 2/14/25 12:50, Kristof Provost wrote: >> The branch main has been updated by kp: >> >> URL: = >> https://cgit.FreeBSD.org/src/commit/?id=3D7e7f88001d7dfec83cd7568369be= 6a587d4a51ff >> >> commit 7e7f88001d7dfec83cd7568369be6a587d4a51ff >> Author: Kristof Provost >> AuthorDate: 2025-02-07 10:29:26 +0000 >> Commit: Kristof Provost >> CommitDate: 2025-02-14 17:47:52 +0000 >> >> pf: use time_t for storing time_t values >> No change to the underlying type, so no ABI change. >> We define __time_t as uint64_t if __LP64__, otherwise = >> uint32_t, >> and only define __LP64__ if long is 64 bits. >> In other words: __time_t =3D=3D long. >> ok henning@ deraadt@ >> Obtained from: OpenBSD, guenther , = >> 6c1b69a0ff >> Sponsored by: Rubicon Communications, LLC ("Netgate") >> Differential Revision: https://reviews.freebsd.org/D48963 > > This is an ABI change on non-i386 32-bit platforms in FreeBSD since = > they > all use a 64-bit type for time_t that is not the same size as long. = > Not > sure if the ABI change matters on FreeBSD though? > It wasn=E2=80=99t intended to be an ABI change, hence the commit message.= It = appears that=E2=80=99s only correct for x86 though. So we=E2=80=99re only talking about armv7 and ppc32, if I=E2=80=99m not f= orgetting = anything. The former is on the removal list already, and the latter .. = well, I don=E2=80=99t know how many users there are. Both are likely to b= e = embedded platforms where the ABI change is going to be even less = relevant (because it really only matters if the kernel and userspace are = not updated together, and these are going to be embedded devices that = are far more likely to have everything updated simultaneously). So I=E2=80=99m unsure about what to do. I can revert this and we can just= = carry this (trivial) diff to OpenBSD forever, or we can ignore the ABI = breakage given the above. I=E2=80=99m not inclined to do anything more = involved though. Do you have any thoughts? Best regards, Kristof --=_MailMate_5AB2A4F1-D112-4BA4-A462-4755E187AB4C_= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On 17 Feb 2025, at 16:24, John Baldwin wrote:

On 2/14/25 12:50, Kristof Provost wrote:

The branch main has been updated by kp:

URL: https://cgit.FreeBSD.org/src/co= mmit/?id=3D7e7f88001d7dfec83cd7568369be6a587d4a51ff

commit 7e7f88001d7dfec83cd7568369be6a587d4a51ff
Author: Kristof Provost kp@FreeBSD.= org
AuthorDate: 2025-02-07 10:29:26 +0000
Commit: Kristof Provost kp@FreeBSD.= org
CommitDate: 2025-02-14 17:47:52 +0000

 p=
f: use time_t for storing time_t values
     No change to the underlying type, so no ABI change.
     We define __time_t as uint64_t if __LP64__, otherwise uint32_t,
 and only define __LP64__ if long is 64 bits.
 In other words: __time_t =3D=3D long.
     ok henning@ deraadt@
     Obtained from:  OpenBSD, guenther <guenther@openbsd.org>, 6c1b=
69a0ff
 Sponsored by:   Rubicon Communications, LLC ("Netgate")
 Differential Revision:  https://reviews.freebsd.org/D48963

This is an ABI change on non-i386 32-bit platforms in Fre= eBSD since they
all use a 64-bit type for time_t that is not the same size as long. Not<= br> sure if the ABI change matters on FreeBSD though?

It wasn=E2=80=99t intended to be an ABI change, hence the= commit message. It appears that=E2=80=99s only correct for x86 though.

So we=E2=80=99re only talking about armv7 and ppc32, if I= =E2=80=99m not forgetting anything. The former is on the removal list alr= eady, and the latter .. well, I don=E2=80=99t know how many users there a= re. Both are likely to be embedded platforms where the ABI change is goin= g to be even less relevant (because it really only matters if the kernel = and userspace are not updated together, and these are going to be embedde= d devices that are far more likely to have everything updated simultaneou= sly).

So I=E2=80=99m unsure about what to do. I can revert this= and we can just carry this (trivial) diff to OpenBSD forever, or we can = ignore the ABI breakage given the above. I=E2=80=99m not inclined to do a= nything more involved though.

Do you have any thoughts?

Best regards,
Kristof

--=_MailMate_5AB2A4F1-D112-4BA4-A462-4755E187AB4C_=--