From nobody Wed Feb 12 22:17:16 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YtXjn0Qrbz5nR6S; Wed, 12 Feb 2025 22:17:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YtXjm4kjSz3fYb; Wed, 12 Feb 2025 22:17:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739398636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=v0PbP3DtnmZeTk9Fw4GY+7slosIcOjuqGfpSroSgrRQ=; b=B8Tzn+hrzri+o6oiOcpJVpI2JPlxbxHtbi06bn0Y6Uyf4eVjykjlCUWELcIFPH5iGWnnxr JyibMJ9jOT+m9lncAD+XOQLUANKtyzNDHcDexVVWKDoFuvBx/dICzqcRqy8l2wPSuj9fkU 4VuK64J6DzptWCNtHnir40j9On54ODK2q8IKsPDq4COyygRGMJAEKIBfDAIyGDmPsAVybU VfhIUri1/8/1aFnq0ROO0OFV0YGRbdJRXYwIScSYc7F3LxP57HX5szno8DZ71jp7jKMsW1 WSf8wjO8gKAhz4HC6RS9VyiUW+ZcYyNO7OTGANUV2IUM+34a8kgS5GT1F7vfvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739398636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=v0PbP3DtnmZeTk9Fw4GY+7slosIcOjuqGfpSroSgrRQ=; b=miHuwwNslzH941GnqMI1dwFbsfY+jRaD1cU14mkxiaDCpOq2lECmcpxtZE7Zc9PjLdRgaz taw7UFob3E8fdcn4RMKpvRx6kfIGDFNORj7mCOuIM0GGw9P74AIkI16UmxmcKF5fS/zzvL QMqk/ACYHPT8ikPe0QIHe8m+yQ4djPUcmRuxP9DCkWcXBLhYpGNeY29UEOM4rXwD7wdDtI j3roEgRtRmLEMoKD+R+7nTXBWpUMJT7Kb2+Vz86Zdh38a8NeSwZHbzMa+qw1ZmOf0OVR94 xbT1+S9gVpercvhtDO+w5A89jL+Yx8+1rZZ44/+ze7q5qVN1GAy0SfohmAgv8A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1739398636; a=rsa-sha256; cv=none; b=iuT7/Q+qbNnyhDyqcSQqy3AQtsLRFnbupYIZSS9icYWLTNub4W9NFIulRrJMXJ38ku+0xn q8IB4Bp8+6lZj3UnAedrFzGyoGIRTf/9Z2UJVd0g5RZGitw8yZ4fYg+SVjLARHvJ2ErdJK MJDJs8rX47kQ0smaIt4V0xdwtydfCn3JCk7wFMIAsgx/dvTDYifNNhwpIW6XAUFUWK39IU V31pn8j6y/UkXjsRweIzu4tnrY/858G2E8ct+eMhOAhkhWNfF8QPLgdHaH5Hm6QvVyFPY8 0qReLurfrt+E6hTmyK7tH17X5UgQcZDuUgRpvtlSxWmKC2XqxrZbpyAtrdnJFA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YtXjm3rbpz2fg; Wed, 12 Feb 2025 22:17:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 51CMHGfx060004; Wed, 12 Feb 2025 22:17:16 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 51CMHGO1060001; Wed, 12 Feb 2025 22:17:16 GMT (envelope-from git) Date: Wed, 12 Feb 2025 22:17:16 GMT Message-Id: <202502122217.51CMHGO1060001@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: d6cce475cb5f - main - mtw: Pass the right pointer to the constructed command in mtw_mcu_radio List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d6cce475cb5f5c449532984e9c661596950fa26e Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=d6cce475cb5f5c449532984e9c661596950fa26e commit d6cce475cb5f5c449532984e9c661596950fa26e Author: John Baldwin AuthorDate: 2025-02-12 22:13:33 +0000 Commit: John Baldwin CommitDate: 2025-02-12 22:17:00 +0000 mtw: Pass the right pointer to the constructed command in mtw_mcu_radio This was just using random stack garbage before. Reported by: GCC -Wunused-but-set-variable --- sys/dev/usb/wlan/if_mtw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/usb/wlan/if_mtw.c b/sys/dev/usb/wlan/if_mtw.c index ecd4693e2361..d7970af5d876 100644 --- a/sys/dev/usb/wlan/if_mtw.c +++ b/sys/dev/usb/wlan/if_mtw.c @@ -4384,7 +4384,7 @@ mtw_mcu_radio(struct mtw_softc *sc, int func, uint32_t val) cmd.r2 = htole32(val); cmd.r3 = 0; cmd.r4 = 0; - return (mtw_mcu_cmd(sc, 8, &val, sizeof(struct mtw_mcu_cmd_16))); + return (mtw_mcu_cmd(sc, 8, &cmd, sizeof(struct mtw_mcu_cmd_16))); } static void mtw_init_locked(struct mtw_softc *sc)