From nobody Wed Feb 05 19:55:40 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Yp9vd1QZGz5mJQ1; Wed, 05 Feb 2025 19:55:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Yp9vc4Rg0z42Vw; Wed, 05 Feb 2025 19:55:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738785340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JFy321MYBSuhcZTEcOrZjeCE/nmlPioZ4YYbAPWV8f0=; b=KTA5hjoZdAS7LY4dsyxt9x+j5RHewqnb7q3M+9ln2xkvtuSV5ydP2X8v86HQB6IPeWB7Lr e3TuE8WPGE4WU7n2i6sKM1hWFwB56RkmWgzkKXUNF355EprJV7XtUm+jHTsxbV2dba3xsg pePl7x6KX3F9R4cyf8kzydZHRC+Ksm7V8FLAQhmqHp9Nr/76P/CmXCzUcV/pf+H3g5tVCK 4lTdE1Lp/yBsHHoRBTDEBqMrhW82gOxP/mNlzE7OYfZ3V3GAVJL3Wmih5yeZSumacf3qVO 8kyYbpka7GkoFyyvAtPtLMRQoEFykENbkVasKQVjV9DK5POeXVUuHx5ZZk852A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738785340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JFy321MYBSuhcZTEcOrZjeCE/nmlPioZ4YYbAPWV8f0=; b=CWh7PcMHFhOS6nwvZoZl6R9X6JwvdnCksv7qVjVuGG5fHlVjp5KH5+s3MpC+DuBXHH7M0H tw6hFP4CkD9i1Z0mgDMpsNJWOpGCcqKyGYeBmSTeGio0TINZiVah3UPxOTeZBjTUA4yklj JIDPRYO67FHDZu3KhT9UbzbSiIkWGL5yochL+baY2RLowZtT2rSTauM2B2GRTvj5mtPUdT 4K5ri8z4R8I0fiLmEQAIDNTf6sBICs0cLAEbgiZyeUyzsjc1KkINKh/zlwzsVlpnsrPq9u NPSLA0vzx5Fg/5R70m9GbbSAighMyyWkVMFh8cu3jR364N6V9WFTz5dQLgVK0g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738785340; a=rsa-sha256; cv=none; b=qsKMARH405+hDsiGIihUi1idKpdMcE53tkerS0yV3U6X4aCHaS3i6sId4tFCLuqakk8wu6 hsjjoRyumEuBLFeqSlOozrQmduwLYw1ph1tLIvBtlITph7q2aM9QNPj/hwi1VHdmLZZrsh hFcoB2OiPNgNhMSI1o0ccsWVgktaR/8x22iupvUt3qZkJCcsAfnOvuXEvnpxWGOHvWSqGF SMFy/jRVkTZvJBUjqjliZuEPeLkQTlmUKgVlrzxPFlx0D291VQ9hBaadKYe5sumFVmsA+/ usT0EqEVAwfuu37gCw/VOd6JdoQIvnKzEHHg7pLgNwzwa4ZXQEL/UHA7A/tTNA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Yp9vc3yF8z15Q5; Wed, 05 Feb 2025 19:55:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 515Jtehn087882; Wed, 5 Feb 2025 19:55:40 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 515JteJC087879; Wed, 5 Feb 2025 19:55:40 GMT (envelope-from git) Date: Wed, 5 Feb 2025 19:55:40 GMT Message-Id: <202502051955.515JteJC087879@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 0a3e74f55aed - main - ctld: Don't specify the TCP port for default iSCSI portal group sockets List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0a3e74f55aedc20dce7fc3a456d8307155627460 Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=0a3e74f55aedc20dce7fc3a456d8307155627460 commit 0a3e74f55aedc20dce7fc3a456d8307155627460 Author: John Baldwin AuthorDate: 2025-02-05 19:53:55 +0000 Commit: John Baldwin CommitDate: 2025-02-05 19:55:16 +0000 ctld: Don't specify the TCP port for default iSCSI portal group sockets portal_group_add_listen already uses the default TCP port if no port is specified so this was redundant. Reviewed by: asomers Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D48770 --- usr.sbin/ctld/ctld.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/usr.sbin/ctld/ctld.c b/usr.sbin/ctld/ctld.c index 3b48d33b5966..d0ba0522f8e2 100644 --- a/usr.sbin/ctld/ctld.c +++ b/usr.sbin/ctld/ctld.c @@ -2592,8 +2592,8 @@ conf_new_from_file(const char *path, bool ucl) "going with defaults"); pg = portal_group_find(conf, "default"); assert(pg != NULL); - portal_group_add_listen(pg, "0.0.0.0:3260", false); - portal_group_add_listen(pg, "[::]:3260", false); + portal_group_add_listen(pg, "0.0.0.0", false); + portal_group_add_listen(pg, "[::]", false); } conf->conf_kernel_port_on = true;