Re: git: 0f1bf1c22a0c - main - umb: Introduce the USB umb(4) network driver

From: Bjoern A. Zeeb <bz_at_freebsd.org>
Date: Sat, 01 Feb 2025 12:58:57 UTC 
On Fri, 31 Jan 2025, Gleb Smirnoff wrote:

> On Fri, Jan 31, 2025 at 08:16:53PM -0800, Adrian Chadd wrote:
> A> > > commit 0f1bf1c22a0c97e84a4db19197a75952487aa20b
> A> > > Author:     Adrian Chadd <adrian@FreeBSD.org>
> A> > > AuthorDate: 2025-01-20 23:46:15 +0000
> A> > > Commit:     Adrian Chadd <adrian@FreeBSD.org>
> A> > > CommitDate: 2025-01-20 23:46:15 +0000
> A> > >
> A> > >    umb: Introduce the USB umb(4) network driver
> A> >
> A> > Still breaks at least:
> A> > amd64 MINIMAL kernel failed, check _.amd64.MINIMAL for details
> A> > amd64 MINIMALUP kernel failed, check _.amd64.MINIMALUP for details
> A>
> A> It wasn't broken when it landed, I did a universe pass.
>
> This is not related to Adrian's changes, but to 1111a44301da39d7b7459c784230e1405e8980f8.
>
> I have the patch in my queue, waiting for universe.

Sorry.  My fault.

umb only has an unused function in the default compile settings due to a
missing #ifdef DEV_NETMAP.

      24 1 warning generated.
      25 /tank/users/bz/git/FreeBSD/freebsd-src/sys/dev/usb/net/if_umb.c:848:1: warning: unused function 'umb_input' [-Wunused-function]
      26   848 | umb_input(if_t ifp, struct mbuf *m)
      27       | ^~~~~~~~~

-- 
Bjoern A. Zeeb                                                     r15:7