From nobody Mon Dec 29 15:09:24 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dg04R287Tz6LvVt; Mon, 29 Dec 2025 15:09:27 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dg04R0gwZz3vKk; Mon, 29 Dec 2025 15:09:27 +0000 (UTC) (envelope-from dim@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1767020967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L0Pbmpf0+u8M9XX3k4qkpw/BtE20taHYwIxk55qOSGA=; b=JImZ9kEIJbMepqc+rWC+dlUnbAxeswwtfBV3WLcnQwsqTayVuFw5TV1p9t7kFLXAEwC3qR /NecdBOb83FeDNjLrSFPCKzujoPWfIXbgf78HG5Cw/iBMOcj6gIJLKdEy+auG2i6BZKtQm MhBOh7JFSvc3bpQTEx5BHVqS3/kksTcezs4h49LnJGITI7MLhtDhjwH0WTAGWiN20Q4c0P J/qSH71XbHBXz9/3TvmC1z0ZUqqq3hITygO8ZoBf13VBzQJFAzDF/cJslK05MFgNv144md EBkjnZ6RO5zKj1ZoS3eqMFUaB7tHAYfxlh5+NYTVlfyxH0QxPYghovPOOklpjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1767020967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L0Pbmpf0+u8M9XX3k4qkpw/BtE20taHYwIxk55qOSGA=; b=auREVMUe6lZbSsKkIQhmsCgHSgZ5DnNnqZOPF2REhY2JtMOrVqtfubhlY9GQwMjbPTZiC9 xQXfVIh+jXmZh1ED42r2ruoX4dbW6jDfKEAl3nC1m7zx6nf5EkRNvn1d0xu/Mn7L9i/a72 xqH4McfLE6/wkAOKYqiNsAD6QK0knsZn1+MBOlvY9DE6wOmVG4SVzBoJmqkvN09SNJUXRf uuGFSKCDzivMCRJloAd8/wDGpZU5E1SQDRJTJtrzGpmocP8gfApiB6s5cH8uxMbJeNSvq3 Bvd0dbaR5UvxVTakjqrGr0VB3Y2jMSaR6cimT59UYVj9b0Cz01fgFSGsuJlAEQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1767020967; a=rsa-sha256; cv=none; b=A2GRW7baDbbSKE4DxLykVy1BY/42t2QmbSjOS/mml1BCpGvU1dUtf9vCDeUGq42xbo5ZcM Ei67vFTFRR6qzFynn0LHc1fPnznRiDQMb11MrpnXul/Z/lVElQWM57m2pzQSBdy4FALKCi PMw8dpPfVyodCp7J4hvshac/O/eB/lPRDGPA7uiVeKQq+Y/fmQKe3myZAh3Mqzq0x1crEt Dp1rGVmsoXUboWufBjwKHb3QPsT0wk7D599dVtUk2qIJuuSi+d+WfGU6vpQZNxizipw5Ka iyrVJ2VGlOM4doNJeR8OtAiqBy/eP+N55u8tCVSS93tqQdMZq9sa0nYHem1U+g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "tensor.andric.com", Issuer "E7" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 4dg04Q68MgzNhd; Mon, 29 Dec 2025 15:09:26 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtpclient.apple (bladnoch.home.andric.com [192.168.0.20]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 3040A59BDD; Mon, 29 Dec 2025 16:09:25 +0100 (CET) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.4\)) Subject: Re: git: faeaa25f5624 - main - kernel: MK_REPRODUCIBLE_PATHS for full paths vs /usr/src From: Dimitry Andric In-Reply-To: <6950e7a3.3b044.1eb2b705@gitrepo.freebsd.org> Date: Mon, 29 Dec 2025 16:09:24 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <86EF92B6-B19D-477E-8BBF-2B25190C781C@FreeBSD.org> References: <6950e7a3.3b044.1eb2b705@gitrepo.freebsd.org> To: Warner Losh X-Mailer: Apple Mail (2.3826.700.81.1.4) On 28 Dec 2025, at 09:17, Warner Losh wrote: >=20 > The branch main has been updated by imp: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dfaeaa25f562493370a5da84b429ab0a1= 17c3213a >=20 > commit faeaa25f562493370a5da84b429ab0a117c3213a > Author: Warner Losh > AuthorDate: 2025-12-28 07:31:05 +0000 > Commit: Warner Losh > CommitDate: 2025-12-28 08:16:39 +0000 >=20 > kernel: MK_REPRODUCIBLE_PATHS for full paths vs /usr/src >=20 > There are many environments that you do not want the paths to be > canonicalized. For example, if I always build a product from a = specific > path in a jail that's dependent on the product version, I don't = want > that to be sanitized to /usr/src because when I have profiling = tools run > against multiple kernels, I can't do A/B testing and results = processing > if everything points to /usr/src (sadly, the profiling tools cannot > remap back to the original like gdb can). Since we need both active = at > the same time, symbloic link fallbacks don't work. >=20 > We do want the rest of the build to be reproducible, however. We'll = get > the same binaries if we rebuild later since we always rebuild with = the > same path. >=20 > Turn them both on for maximum reproduction for environments where = that > cannot be guaranteed. >=20 > Sponsored by: Netflix > Input from: emaste, ivy > Differential Revision: https://reviews.freebsd.org/D52959 This breaks at least the devel/libsysinfo port, which error out with: =3D=3D=3D> Building for libsysinfo-0.0.3_3 make: /usr/share/mk/bsd.debug.mk:19: Variable "MK_REPRODUCIBLE_PATHS" is = undefined in /usr/share/mk/bsd.lib.mk:525 in /wrkdirs/usr/ports/devel/libsysinfo/work/libsysinfo-0.0.3/Makefile:16 make: Fatal errors encountered -- cannot continue make: stopped making "all" in = /wrkdirs/usr/ports/devel/libsysinfo/work/libsysinfo-0.0.3 *** Error code 1 I think bsd.debug.mk should now include src.opts.mk, not only = bsd.opts.mk? Either that, or MK_REPRODUCIBLE_PATHS should be moved to bsd.opts.mk. -Dimitry