Re: git: c52253232a78 - main - xae(4): remove unused function.

On Fri Dec 12, 2025 at 4:56 PM UTC, Gleb Smirnoff wrote:
> On Fri, Dec 12, 2025 at 03:49:49PM +0000, Ruslan Bukin wrote:
> R> The branch main has been updated by br:
> R> 
> R> URL: https://cgit.FreeBSD.org/src/commit/?id=c52253232a78dc2553d6ea7c9ab3e92301b36c01
> R> 
> R> commit c52253232a78dc2553d6ea7c9ab3e92301b36c01
> R> Author:     Ruslan Bukin <br@FreeBSD.org>
> R> AuthorDate: 2025-12-12 15:47:22 +0000
> R> Commit:     Ruslan Bukin <br@FreeBSD.org>
> R> CommitDate: 2025-12-12 15:49:37 +0000
> R> 
> R>     xae(4): remove unused function.
> R>     
> R>     Sponsored by: CHERI Research Centre
> R> ---
> R>  sys/dev/xilinx/if_xae.c | 6 ------
> R>  1 file changed, 6 deletions(-)
> R> 
> R> diff --git a/sys/dev/xilinx/if_xae.c b/sys/dev/xilinx/if_xae.c
> R> index 7880f93c48ee..435902dc3c10 100644
> R> --- a/sys/dev/xilinx/if_xae.c
> R> +++ b/sys/dev/xilinx/if_xae.c
> R> @@ -543,11 +543,6 @@ xae_get_phyaddr(phandle_t node, int *phy_addr)
> R>  	return (0);
> R>  }
> R>  
> R> -static void
> R> -xae_qflush(if_t ifp)
> R> -{
> R> -}
> R> -
> R>  static void
> R>  xae_stop_locked(struct xae_softc *sc)
> R>  {
> R> @@ -1239,7 +1234,6 @@ xae_attach(device_t dev)
> R>  	if_setflags(ifp, IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST);
> R>  	if_setcapabilities(ifp, IFCAP_VLAN_MTU);
> R>  	if_setcapenable(ifp, if_getcapabilities(ifp));
> R> -	if_setqflushfn(ifp, xae_qflush);
> R>  	if_setioctlfn(ifp, xae_ioctl);
> R>  	if_setstartfn(ifp, xae_txstart);
> R>  	if_setinitfn(ifp, xae_init);
>
> This also means this code was never run with INVARIANTS.  Otherwise it would
> panic in if_attach_internal().

Indeed, but just a couple of week since I rewrote it. INVARIANTS were disabled
in my Codasip repo due to experiments with nvme(4), and I forgot re-enable!

Ruslan