git: ef73953ebdc2 - main - gpioc: remove unnecessary bus_generic_* calls
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 27 Aug 2025 21:57:12 UTC
The branch main has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=ef73953ebdc22fdcab014ac3359c7089789e5d4f commit ef73953ebdc22fdcab014ac3359c7089789e5d4f Author: Ahmad Khalifa <vexeduxr@FreeBSD.org> AuthorDate: 2025-08-27 21:26:37 +0000 Commit: Ahmad Khalifa <vexeduxr@FreeBSD.org> CommitDate: 2025-08-27 21:38:32 +0000 gpioc: remove unnecessary bus_generic_* calls gpioc never has any children, so there's no need to call these. Reviewed by: jhb Approved by: imp (mentor) Differential Revision: https://reviews.freebsd.org/D51933 --- sys/dev/gpio/gpioc.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/sys/dev/gpio/gpioc.c b/sys/dev/gpio/gpioc.c index 212445334b27..5a60f939dc78 100644 --- a/sys/dev/gpio/gpioc.c +++ b/sys/dev/gpio/gpioc.c @@ -621,7 +621,6 @@ static int gpioc_detach(device_t dev) { struct gpioc_softc *sc = device_get_softc(dev); - int err; if (sc->sc_ctl_dev) destroy_dev(sc->sc_ctl_dev); @@ -632,9 +631,6 @@ gpioc_detach(device_t dev) } free(sc->sc_pin_intr, M_GPIOC); - if ((err = bus_generic_detach(dev)) != 0) - return (err); - return (0); } @@ -1066,9 +1062,6 @@ static device_method_t gpioc_methods[] = { DEVMETHOD(device_probe, gpioc_probe), DEVMETHOD(device_attach, gpioc_attach), DEVMETHOD(device_detach, gpioc_detach), - DEVMETHOD(device_shutdown, bus_generic_shutdown), - DEVMETHOD(device_suspend, bus_generic_suspend), - DEVMETHOD(device_resume, bus_generic_resume), DEVMETHOD_END };