From nobody Wed Aug 27 21:57:09 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cBz073C35z65jtF; Wed, 27 Aug 2025 21:57:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cBz0635cnz3F7g; Wed, 27 Aug 2025 21:57:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756331830; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ilE8zu1w0TGGNZ1hJa6KjcchjR+gYLhievgvX3GlsRA=; b=La24dxqVdO/1QGpDqemiQe6rQJm3Eyp8QFOJHgKOt36/98TBd/fHbTsK2umppVtzEDNkZD 0NJ5/R5G/othX/Xy39WIpQo1VYELYcwStFbLvOwvisxeOfLkupmX9OnOFftESUvEaW7OJ1 Vo0rOKIZxnBrim4EdIzRyMWekrgFDbvwN7Cp+27xUraNF0U7C2hCTLUI4U63SqJ9+S1eWC 67JB8XrCoDlI82HuEaPnKPpQZ0MSijqj4TNO7VH9XANPc9zyQFM1c0+OAnK1CROW8mLewS FtJ6tFXIds1bJ7wdLQ5BNV4avAT/4VNAmA6+8dL10O20FKxg9RVLfkQKcMAEgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756331830; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ilE8zu1w0TGGNZ1hJa6KjcchjR+gYLhievgvX3GlsRA=; b=lFq4PRLmdPm0gQXy/rGAgVoVXi/cJRVGHyUCGSi0y+wpVpyabz/QdyUrwbu7YzCcc4qNL6 lUku+Knm1UII12hPHdc2wjoPKehs2BszJcodSQU071sMVNlcatWMlIom/vdqm5cvLh/bAO R2Vuk3ZLtOpsSigRak2miQE1Br5BS1n3WtuWRZex3i7GZ3AzsshFGZ3l1mUz37DpXew0rN vQvTMoJ4xJZ7WGLQGgaXAsQ1fkCJ4PfFsH48NkAGnmZCerYjM1ZCLG5+7L+8hWnolu+P2I uT7/ceC53cMtrga+mgHIHFI+49WwLoCO9rMvUkzEmK75AUz3e7Au7inTejK/kQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1756331830; a=rsa-sha256; cv=none; b=uXR/wF4vGD7hCX6YOh18riFuFo0SR3KnL2uXcNFTu3QX5zclO6KL7d/lCtdZf6aBsNzN19 VlErU9kWg/qYNitKHWFyUmtXh00b/8yL5L8cEf8JIFroDLN95jZKzUsTY9q6/WH/SB6LwV +lqbqfPtd14jYw4pr3kOYDBlvEgGK4hQh89v4pEXDJCc4niXbRNVlrYhF+KISldf0AeK6v xKjDgpca8C5FYkSCaj8w+GXW3DDK+/lgVqvJXLMjE8VvpEGubOi+ffk3A1W30BXSxwlAzW 4iDDPs2GMqQjeqL8KO/W1vE8Gm8ncmRlo4/hgjurB8HU5arDt07vjrWsZVv6ag== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cBz055Rc2zh0p; Wed, 27 Aug 2025 21:57:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 57RLv9mp026459; Wed, 27 Aug 2025 21:57:09 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 57RLv9RZ026456; Wed, 27 Aug 2025 21:57:09 GMT (envelope-from git) Date: Wed, 27 Aug 2025 21:57:09 GMT Message-Id: <202508272157.57RLv9RZ026456@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ahmad Khalifa Subject: git: 59e74fdfafcf - main - gpioc: cleanup if pin allocation fails List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 59e74fdfafcff3310c316dcec3bccfd04f8722b4 Auto-Submitted: auto-generated The branch main has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=59e74fdfafcff3310c316dcec3bccfd04f8722b4 commit 59e74fdfafcff3310c316dcec3bccfd04f8722b4 Author: Ahmad Khalifa AuthorDate: 2025-08-27 21:25:10 +0000 Commit: Ahmad Khalifa CommitDate: 2025-08-27 21:38:32 +0000 gpioc: cleanup if pin allocation fails gpioc normally depends on gpioc_cdevpriv_dtor to call gpioc_release_pin_intr when it's done with a pin. However, if gpioc_allocate_pin_intr fails, the pin is never added to the linked list which the destructor loops over to free the pins. Make it so gpioc_allocate_pin_intr cleans up after itself if it fails. Reported by: Evgenii Ivanov Approved by: imp (mentor, implicit) Differential Revision: https://reviews.freebsd.org/D51998 --- sys/dev/gpio/gpioc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sys/dev/gpio/gpioc.c b/sys/dev/gpio/gpioc.c index 87fed38ebe3e..77aaf2cb5447 100644 --- a/sys/dev/gpio/gpioc.c +++ b/sys/dev/gpio/gpioc.c @@ -208,8 +208,11 @@ gpioc_allocate_pin_intr(struct gpioc_pin_intr *intr_conf, uint32_t flags) err = bus_setup_intr(intr_conf->pin->dev, intr_conf->intr_res, INTR_TYPE_MISC | INTR_MPSAFE, NULL, gpioc_interrupt_handler, intr_conf, &intr_conf->intr_cookie); - if (err != 0) + if (err != 0) { + bus_release_resource(sc->sc_dev, intr_conf->intr_res); + intr_conf->intr_res = NULL; goto error_exit; + } intr_conf->pin->flags = flags;