Re: git: 2b74ff5fceb6 - main - ichwd: introduce i6300esbwd watch dog driver

On Mon, 25 Aug 2025, ShengYi Hung wrote:

> The branch main has been updated by aokblast:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=2b74ff5fceb6623f6114ce39baee9f6ec5f79277
>
> commit 2b74ff5fceb6623f6114ce39baee9f6ec5f79277
> Author:     ShengYi Hung <aokblast@FreeBSD.org>
> AuthorDate: 2025-08-22 14:55:45 +0000
> Commit:     ShengYi Hung <aokblast@FreeBSD.org>
> CommitDate: 2025-08-25 15:45:24 +0000
>
>    ichwd: introduce i6300esbwd watch dog driver
>
>    The intel 6300ESB watchdog is a special ICH-based watchdog device with a
>    different interface.
>    QEMU implements this watchdog for x86 systems.
>
>    This change enables watchdog mode (rather than free-running mode) and
>    introduces 1 sysctl:
>    - hw.i6300esbwd.0.locked: locks the watchdog register after the event is
>    triggered, preventing it from being disabled until a hard reset.
>
>    This feature has been tested on a Vultr AMD guest machine and local qemu
>    machine.
>
>    PR:    259673
>    Approved by:    markj (mentor), lwhsu (mentor)
>    MFC after:      2 weeks
>    Sponsored by:   The FreeBSD Foundation
>    Differential Revision: https://reviews.freebsd.org/D52049
> ---
> sys/conf/files.x86         |   1 +
> sys/dev/ichwd/i6300esbwd.c | 245 +++++++++++++++++++++++++++++++++++++++++++++
> sys/dev/ichwd/i6300esbwd.h |  46 +++++++++
> sys/dev/ichwd/ichwd.c      |   2 +-
> sys/dev/ichwd/ichwd.h      |   3 +-
> sys/modules/ichwd/Makefile |   2 +-
> 6 files changed, 296 insertions(+), 3 deletions(-)

Compiling GENERIC I see:

/sys/dev/ichwd/i6300esbwd.c:49:1: warning: unused function 'i6300esbwd_cfg_read' [-Wunused-function]
    49 | i6300esbwd_cfg_read(struct i6300esbwd_softc *sc)
       | ^~~~~~~~~~~~~~~~~~~

Is it needed or can it be removed?

-- 
Bjoern A. Zeeb                                                     r15:7