From nobody Mon Aug 25 22:43:21 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c9m6K5L95z65mQV; Mon, 25 Aug 2025 22:43:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c9m6K4Y0cz3Xkm; Mon, 25 Aug 2025 22:43:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756161801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FiWZ/g+KSQyjKJn5lLjHn/8r60qZMnYwj1DdI9IGfe0=; b=PFPPoklmG3JdflMogC3ow/NLck0sUb7uO7W0CilFABJqgFR3Eyt7dXDE1r1LP/6PKBHjMt I880ckOYVAMZ+LIWg9b9lumyjYgxGIFWHlH6zK2J4S7mnr9xRt3Ccwhf+vZk+3P/E4LnNy f6dFbobzPIOFSahTfB4ZOQElnOLui0vcFvTCzZu1YEDJLL9xUJC5AQXT7Idn+UnWS4nonN m/PKH+c0FBsoe7gvs8fgX8hbnLH2qVnCukI5FIO2lemZlYbmQsQ5PrAsLc5UHJZ3cOPxg8 CWmav3tc4QQoGUdsUG1cwyJGGszce0Sre9k/7fVx2ctfMfB61abuUPdyangGwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756161801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FiWZ/g+KSQyjKJn5lLjHn/8r60qZMnYwj1DdI9IGfe0=; b=ooCkLNpS9L5dd/kFz9MSeOGG1ZIg1zHTq84Ob4+LZKjfdicG+aJGpF2WBq3guSQOSBYSTR XLLmF3mkQsIrkRdmQwFLVNQxoqUzJXb3nPfFcviokscOLWsFidHa/4LqF9RdvnEDj02t1W uy5Bc9JlhX5A9DWhOGUVSXoxZMzRH6fKj1tmNnM7z3HA+G//pmVu/AxsJQ2xFhq0P/mBBq nf0fXlYG542NCbXsivSVOJ/MSAbN3PZD4Tw6Z8vTJuI6ago+S/VTwjJTGMkc7swxTploAD NHNiilYdmj80J76uLraQvXFak0+kFmeWsVI+IMW7BCnJyRAu03l125/L1fw67A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1756161801; a=rsa-sha256; cv=none; b=r8jlFXDB1GzZ1eRVRta64mtUkX0pBGsjp4JmFvFQSiMI0AzQQBFX6DnoS4spUjLSYwD812 ohtMhre7l3QEnHRpOwI8yG2cqCzXgaXjKM0LALGBFeRAz+oS+A2TN/b0wToWUYn8tmRq+/ gmGVWA80iz41UdoAwEdUiOiXXSmdnnxJkc3/zjXdfp89aGEV7DyUgtu4ZVsFFTRcYhD/Hn X2mPRB8evMlkq3ViSfrZ58ZV1X2qaxXxSGy/0+6pNmiNS84ybhR4iuNUrvQ50hwquEwToZ FvfHRRl9v3PKrQPTvfR0oSgy4oSj0KSV4mo6gR6kjWND8VxgFoyMze2mfkpH/g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4c9m6K3x5Wz189t; Mon, 25 Aug 2025 22:43:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 57PMhLUH081929; Mon, 25 Aug 2025 22:43:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 57PMhLPa081926; Mon, 25 Aug 2025 22:43:21 GMT (envelope-from git) Date: Mon, 25 Aug 2025 22:43:21 GMT Message-Id: <202508252243.57PMhLPa081926@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Aymeric Wibo Subject: git: 5bd5774ff63c - main - netlink: Handle `ifhwioctl(SIOCSIFMTU)` failure List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: obiwac X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5bd5774ff63c735087ff3a6604e4066a265d9b6c Auto-Submitted: auto-generated The branch main has been updated by obiwac: URL: https://cgit.FreeBSD.org/src/commit/?id=5bd5774ff63c735087ff3a6604e4066a265d9b6c commit 5bd5774ff63c735087ff3a6604e4066a265d9b6c Author: Aymeric Wibo AuthorDate: 2025-08-25 22:32:17 +0000 Commit: Aymeric Wibo CommitDate: 2025-08-25 22:32:21 +0000 netlink: Handle `ifhwioctl(SIOCSIFMTU)` failure Print out error message if setting MTU fails when modifying interface using netlink. Reviewed by: saheed, melifaro, mckusick (mentor) Approved by: saheed, melifaro, mckusick (mentor) Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D52132 --- sys/netlink/route/iface_drivers.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sys/netlink/route/iface_drivers.c b/sys/netlink/route/iface_drivers.c index f177d8df2ad6..2a75e6abb2d0 100644 --- a/sys/netlink/route/iface_drivers.c +++ b/sys/netlink/route/iface_drivers.c @@ -93,7 +93,12 @@ _nl_modify_ifp_generic(struct ifnet *ifp, struct nl_parsed_link *lattrs, if (lattrs->ifla_mtu > 0) { if (nlp_has_priv(npt->nlp, PRIV_NET_SETIFMTU)) { struct ifreq ifr = { .ifr_mtu = lattrs->ifla_mtu }; - error = ifhwioctl(SIOCSIFMTU, ifp, (char *)&ifr, curthread); + error = ifhwioctl(SIOCSIFMTU, ifp, (char *)&ifr, + curthread); + if (error != 0) { + nlmsg_report_err_msg(npt, "Failed to set mtu"); + return (error); + } } else { nlmsg_report_err_msg(npt, "Not enough privileges to set mtu"); return (EPERM);