From nobody Mon Aug 25 19:53:08 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c9hKw4W3gz65XdS; Mon, 25 Aug 2025 19:53:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c9hKw3srBz3HHX; Mon, 25 Aug 2025 19:53:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756151588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Z5cJ662p4u49/pYTd7A/+5kw5vfKcwKiwTm8A/8maA4=; b=xh8GhiU7w+RvsKFYi5ws+7fhfDBWKnBFOxAEM8zgc4tWJEXBbadcKH3Bo+wnDWU2bMGOWy wVhKlwVkvCBqKd0M+qNHWD2bsz0q/wSjDIdFX77Q1uI/K1KK6WWcZvXa+v+u6k/VrtOdxI 5llqqjKAjsyFnrWfSjQtnM399qs3LIRwnb9GHEwG5p9xSPN1UbhBVs33LffkvMHZbiJm0q 2V+HVZsAZzesiBr8ma5fWUIzkOwW+1koznRxfB6ZnTi+lTfVG5Q1MNMIqjgsJY22FheepR bBNbfpZZYA1erqNFNJYmA4WEW7uebtNegpzGnBH4q3VZYrFM+owN3AVKonMkcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756151588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Z5cJ662p4u49/pYTd7A/+5kw5vfKcwKiwTm8A/8maA4=; b=noDPl8nnw7WUoOIRCM3uU0BLeHW4U3enbMBBXpqhCQx7xyFCuKfsiQb62r2Bjk4aFiv8Fc uMnyWgx07+l/gipAVKmIdfh1YQfYXBtvmqIQuljD9KO3eXj134p8vTvZ6QDN86SF2FWJ8a S4OBWgNAUkNu/tff0vRcijBTKWIshVWqLe1YeGyjUhzTLPkDi9vQ5lL//kE7nrSuKYhdaj e87nQ7dq0kbahpoGlT4sMC83XgSoRhVURtkAIrG4EEXIp59behv/WF4XjV9PIBD7J8NCCd ndujtGp+h+D26H9P0UVUpDJw/oFrKaGfpdejP5Pf70JK9eeDShkktYaR6Em+Hg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1756151588; a=rsa-sha256; cv=none; b=nTzFzSaM8EUGdJmuWVUPR5LJWZZoNwgdpgtY//IINfolxzqcFWfFqF8ZUkf3VVo2Pt+Fxg ev5+gybgX+cBzfC+xMJlTl/x1payJ3qEfyoCbUB1aIqJlSoRw6PoRec4zYwv0Q03XSx/wJ 5wXo7TUZPXFrpkW9riZ2GS4QtlmPsvz09Wetuvv2IeejBVL9jRo/FKyJtGQgYcKIutJOEi lzmXpqn98f93ZKFMVzYQRG3Gn2y1O9tIh1UrNkUUu2GlyhnRaFhdXPORvnNwOB4RK7RXOP G0YX7W3/C80s164P9oRPw+CyPZHp0vmdnTanCQoZ7yzNTVLVECp9/PAxCcnqBA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4c9hKw3CkYz142j; Mon, 25 Aug 2025 19:53:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 57PJr8do062426; Mon, 25 Aug 2025 19:53:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 57PJr84b062423; Mon, 25 Aug 2025 19:53:08 GMT (envelope-from git) Date: Mon, 25 Aug 2025 19:53:08 GMT Message-Id: <202508251953.57PJr84b062423@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Aymeric Wibo Subject: git: f89f82e4042a - main - netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: obiwac X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f89f82e4042a24e451b5ba349119cc3446d55601 Auto-Submitted: auto-generated The branch main has been updated by obiwac: URL: https://cgit.FreeBSD.org/src/commit/?id=f89f82e4042a24e451b5ba349119cc3446d55601 commit f89f82e4042a24e451b5ba349119cc3446d55601 Author: Muhammad Saheed AuthorDate: 2025-08-25 19:50:46 +0000 Commit: Aymeric Wibo CommitDate: 2025-08-25 19:52:59 +0000 netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler IFF_UP could previously only be unset via RTM_NEWLINK. Requests to set IFF_UP, though they succeeded, did not actually set the flag. Reviewed by: obiwac, kp, mckusick (mentor) Approved by: obiwac, kp, mckusick (mentor) Sponsored by: Google LLC (GSoC) Differential Revision: https://reviews.freebsd.org/D51871 --- sys/netlink/route/iface_drivers.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/sys/netlink/route/iface_drivers.c b/sys/netlink/route/iface_drivers.c index 21db3017df18..f177d8df2ad6 100644 --- a/sys/netlink/route/iface_drivers.c +++ b/sys/netlink/route/iface_drivers.c @@ -82,9 +82,12 @@ _nl_modify_ifp_generic(struct ifnet *ifp, struct nl_parsed_link *lattrs, } } - if ((lattrs->ifi_change & IFF_UP) && (lattrs->ifi_flags & IFF_UP) == 0) { - /* Request to down the interface */ - if_down(ifp); + if ((lattrs->ifi_change & IFF_UP) != 0 || lattrs->ifi_change == 0) { + /* Request to up or down the interface */ + if (lattrs->ifi_flags & IFF_UP) + if_up(ifp); + else + if_down(ifp); } if (lattrs->ifla_mtu > 0) {