Re: git: dea5f973d0c8 - main - ix/ixv: Add support for new Intel Ethernet E610 family devices

From: Bjoern A. Zeeb <bz_at_FreeBSD.org>
Date: Sun, 24 Aug 2025 11:01:15 UTC
On Tue, 19 Aug 2025, Krzysztof Galazka wrote:

> The branch main has been updated by kgalazka:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=dea5f973d0c8d29a79b433283d0a2de8f4615957
>
> commit dea5f973d0c8d29a79b433283d0a2de8f4615957
> Author:     Bhosale, Yogeshnull <nullyogesh.bhosale@intel.com>
> AuthorDate: 2025-08-19 14:19:07 +0000
> Commit:     Krzysztof Galazka <kgalazka@FreeBSD.org>
> CommitDate: 2025-08-19 15:09:33 +0000
>
>    ix/ixv: Add support for new Intel Ethernet E610 family devices
>
>    This is part 1 of the support for the new Intel Ethernet E610 family of devices.
>
>    Introduce new PCI device IDs:
>    • 57AE: Intel(R) E610 (Backplane)
>    • 57AF: Intel(R) E610 (SFP)
>    • 57B0: Intel(R) E610 (10 GbE)
>    • 57B1: Intel(R) E610 (2.5 GbE)
>    • 57B2: Intel(R) E610 (SGMII)
>
>    Key updates for E610 family:
>    • Firmware manages Link and PHY
>    • Implement new CSR-based Admin Command Interface (ACI) for SW-FW interaction
>    • Tested exclusively for x64 operating systems on E610-XT2/XT4 (10G) and E610-IT4 (2.5G)
>    • Enable link speeds above 1G: 2.5G, 5G and 10G
>    • NVM Recovery Mode and Rollback support
>
>    Signed-off-by: Yogesh Bhosale yogesh.bhosale@intel.com
>    Co-developed-by: Krzysztof Galazka krzysztof.galazka@intel.com
>
>    Approved by:    kbowling (mentor), erj (mentor)
>    Tested by:      gowtham.kumar.ks_intel.com
>    Sponsored by:   Intel Corporation
>    MFC after:      2 weeks
>    Differential Revision:  https://reviews.freebsd.org/D50067


/sys/dev/ixgbe/ixgbe_e610.c:1411:13: warning: unused function 'ixgbe_is_media_cage_present' [-Wunused-function]
  1411 | static bool ixgbe_is_media_cage_present(struct ixgbe_hw *hw)
       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

Is that function needed or can it be removed/#if 0ed?

-- 
Bjoern A. Zeeb                                                     r15:7