From nobody Sun Aug 24 05:59:01 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c8jt847jCz65NSS; Sun, 24 Aug 2025 05:59:12 +0000 (UTC) (envelope-from aokblast@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c8jt833Nvz3ltR; Sun, 24 Aug 2025 05:59:12 +0000 (UTC) (envelope-from aokblast@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756015152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MJBDQRjbX8lO6AwmxKD/3g0Q3Oa+Id+P953JsN0/9NQ=; b=JjfemxIWvrrvix6WIkKWB/G+3nEiSYtG+rags6GcrMHbtWyn4HiugO4wOAHx9eqJon9dCu bkqLfPa1BpKpBYLZaYSm+w1eVumxp6Rf23Evldn243HWWqjtVtb0Mv0ci+jVAohqVOzN7P xPaVE0f1q0m0MwdUOhEe4I2CFBFOxuqXd75Zz1wLVuwCR70Zq5t/tQ0HJm+Owqz3RH1OsZ QUE1HBRQ/sgtQxGoY2CysKICSRyacs8veK9VLzJvedk/Rm+v5XsN6S08ke+eWRH9PIDKzx 5ee+yt7ESIQCKxOG0Ne6KwbhOVQeTFz+PGv25MAYD7c5DWVNyEAvXg7vOiDkSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756015152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MJBDQRjbX8lO6AwmxKD/3g0Q3Oa+Id+P953JsN0/9NQ=; b=S/67zzlvJgN78dNOYqVWFf20GYh669voRJ3g60ZVVrWReAm8zCRyAIVmiCQNa49FdZGS9t bR3GpdZkxA8Y8xrY9D2YdvdnMylLpVXJ9wge4Plu/QQTfMCoyP40HTo1/U1JuUBC0A85OP J59dAGd49UDRRFI8ULdr+uponxmWjlqijcKqhK1A+0tneF7xPozr/hNYAG4uQ+CIH6wkIh 8qMff2JkPkybsf/HsWM5OVUC4YSJXyYOJtTW7h53fmSvCpXUpd4TYKvQvu5TkaIiWMuw4Z 2vigBfuV8BnyJmXWJ3ffthwKQJm13qKUIxV66ZQ5pvXxuRsudvKMcZdjdjdk/w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1756015152; a=rsa-sha256; cv=none; b=J+cjo0YiMI9kh7srlPn4yxLRv7uPxosTFoaynV9xwJ2cuu2FIqu0Nil0LZS8L6wqv0lYKu Kmogs21k+VSSfMSfjProaDTV2KoMXj72zuRfPILPFbCucVbaoEWNcghcLtVsksne4GjtbN IkgClU25qkvgVfZLJ3Xx15YVK5l+jib4rRDc1hM5OAW9ljbn5JIJ+oTZiME6JF5z+5hp7I G/K9neqYbX06nuKp9Jh7nKQ2kdjjd2+b69WVvq7QwThwKzO1omGpGWYxa+edoCLlzrFWVW rYD/i/OLsWON7XnU+yzJ3zZ4hjnKsWrVHpduMwoUSBRarGGjtNG1arvyWzzKHg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from aokblastdeMacBook-Pro.local (2001-b011-3808-3444-555d-8966-de6d-8a5b.dynamic-ip6.hinet.net [IPv6:2001:b011:3808:3444:555d:8966:de6d:8a5b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: aokblast) by smtp.freebsd.org (Postfix) with ESMTPSA id 4c8jt61wwHzn2K; Sun, 24 Aug 2025 05:59:09 +0000 (UTC) (envelope-from aokblast@freebsd.org) From: ShengYi Hung To: Cy Schubert Cc: Gordon Bergling , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 1685192ea1fa - main - hkbd: remove erorr detection in KDSKBSTATE ioctl In-Reply-To: <20250823205131.6c44846c@slippy.cwsent.com> (Cy Schubert's message of "Sat, 23 Aug 2025 20:51:31 -0700") References: <202508230450.57N4oxwG023161@gitrepo.freebsd.org> <20250823171011.BCFFF189@slippy.cwsent.com> <20250823203726.55c5a5ec@slippy.cwsent.com> <20250823205131.6c44846c@slippy.cwsent.com> User-Agent: mu4e 1.12.12; emacs 30.1 Date: Sun, 24 Aug 2025 13:59:01 +0800 Message-ID: List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain So currently, the remaining problem is only on the keyboard LED? Would you mind to create a PR so that we can move discusion to a more suitable place? I would like to ask you more question over your environment. Cy Schubert writes: > On Sat, 23 Aug 2025 20:37:34 -0700 > Cy Schubert wrote: > >> On Sat, 23 Aug 2025 13:27:23 -0400 >> ShengYi Hung wrote: >> >> > Hello: >> > >> > I only submit two patches. What is the third patch you have mentioned? >> > Is the one setting "sysctl usbhid=1"? >> > >> > On 8/23/25 13:10, Cy Schubert wrote: >> > > In message , ShengYi Hung writes: >> > >> Hello, thanks for the reminder. I compile the standalone module to test so >> > >> didn't discover that. Fix it right now. >> > >> Gordon Bergling writes: >> > >> >> > >> >> > >>> Hi ShengYi, >> > >>> >> > >>> On Sat, Aug 23, 2025 at 04:50:59AM +0000, ShengYi Hung wrote: >> > >>>> The branch main has been updated by aokblast: >> > >>>> >> > >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=1685192ea1faac28f2d4feede53e7 >> > >> 0b6a380500f >> > >>>> commit 1685192ea1faac28f2d4feede53e70b6a380500f >> > >>>> Author: ShengYi Hung >> > >>>> AuthorDate: 2025-08-21 17:59:15 +0000 >> > >>>> Commit: ShengYi Hung >> > >>>> CommitDate: 2025-08-23 04:50:09 +0000 >> > >>>> >> > >>>> hkbd: remove erorr detection in KDSKBSTATE ioctl >> > >>>> >> > >>>> The KDSKBSTATE ioctl brings the LED up. However, some keyboards (like >> > >> qemu >> > >>>> keyboard) may not have LED or failed to set the LED due to unexpected >> > >> reason. >> > >>>> Therefore, removing the error check as ukbd(4) does allow the keyboard >> > >> works >> > >>>> correctly with kbdcontrol(4). >> > >>>> >> > >>>> Also move hw.hid.hkbd.no_leds sysctl out of HID_BUG thus users can >> > >>>> disable setting LEDs >> > >>>> >> > >>>> PR: 288968 >> > >>>> Reviewed by: wulf >> > >>>> Tested by: trashcan@ellael.org, marklmi26-fbsd@yahoo.com, trkelle >> > >> rs@gmail.coom >> > >>>> Approved by: lwsu (mentor), markj (mentor) >> > >>>> MFC after 1 week >> > >>>> Sponsored by: The FreeBSD Foundation >> > >>>> Differential Revision: https://reviews.freebsd.org/D52101 >> > >>>> >> > >>>> mvalsmva >> > >>>> --- >> > >>> I am not sure how this is related, but since that commit, buildkernel of GE >> > >> NERIC is broken both >> > >>> on amd64 and aarch64. The following error is from an amd64 build, aarch64 i >> > >> s the same. >> > >>> ----------------------------- >> > >>> /storage/freebsd/src/current/sys/dev/hid/hkbd.c:1831:10: error: called ob >> > >> ject type 'char[5]' is not a function or function pointer >> > >>> 1831 | DPRINTF(("error %d", error)); >> > >>> | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~ >> > >>> /storage/freebsd/src/current/sys/dev/hid/hid.h:212:34: note: expanded fro >> > >> m macro 'DPRINTF' >> > >>> 212 | #define DPRINTF(...) DPRINTFN(1, __VA_ARGS__) >> > >>> | ~~~~~~~~~~~~^~~~~~~~~~~~ >> > >>> /storage/freebsd/src/current/sys/dev/hid/hid.h:208:17: note: expanded fro >> > >> m macro 'DPRINTFN' >> > >>> 208 | printf("%s: " fmt, \ >> > >>> | ~~~~~~ ^ >> > >>> 1 error generated. >> > >>> --- hkbd.o --- >> > >>> *** [hkbd.o] Error code 1 >> > >>> ----------------------------- >> > >>> >> > >>> --Gordon >> > >> -- >> > >> Best Regards. >> > >> ShengYi Hung. >> > >> >> > > My machines running X (laptops), >> > > >> > > - the right mouse key no longer works under X, I can no longer use X, >> > > - the caps-lock light will not display under X >> > > - on the text console works, X does not. >> > > >> > > The three commits related have bee reverted locally, functionality has >> > > returned. >> > > >> > > >> > Best Regards. >> > >> > ShengYi Hung. >> > >> >> The hashes are, >> >> 1685192ea1fa >> 8a847947153e >> 6ea7e1f92882 >> >> I don't think 8a847947153e is related. 6ea7e1f92882 must be reverted in >> order to revert 1685192ea1fa. >> > > I reapplied the patches. The problem persisted. A clean kernel build > also works around the problem. > > There is still a problem with the caps lock LED. It works on the > console while under X it will not light until the first non-shift key > is hit. I can live with that. -- Best Regards. ShengYi Hung.