From nobody Fri Aug 22 00:33:38 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c7Lln3n2fz64hPb; Fri, 22 Aug 2025 00:33:57 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c7Lln01mzz3Nsn; Fri, 22 Aug 2025 00:33:56 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pg1-x531.google.com with SMTP id 41be03b00d2f7-b474e8d6d04so1347136a12.0; Thu, 21 Aug 2025 17:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755822830; x=1756427630; darn=freebsd.org; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=rQ/y6X4hXvdo1ukNxY8K9lWYpchTeBDmheRgX7KqkX8=; b=VsOBhgs8A9u7IlBq7cgtkRPNfuRv9auM7OenPbjwOpsh26a/tUgzxiI6+aNc/Aqp3z JxscIeiJXzEwmAbL6k56AYRT45lo8pwfmA+GhFBXGFwklWlM0mRQEfcIgpHhnVdAbmd2 zhpsL739GtLWi70KvXOBIgdxDj7stxCO/4F86Mv/GximfvvSO42A9fShyWT0TT883KP8 /USDGLS85tNiwIb9l/DdAgZm8Cm+EjuKEWgKYPMxi5VouHSFEY39Al/0MtBbYmbxKglx jbAs7oUdr1nHeYJ6+eiRVdvdkCT18564HsjgA/M+6N1TPCHQDhRBTl1b7ppxeSSCTHiI Tg/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755822830; x=1756427630; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rQ/y6X4hXvdo1ukNxY8K9lWYpchTeBDmheRgX7KqkX8=; b=FGvlKjzBSQGCPbq3aYyv6AChqFpn5DhP85T12hk+I9w03kLmw14ui5XI3hFH7POIC+ Ens+doKjC7bJdKbop8yjx1FL34Hdce7+GqPw3QEgmKaldJWE+Ptkad0CzUaPxNUOiotw HSwnm8TJWZtgeWnSGTI9Z6tZnDMP0Jbn0mjPgqt2NlSt3oaXMcm1F7JmKqjDgBmi5fnJ 1S79OH/SIUXqmBUW8KDSqV2o6l+4QVmsiA658QTCn9IUmpEaYRlLPP+1c5d1eNAOslZQ XLGDdLqAwcTcT8VUorgrTdB8UmyfQqwzbP3P6VgwIyq96nsfsJEywjZ9sRto/wOMxc/w 85pw== X-Forwarded-Encrypted: i=1; AJvYcCVjl3ECqPc2ve01QJ2xqMktYq2Jcq7gejoTsT6UxBAxYSp+PnRQ0HUEaxjflxEOL9drziGidW8Xaa0swzyYGqg=@freebsd.org, AJvYcCVpEiW3WLdPcpKg7qnVUhLgEsDfSTuC/AWwY6xUcvHc9VnPwvRfXQWIrvib+vgeT+f+jBA2VS5CcEguGm99cctCUDZa@freebsd.org, AJvYcCXGxj2b/5bGxLsmZdYN2iUpB7fT377J/D798y51B07h8rQ8wiVf0CFUoiuzhcibRRkNSU6//Jg+RJp/afsTw2Li+hL0d4E=@freebsd.org X-Gm-Message-State: AOJu0YyQeiwRly6MMHYZTQOtILBj5vmTim+JSnfFqPbeQrxyGC1mvNCD LKMBtnmRQa79+KjPCZm90p208hcgcv17ZBiAIgczomZ+Kborcdjb05L7mV4Ung== X-Gm-Gg: ASbGncu4beIcTm5zjlC36b/xuJ2X+veEfeDsx948AjlFGy6ry/sHb7aWQ73Pe3Yj4an X7miyXaj0GZ4H3k8LssiuvuXr/MshI/Y+oscKflQJFLmU4HPiXT4fGniEoPPqS0gkKQK9g5EMPW j5uQqgdI+inmNQAf81cCGJMyFueQNJL1CvXfeRiqOIGUcOj1ep8EvavPCZY5uET3v3VIW8Nrpzq ZjWAEoqYrJvchpeD6WTxDimbYA2G/91tKPPi+sSH7Hssihk8O8bDaENNP03VmHHsY7EpsXcfoE1 WMJg+2PKILuQ0xIsS2ReVdN1NZj6OF2qyBS2eiy2EO+75SzZQOBshcAV+f/R0slGDllzVpPXVee cIxW5TRxsVonQZFmXZIw71LPQz1zqS8GBfBhnjdtr X-Google-Smtp-Source: AGHT+IHKM4cc/1KWdkDfU8AjNDB9cNHNnTu1WT/SQyJiSbrK/xan7kfUHaqaBOsAjqVQZ3aSCE+kMA== X-Received: by 2002:a17:902:db0c:b0:240:483:dc3a with SMTP id d9443c01a7336-2462edee860mr17168775ad.12.1755822830331; Thu, 21 Aug 2025 17:33:50 -0700 (PDT) Received: from smtpclient.apple ([45.90.222.128]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2462b0c0227sm8827925ad.167.2025.08.21.17.33.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Aug 2025 17:33:49 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_11820322-8EBB-4AA7-960D-2DE1F9810512"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: git: 267f8c1f4b09 - main - crypto/openssl: make vendor imports easier/less error prone From: "Enji Cooper (yaneurabeya)" In-Reply-To: <39A8B2D8-49D9-4303-A74A-23FB38B867CC@freebsd.org> Date: Thu, 21 Aug 2025 17:33:38 -0700 Cc: Enji Cooper , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Message-Id: References: <202508211705.57LH50gR095150@gitrepo.freebsd.org> <39A8B2D8-49D9-4303-A74A-23FB38B867CC@freebsd.org> To: Jessica Clarke X-Mailer: Apple Mail (2.3826.700.81) X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4c7Lln01mzz3Nsn --Apple-Mail=_11820322-8EBB-4AA7-960D-2DE1F9810512 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Aug 21, 2025, at 2:07=E2=80=AFPM, Jessica Clarke = wrote: >=20 > On 21 Aug 2025, at 18:05, Enji Cooper wrote: >>=20 >> The branch main has been updated by ngie: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D267f8c1f4b09431b335d5f48d8458604= 7471f978 >>=20 >> commit 267f8c1f4b09431b335d5f48d84586047471f978 >> Author: Enji Cooper >> AuthorDate: 2025-08-01 04:03:33 +0000 >> Commit: Enji Cooper >> CommitDate: 2025-08-21 17:02:46 +0000 >>=20 >> crypto/openssl: make vendor imports easier/less error prone >>=20 >> This change adds a custom BSD makefile containing multiple = high-level PHONY >> targets, similar to targets provided by the ports framework. >>=20 >> The Makefile does the following: >> - Reruns Configure with a deterministic set of arguments to ensure = that >> all appropriate features have been enabled/disabled in OpenSSL. >> - Preens the pkgconfig files to remove duplicate paths in their >> `CFLAGS` and `includedir` variables. >> - Rebuilds all ASM files to ensure that the content contained is = fresh. >> - Rebuilds all manpages to ensure that the content contained in the >> manpages is fresh. >>=20 >> Some additional work needs to be done to make the manpage = regeneration >> "operation" reproducible (the date the manpages were generated is >> embedded in the files). >>=20 >> All dynamic configuration previously captured in >> `include/openssl/configuration.h` and `include/crypto/bn_conf.h` = has been >> moved to `freebsd/include/dynamic_freebsd_configuration.h` and >> `freebsd/include/crypto/bn_conf.h`, respectively. This helps >> ensure that future updates don't wipe out FreeBSD customizations to >> these files, which tune behavior on a per-target architecture = basis, e.g., >> ARM vs x86, 32-bit vs 64-bit, etc. >>=20 >> MFC after: 1 month >> Differential Revision: https://reviews.freebsd.org/D51663 >=20 > Something in this breaks building on macOS (where, as of recently, we > build libcrypto as a bootstrap library for use by the certctl = bootstrap > tool): >=20 > = /Users/runner/work/freebsd-src/freebsd-src/crypto/openssl/crypto/bio/bio_s= ock2.c:64:9: error: call to undeclared function 'ktls_enable'; ISO C99 = and later do not support implicit function declarations = [-Wimplicit-function-declaration]=20 > ktls_enable(sock);=20 > ^=20 > = /Users/runner/work/freebsd-src/freebsd-src/crypto/openssl/crypto/bio/bio_s= ock2.c:202:5: error: call to undeclared function 'ktls_enable'; ISO C99 = and later do not support implicit function declarations = [-Wimplicit-function-declaration]=20 > ktls_enable(sock);=20 > ^=20 > 2 errors generated.=20 > --- bio_sock2.o ---=20 > *** [bio_sock2.o] Error code 1 >=20 > Presumably you need a BOOTSTRAPPING check somewhere. It looks like the problem is MacOS doesn=E2=80=99t support KTLS and now = KTLS has been fixed on FreeBSD. MK_OPENSSL_KTLS needs to be disabled when doing =E2=80=9Cmake = bootstrapping=E2=80=9D on MacOS. Cheers, -Enji= --Apple-Mail=_11820322-8EBB-4AA7-960D-2DE1F9810512 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAminuuIACgkQGpE5DjPs NJjQeg//REkxiPADMgMx2P4IQl4y2+nk8ZNRA2oNg7dlExpP3/8U6UUiht+34+PU W7Gj9HDNDHIeNa8gFJtNG+oe9+ILkgK323bO6csspAMhMXzOuW9v6Br3KuXoZMFE jDbyR9L4Yhje5R8ZJKZhaYT6v474vRykk77CulBBr9+sSgTHGn9Qdbbp8S7fTa2D AZ1466rwmTjNut+VQut6XPj1smncP2bUZFEnwZSGvpy7G2y9zhWAVN1S7n9bzPLE T6rTXEdINbEx6DpmZnngmzz2DmNCbXPfDnOjaLVYG6I3J44H05pLFk+7djuLkiWf gtn8OP3DisGZDPhG82Ql8FeCv7Dobw+WyRipb6SQaMqV7zX5MhiBzM/Hci08Hio2 HAV5MpjHzho4bID3QQkvPT5v271txk6B+BGc7M9750gMXkz54d6LkkKzqvXEX9oM RPtemlbMbfEfjXKnnjwFVObiVfVrj4Il4BfnwehbneKFmYVeE3O3hXNbpQZcoi9n t1Q0Jkb6ZgDi/1nQFFMEYU7xjohqsJ6eRs8FoJejRzVnV/T4gAhRCchIRRtE6KK6 uZNns2gP7cE3BI4i8bp9E5FwO5NPlsf+PZAFTN5rI+whG9bHdaMeJ+jOy6UZ4OB1 tL8MMf/ZehvrRVZsz+XqKZ4lOFLM6hlieit1E7qVpZ/cBaJqVig= =xh3n -----END PGP SIGNATURE----- --Apple-Mail=_11820322-8EBB-4AA7-960D-2DE1F9810512--