From nobody Thu Aug 21 14:08:31 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c74t92DnFz64xfM; Thu, 21 Aug 2025 14:08:33 +0000 (UTC) (envelope-from ziaee@FreeBSD.org) Received: from mailtransmit04.runbox.com (mailtransmit04.runbox.com [IPv6:2a0c:5a00:149::25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4c74t91PNfz3xRK; Thu, 21 Aug 2025 14:08:33 +0000 (UTC) (envelope-from ziaee@FreeBSD.org) Authentication-Results: mx1.freebsd.org; none Received: from mailtransmit03.runbox ([10.9.9.163] helo=aibo.runbox.com) by mailtransmit04.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1up5xv-006xnZ-RW; Thu, 21 Aug 2025 16:08:31 +0200 Received: from [10.9.9.129] (helo=rmmprod07.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1up5xv-0003wR-BQ; Thu, 21 Aug 2025 16:08:31 +0200 Received: from mail by rmmprod07.runbox with local (Exim 4.86_2) (envelope-from ) id 1up5xv-0005kE-9z; Thu, 21 Aug 2025 16:08:31 +0200 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Received: from [Authenticated alias (960477)] by runbox.com with http (RMM6); Thu, 21 Aug 2025 14:08:31 GMT From: "Alexander Ziaee" To: "Zhenlei Huang" CC: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 458ac2b6e445 - main - umb.4: Improve synposis, add netmap Date: Thu, 21 Aug 2025 14:08:31 +0000 (UTC) X-RMM-Aliasid: 960477 X-Mailer: RMM6 In-Reply-To: <97B579B6-654E-45EF-9F48-6D6BC39262B6@FreeBSD.org> Message-Id: X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:50304, ipnet:2a0c:5a00::/29, country:NO] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4c74t91PNfz3xRK On 2025-08-20 23:21 -04:00 EDT, "Zhenlei Huang" wrote: > Hi Alexander, >=20 > I'd presume umb(4) does not depends on netmap. A quick search of DEV_NETM= AP >=20 > ``` > #ifdef DEV_NETMAP > static void umb_input(if_t , struct mbuf *); > #endif > ... > #ifdef DEV_NETMAP > if_setinputfn(ifp, umb_input); > #endif > ``` >=20 > I think the #ifdef can be removed. I currently do not have that hardware = so I'd appreciate if someone can test it. I didn't get that far myself, this commit was partially in response to comm= ent 67 [0] on the original bug where a user got the driver working on FreeB= SD 14 by adding `device netmap` to their kernconf, and it didn't work witho= ut that. Should we send this to khorben? [0] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263783#c67 Best, Alex >=20 > Best regards, > Zhenlei >=20 >> On Aug 21, 2025, at 9:50 AM, Alexander Ziaee wrote: >>=20 >> The branch main has been updated by ziaee: >>=20 >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D458ac2b6e4452acc1a614352c= 8945ecc37667aa0 >>=20 >> commit 458ac2b6e4452acc1a614352c8945ecc37667aa0 >> Author: Alexander Ziaee >> AuthorDate: 2025-08-20 14:45:08 +0000 >> Commit: Alexander Ziaee >> CommitDate: 2025-08-21 01:48:13 +0000 >>=20 >> umb.4: Improve synposis, add netmap >>=20 >> Rewrite synopsis in a more consistent style, and add "device netmap", >> In FreeBSD 15, netmap is included in GENERIC/{amd64,arm64,powerpc64}, >> but it still needs to be used in FreeBSD 14 or custom kernels which >> don't include GENERIC. >>=20 >> MFC after: umb does not mfc >> Reviewed by: gbe >> Differential Revision: https://reviews.freebsd.org/D51732 >> --- >> share/man/man4/umb.4 | 28 ++++++++++++++-------------- >> 1 file changed, 14 insertions(+), 14 deletions(-) >>=20 >> diff --git a/share/man/man4/umb.4 b/share/man/man4/umb.4 >> index 7ecc9a39c1ca..311a50faf8e7 100644 >> --- a/share/man/man4/umb.4 >> +++ b/share/man/man4/umb.4 >> @@ -17,34 +17,34 @@ >> .\" >> .\" $NetBSD: umb.4,v 1.4 2019/08/30 09:22:17 wiz Exp $ >> .\" >> -.Dd May 11, 2025 >> +.Dd August 4, 2025 >> .Dt UMB 4 >> .Os >> .Sh NAME >> .Nm umb >> .Nd USB Mobile Broadband Interface Model (MBIM) cellular modem driver >> .Sh SYNOPSIS >> -To compile this driver into the kernel, >> -place the following lines in your >> -kernel configuration file: >> -.Bd -ragged -offset indent >> +.Cd "device netmap" >> .Cd "device usb" >> .Cd "device umb" >> -.Ed >> .Pp >> -Alternatively, to load the driver as a >> -module at boot time, place the following line in >> +In >> .Xr loader.conf 5 : >> -.Bd -literal -offset indent >> -umb_load=3D"YES" >> -.Ed >> -.Pp >> -If neither of the above is done, the driver will automatically be loaded >> -by devd(8) when the device is connected. >> +.Cd umb_load=3D"YES" >> .Sh DESCRIPTION >> The >> .Nm >> driver provides support for USB MBIM devices. >> +If the appropriate hardware is detected, >> +the driver will be loaded automatically by >> +.Xr devmatch 8 . >> +To load the driver manually, >> +.Cm load >> +it in >> +.Xr loader.conf 5 >> +or at the >> +.Xr loader 8 >> +prompt. >> .Pp >> MBIM devices establish connections via cellular networks such as >> GPRS, UMTS, and LTE. >=20 >=20 >=20 >=20=