Re: git: b44cc1b479fe - main - loader: do not try to open directories with TFTP

Reply: Warner Losh : "Re: git: b44cc1b479fe - main - loader: do not try to open directories with TFTP"
In reply to: Toomas Soome : "Re: git: b44cc1b479fe - main - loader: do not try to open directories with TFTP"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Bjoern A. Zeeb <bz_at_FreeBSD.org>
Date: Thu, 21 Aug 2025 07:02:50 UTC

On Thu, 21 Aug 2025, Toomas Soome wrote:

>> shot in the dark (haven't checked that LOADER_NET_SUPPORT would be defined for these files):
>
>
> I do not think it is the approach you want to take there, because this means you would need to build all those variants to build different components…
>
> I would think of having weak is_tftp() implementation returning false for case the dev_net.c is not built or move dev_net.c into libsa. I’m not quite sure why dev_net.c is outside libsa anyhow;)

Even just moving is_tftp into stand.h would work.

-- 
Bjoern A. Zeeb                                                     r15:7