From nobody Thu Aug 21 03:21:15 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c6pWR4dGgz65gdx; Thu, 21 Aug 2025 03:21:23 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c6pWR3Kwvz3S02; Thu, 21 Aug 2025 03:21:23 +0000 (UTC) (envelope-from zlei@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755746483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1ktDTAoIqMYxvmh71dqL8NdrDcOS+0XCOn3TCbyn9+A=; b=ASDFj+SJxL8WxwiMd7YklhqGIvhdcdUp23extrxFslN0gf4DcvUz0MpQrN9/CbJDRp6FDZ /ZSHbLnaG+fPclb1N2U+39d5nGunHt+wxvk8V20XYC8Mj4izrhYi13b0uNx9vCPPiCQzQP rbu687bvQMAZ543cmgrkUrjB9PHqNYnSgyYgPhEY0G3NzRoY9Ajrj6vn56nhyTKeNwnKyg mjMGa/ZsXrAHmZY3DvWgLJa/BQPXxkUt+/jzfKy6zCcwFGSkue9Tf6/HA8PO12ut5W7d9S DxnSP7PqdXdG9XpgaVjhhIXWR281FG+BEsIXfsBOV1tN87igXy7Z4dW3dM/lXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755746483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1ktDTAoIqMYxvmh71dqL8NdrDcOS+0XCOn3TCbyn9+A=; b=O4LcIWA4dfEsfVZv3kqgtTk09w/1XUsZML9vS9rd2Frrs+gfMYb0iF6uqyo+lulwZdX+nI SSTSLrOFwEHcYs2dodC1FKRAJ7x7z2HRVAskTgWMXSwsqOYTxAibcb5e7NuvEbqgJwwZTR xYyRT5aGyYcZg/A2XVsMH8s2o9b0FF8x11Rw04Rmp+itSwNFbV+tVK2AID1U25Vpo2WiiT RfZx6BI94Aqh5IU6O65h6yifUWCZQ52iFyo1hB98CMDAjGGZWWxek98BSTmwJbNRsOKAZY 0TzpBx+f7q9XK3MbWy+yK3X5gkHWjt2iUNglhCMymCUJGnwgZMoY6ketfC34Uw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1755746483; a=rsa-sha256; cv=none; b=uWHH0NtAs57OkFVSSX3JpXCtfJDmCZ41U+AUt5EdGTHT1CI3aiGe9F+OXGTngfAH2gWZIq VkgvPWgLDx5RLsweALgRPWwU2d7xyIbSuxYYckqxACW9iki5d8tKwfKR6QFnwkPZLZEULX kxfI7eOykkRrtNbaGQwziIKFG3GGhOJOrftGSMidiiuIbq049W6o5PxL1rprlIZjllslGn 7CtuG6iUFrxlUlx1HGzWeXpTmQQyw9nxB3cuLHJIdFGKqLEddyDuGZlf7m6HWTVsoP/8Er H/uk9yB6GYcKBw8MX3uH6pgs4NDpC68zgeqysKqLQhmJJ8gJ0gcyntDcG2B1Lw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from smtpclient.apple (ns1.oxydns.net [45.32.91.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: zlei/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4c6pWQ1Snvz14bw; Thu, 21 Aug 2025 03:21:21 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.10\)) Subject: Re: git: 458ac2b6e445 - main - umb.4: Improve synposis, add netmap From: Zhenlei Huang In-Reply-To: <202508210150.57L1oUwr063301@gitrepo.freebsd.org> Date: Thu, 21 Aug 2025 11:21:15 +0800 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <97B579B6-654E-45EF-9F48-6D6BC39262B6@FreeBSD.org> References: <202508210150.57L1oUwr063301@gitrepo.freebsd.org> To: Alexander Ziaee X-Mailer: Apple Mail (2.3696.120.41.1.10) Hi Alexander, I'd presume umb(4) does not depends on netmap. A quick search of = DEV_NETMAP ``` #ifdef DEV_NETMAP static void umb_input(if_t , struct mbuf *); #endif ... #ifdef DEV_NETMAP if_setinputfn(ifp, umb_input); #endif ``` I think the #ifdef can be removed. I currently do not have that hardware = so I'd appreciate if someone can test it. Best regards, Zhenlei > On Aug 21, 2025, at 9:50 AM, Alexander Ziaee = wrote: >=20 > The branch main has been updated by ziaee: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D458ac2b6e4452acc1a614352c8945ecc= 37667aa0 >=20 > commit 458ac2b6e4452acc1a614352c8945ecc37667aa0 > Author: Alexander Ziaee > AuthorDate: 2025-08-20 14:45:08 +0000 > Commit: Alexander Ziaee > CommitDate: 2025-08-21 01:48:13 +0000 >=20 > umb.4: Improve synposis, add netmap >=20 > Rewrite synopsis in a more consistent style, and add "device = netmap", > In FreeBSD 15, netmap is included in = GENERIC/{amd64,arm64,powerpc64}, > but it still needs to be used in FreeBSD 14 or custom kernels which > don't include GENERIC. >=20 > MFC after: umb does not mfc > Reviewed by: gbe > Differential Revision: https://reviews.freebsd.org/D51732 > --- > share/man/man4/umb.4 | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) >=20 > diff --git a/share/man/man4/umb.4 b/share/man/man4/umb.4 > index 7ecc9a39c1ca..311a50faf8e7 100644 > --- a/share/man/man4/umb.4 > +++ b/share/man/man4/umb.4 > @@ -17,34 +17,34 @@ > .\" > .\" $NetBSD: umb.4,v 1.4 2019/08/30 09:22:17 wiz Exp $ > .\" > -.Dd May 11, 2025 > +.Dd August 4, 2025 > .Dt UMB 4 > .Os > .Sh NAME > .Nm umb > .Nd USB Mobile Broadband Interface Model (MBIM) cellular modem driver > .Sh SYNOPSIS > -To compile this driver into the kernel, > -place the following lines in your > -kernel configuration file: > -.Bd -ragged -offset indent > +.Cd "device netmap" > .Cd "device usb" > .Cd "device umb" > -.Ed > .Pp > -Alternatively, to load the driver as a > -module at boot time, place the following line in > +In > .Xr loader.conf 5 : > -.Bd -literal -offset indent > -umb_load=3D"YES" > -.Ed > -.Pp > -If neither of the above is done, the driver will automatically be = loaded > -by devd(8) when the device is connected. > +.Cd umb_load=3D"YES" > .Sh DESCRIPTION > The > .Nm > driver provides support for USB MBIM devices. > +If the appropriate hardware is detected, > +the driver will be loaded automatically by > +.Xr devmatch 8 . > +To load the driver manually, > +.Cm load > +it in > +.Xr loader.conf 5 > +or at the > +.Xr loader 8 > +prompt. > .Pp > MBIM devices establish connections via cellular networks such as > GPRS, UMTS, and LTE.