From nobody Wed Aug 20 13:54:24 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c6T4J0mqgz64VTL; Wed, 20 Aug 2025 14:15:12 +0000 (UTC) (envelope-from mm@FreeBSD.org) Received: from www541.your-server.de (www541.your-server.de [213.133.107.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4c6T4H3klLz3bHw; Wed, 20 Aug 2025 14:15:11 +0000 (UTC) (envelope-from mm@FreeBSD.org) Authentication-Results: mx1.freebsd.org; none Received: from sslproxy04.your-server.de ([78.46.152.42]) by www541.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1uojGj-0003UG-2I; Wed, 20 Aug 2025 15:54:25 +0200 Received: from localhost ([127.0.0.1]) by sslproxy04.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uojGj-0003OH-0a; Wed, 20 Aug 2025 15:54:24 +0200 Message-ID: <2a9986a5-77c0-406f-8e86-a4e853229ff4@FreeBSD.org> Date: Wed, 20 Aug 2025 15:54:24 +0200 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 53a2e2635ab2 - main - zfs: merge openzfs/zfs@a9410ccbd To: John Baldwin , =?UTF-8?Q?Dag-Erling_Sm=C3=B8rgrav?= Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202508200901.57K91hlO061803@gitrepo.freebsd.org> <86plcqhzv5.fsf@ltc.des.dev> Content-Language: en-US From: Martin Matuska Autocrypt: addr=mm@FreeBSD.org; keydata= xsDNBGOTSakBDADYnE8uP/uR+viUTGNdMG8tWtoopvEEACFOwqx6NPb9sXvip5z20ochmO+j NqbV+OiS/6gjpd2f2fmJ241ooqbqZrWklabohbr2ros25bmi1C/77FEKsGulay334p1LXPxQ A3kjEQSINMresnt8FYCO5q50VHgmnhSNaom8jPAy9S06fWqPyXAXoJ53hwzYN6Bgb2CnU5FT wC9O4v5sI4wjQYq5JC9cbl1hM5PzC5bIse79l5NqYTsSuSY2RhOQ7w6L6V295l7C6TPkPBcq kg4Q+AYzdTTZagMN9NcchembtR/aMbuExg1PiUMdPOu99uW605XikwwYTy0ZGlz7GZE9Ecpo BaoSX5m3haM5k59e5839YtnCVbS0XOLCDp8uPMbLElGsLH6J1f1RxxV+h4r6ZypDSC0vTi54 qI1nxsdJm1n21iwQ0zP77oLUaIc+Nb0Mmh61+YFPLMgeHlfEsnsYzTWJU/tt6rlFFECKSlBG kiIXy1IeyKx2D+OlCZJ7FQMAEQEAAc0fTWFydGluIE1hdHVza2EgPG1tQEZyZWVCU0Qub3Jn PsLBFAQTAQoAPhYhBNssfPG0wmX671bj/FhIoYuPFBhLBQJjk0mpAhsDBQkFo5qABQsJCAcC BhUKCQgLAgQWAgMBAh4BAheAAAoJEFhIoYuPFBhLbPkMAM3tMymnbjprFzY1hhPOYczWI3f0 QREf+BdPt2X5325j2LV09mu3O4uiH/JBfzPc/9Z5HZzNJFaGTGpnhHrihiI6rZUDVon1CikU oiIMDWbNOMO+4WK6FVHTjziDFd/g3ql5WESgZm9SEtpHWfgvnKQAbAovKrA5CrAr8FePENKA zjlsJaEiYTrK7HrI2s5hMZkDQixFKFGgNuZe89k8HEy9ARrxGfMj1CrFtlHXts0K3hVFhdRS kPW8BxwlwuXVQYrXY5Ih6+5R2/XtjTkNrgg6EYfP11eyiN4Vfi5LuHUmwZkVXg7tfJWmcXmr Cpi6Q39JxiDZAkiSb8izebYBXHnzGHa3CgV8F7DqogO2e5a3MqUio6UVJPmeFIJogCgaJUMS KxcxjVl99Qmy6Boorpy58LDXp1T0Lcp7PhNqnmPW+Qh0/KUvuLrfWDtSc2+mL/llrEAHfIHT QbQsqpNEaOpEBpecIO5cDz1ussX/AurCw5E7DoHWJD87IOFM9LTPqM7AzQRjk0mpAQwAuz9d wJX5d7fhMD945bJDhB6ps0x2M0HFdbeClqkIbmkwq2Ws396XJhM8kd5qzrdVZZjJYSGl9vni AhLJk6uTBTZLqRG01LDh0AMsNsyN9yUH4QwqQXeui+GUHPnjzc8LkNvDgpUi9k+B1ZsDNQRE F7Jc6U3afkRCNwpym4CVeWBHhm032fU+jlKALKMlu58gHECGj4SbVChf6Gd7h4Z8p/yjx94d sqJsGog2PnwakLPKjIMNDg1X6BHFTcBHzmnaM0mtKsUQuHtmcctNC8TUP1v8NGFEcOyFNFOI BUcauUK+EhAvU2ew6qplTPjO/TcKw/Mw1++DGXDyu+3VIgBl5wIv3HPo/nNVvSy9Wrz1JztL kBjvFDtiEx/5+4baKGkkUwAQEALKlyqcuPSl0bVxmK93Hs/DgZ3+xqDm5SJGP6bI/M6jkul9 tTxpyYYSh6Z1k6w7Vc7UAEkU6FcdjpzIuAPGTuxC+eU7a1O7Wq/A/MpKvRdfox+pSC0fCQQt KcRVABEBAAHCwPwEGAEKACYWIQTbLHzxtMJl+u9W4/xYSKGLjxQYSwUCY5NJqQIbDAUJBaOa gAAKCRBYSKGLjxQYS04fC/4uG3TaACwvF2qgyzmAGEL+NjYowmHH+OuEJ4i91lYBmIEn3CyW omRuHAXq023/HUFjylqbiPl6cuQsJbLKnfCbRBaIkwTQ3f603lAwWk7mQxsXKAIIhdI536R+ sDXEV9C3zjQtNXWvO+n5hbxJgEWNa1qdbgrj0Ltx7Bpxltj7PCxZn8VXVtsRkacHuUvSGLA6 Jd+ObGDR9WUSMvLtu3/ynEnrDjBCybvxriXcPY6jW7H3spxv7KYm8AGYbtctz3S4tskUGJJv HFtVxu8fHnmQa0TO2035jMm45MOBcegVcvjAxOzJWWTMLDWb+pa5brw87tG1daXgLVpror/E LaOCIVPwjCmmQQg15vaUjL3qLI48oP43OhwcEJxvHhZ/3Je57zHwGm2vk/O/UbjbbJEu/g30 d1vd9IAuzUUKNUkW6i/cU+OkrPpiHJjS8uM81xip6FCmG0WzStrz46S6lw0GIBiw9SUwaEVB qQ/GkSXj8gzl2fLRiu1O5gkB2sgdcMs= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: Clear (ClamAV 1.0.7/27738/Wed Aug 20 10:28:17 2025) X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:24940, ipnet:213.133.96.0/19, country:DE] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4c6T4H3klLz3bHw Hi I have committed a fix one minute before Dag's email. I don't understand why my make universe on a amd64 with a clean obj could pass without that fix. On 20. 8. 2025 15:50, John Baldwin wrote: > On 8/20/25 09:44, Dag-Erling Smørgrav wrote: >> Martin Matuska writes: >>>      zfs: merge openzfs/zfs@a9410ccbd >> >> This doesn't build, please either fix asap or revert. >> >>      cc -target x86_64-unknown-freebsd15.0 >> --sysroot=/usr/obj/usr/src/amd64.amd64/tmp >> -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin -O2 -pipe -fno-common >> -DIN_BASE -I/usr/src/sys/contrib/openzfs/include >> -I/usr/src/sys/contrib/openzfs/lib/libspl/include >> -I/usr/src/sys/contrib/openzfs/lib/libspl/include/os/freebsd >> -I/usr/src/sys/contrib/openzfs/lib/libzpool/include >> -I/usr/src/cddl/compat/opensolaris/include >> -I/usr/src/sys/contrib/openzfs/module/icp/include -include >> /usr/src/sys/contrib/openzfs/include/os/freebsd/spl/sys/ccompile.h >> -DHAVE_ISSETUGID -include /usr/src/sys/modules/zfs/zfs_config.h -g >> -DDEBUG=1 -Wno-format -DZFS_DEBUG=1 -DNEED_SOLARIS_BOOLEAN >> -DHAVE_STRLCAT -DHAVE_STRLCPY -fPIE -g -gz=zlib -std=iso9899:1999 >> -Wno-format-zero-length -fstack-protector-strong -Wsystem-headers >> -Werror -Wall -Wno-format-y2k -Wno-uninitialized -Wno-pointer-sign >> -Wdate-time -Wno-unknown-pragmas -Wno-empty-body -Wno-string-plus-int >> -Wno-unused-const-variable -Wno-error=unused-but-set-parameter >> -Wno-error=cast-function-type-mismatch -Wno-tautological-compare >> -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function >> -Wno-enum-conversion -Wno-unused-local-typedef >> -Wno-address-of-packed-member -Wno-switch -Wno-switch-enum >> -Wno-knr-promoted-parameter -Qunused-arguments  -Wl,-zrelro -pie    >> -o ztest.full ztest.pieo   -lgeom  -lm  -lnvpair -lumem  -lzpool   >> -lavl  -lzfs_core  -lspl  -lzutil  -lzfs -luutil  -licp -lpthread >>      ld: error: undefined reference: gcm_ghash_vpclmulqdq_avx2 >>      >>> referenced by >> /usr/obj/usr/src/amd64.amd64/tmp/usr/lib/libicp.so (disallowed by >> --no-allow-shlib-undefined) >>           ld: error: undefined reference: gcm_init_vpclmulqdq_avx2 >>      >>> referenced by >> /usr/obj/usr/src/amd64.amd64/tmp/usr/lib/libicp.so (disallowed by >> --no-allow-shlib-undefined) >>           ld: error: undefined reference: aes_gcm_enc_update_vaes_avx2 >>      >>> referenced by >> /usr/obj/usr/src/amd64.amd64/tmp/usr/lib/libicp.so (disallowed by >> --no-allow-shlib-undefined) >>           ld: error: undefined reference: aes_gcm_dec_update_vaes_avx2 >>      >>> referenced by >> /usr/obj/usr/src/amd64.amd64/tmp/usr/lib/libicp.so (disallowed by >> --no-allow-shlib-undefined) >>      cc: error: linker command failed with exit code 1 (use -v to see >> invocation) >>      *** Error code 1 >>           Stop. >>      make[5]: stopped making "all" in /usr/src/cddl/usr.bin/ztest > > Probably just needs the new file added to SRC in our bespoke build glue? > > However, it does raise the question of how this was tested (during > code slush > no less)? >