From nobody Wed Aug 20 08:11:51 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c6K1M03H2z64ZGR; Wed, 20 Aug 2025 08:12:07 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4c6K1L3SQRz3dvg; Wed, 20 Aug 2025 08:12:06 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 57K8BqZe035943; Wed, 20 Aug 2025 11:11:55 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 57K8BqZe035943 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 57K8Bp3P035942; Wed, 20 Aug 2025 11:11:51 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 20 Aug 2025 11:11:51 +0300 From: Konstantin Belousov To: Aymeric Wibo Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 75acf71786f2 - main - libifconfig: Remove ifconfig_set_fib and ifconfig_sfp_id_is_qsfp Message-ID: References: <202508192309.57JN9cNK038457@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202508192309.57JN9cNK038457@gitrepo.freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on tom.home X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4c6K1L3SQRz3dvg On Tue, Aug 19, 2025 at 11:09:38PM +0000, Aymeric Wibo wrote: > The branch main has been updated by obiwac: > > URL: https://cgit.FreeBSD.org/src/commit/?id=75acf71786f201093b76f45eff03a8665fb79a72 > > commit 75acf71786f201093b76f45eff03a8665fb79a72 > Author: Muhammad Saheed > AuthorDate: 2025-08-19 23:06:53 +0000 > Commit: Aymeric Wibo > CommitDate: 2025-08-19 23:07:15 +0000 > > libifconfig: Remove ifconfig_set_fib and ifconfig_sfp_id_is_qsfp > > Remove the declaration of ifconfig_set_fib from libifconfig.h as it had > no definition. > > ifconfig_sfp_id_is_qsfp is defined as a static header function in > libifconfig_sfp.h and doesn't generate a symbol. > > Both have been removed from Symbol.map. > > Reviewed by: obiwac, mckusick (mentor) > Approved by: obiwac, mckusick (mentor) > Sponsored by: Google LLC (GSoC) > Differential Revision: https://reviews.freebsd.org/D50666 > --- > lib/libifconfig/Symbol.map | 2 -- > lib/libifconfig/libifconfig.h | 1 - > 2 files changed, 3 deletions(-) > > diff --git a/lib/libifconfig/Symbol.map b/lib/libifconfig/Symbol.map > index 2d80fb31652a..2e11ff963909 100644 > --- a/lib/libifconfig/Symbol.map > +++ b/lib/libifconfig/Symbol.map > @@ -40,7 +40,6 @@ FBSD_1.6 { > ifconfig_open; > ifconfig_set_capability; > ifconfig_set_description; > - ifconfig_set_fib; > ifconfig_set_metric; > ifconfig_set_mtu; > ifconfig_set_name; > @@ -81,7 +80,6 @@ FBSD_1.6 { > ifconfig_sfp_fc_speed_symbol; > ifconfig_sfp_id_description; > ifconfig_sfp_id_display; > - ifconfig_sfp_id_is_qsfp; > ifconfig_sfp_id_symbol; > ifconfig_sfp_rev_description; > ifconfig_sfp_rev_symbol; This breaks the ABI, of course. Or, it makes no sense to have the overhead of symbol versioning if it is fine to break the ABI. Symbol removal should have resulted in the library version bump.