Re: git: 5105e1ebecc7 - main - krb5: Fix the installed compile_et

From: Mark Johnston <markj_at_freebsd.org>
Date: Tue, 19 Aug 2025 17:42:20 UTC 
On Tue, Aug 19, 2025 at 08:33:49PM +0300, Dima Panov wrote:
> Hello!
> 
> On 19.08.2025 16:20, Mark Johnston wrote:
> > diff --git a/krb5/Makefile.inc b/krb5/Makefile.inc
> > index cd54f7a0eff6..6db4e8d964aa 100644
> > --- a/krb5/Makefile.inc
> > +++ b/krb5/Makefile.inc
> > @@ -14,7 +14,7 @@ KRB5_VERSION=	1.22-final
> >   # MIT KRB5 uses KRB5_DIR. Heimdal uses KRB5DIR.
> >   KRB5_SRCTOP=	${SRCTOP}/krb5
> >   KRB5_DIR=	${SRCTOP}/crypto/krb5/src
> > -KRB5_ETDIR?=	${DESTDIR}/usr/share/et
> > +KRB5_ETDIR?=	/usr/share/et
> >   KRB5_SRCLIBDIR=	${KRB5_DIR}/lib
> >   KRB5_OBJTOP=	${OBJTOP}/krb5
> > diff --git a/krb5/util/et/Makefile b/krb5/util/et/Makefile
> > index 6eceb253c3b0..0d474efa1e8e 100644
> 
> 
> What the reason to omit ${DESTDIR} here?
> It will be always install by global path instead of requested destination root.

This is consistent with how we handle other utilities.  For instance,
man(1) searches /usr/share/man, not ${DESTDIR}/usr/share/man,
executables are started by /libexec/ld-elf.so.1, not
${DESTDIR}/libexec/ld-elf.so.1, etc..