Re: git: 7ac276298b72 - main - Remove Secure RPC DES authentication

On 16.08.2025 01:07, Konstantin Belousov wrote:
> On Fri, Aug 15, 2025 at 06:02:39PM +0100, Lexi Winter wrote:
>> Konstantin Belousov:
>>> The commit breaks libc ABI and must be reverted.
>>> This email is the formal request to do so.
>>   
>>> To make it clear: despite the presence of symcompat versions, there is
>>> no justification to remove the implementation.   Default version for
>>> symbols might be removed, but the implementation shall be left alone.
>>   
>> okay, done.
> Thank you.
> 
>> however, unless i removed more than i intended, none of
>> this code works since it relies on keyserv (which was removed months
>> ago), so it's basically dead code.
> It depends on what user might do with its system.
> Also, unless I mis-remember, the removal caused issues for linking xserver,
> am I right?

Yep, but a) upstream drop this code in xservers more than a year ago but it still not packed as new release b) I've already disable secure-rpc option in ports which handles this dead code.

> 
>>
>>> This is how we handle all other cases of obsoleted interfaces, gets()
>>> being the exemplary case.
>>
>> this is a little different from gets, since gets still worked even after
>> the public interface was removed.
> 
> The definition of 'worked' might vary.
> 

-- 
Sincerely,
Dima (fluffy@FreeBSD.org, https://t.me/FluffyBSD, @fluffy:matrix-dev.freebsd.org)
(desktop, kde, x11, office, ports-secteam)@FreeBSD team