From nobody Tue Aug 12 12:26:26 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c1W2W11ZPz64fwq; Tue, 12 Aug 2025 12:26:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c1W2V6vP8z3DFM; Tue, 12 Aug 2025 12:26:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755001587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4PhTLTpnl+MhabrL1CPQqKsc+YyFy9gE1eVEfRWILPg=; b=Lr1pG5WN7JO5USmRu3h97WiN+DPy6GDK2ZZhTs8cBUrj1I264iTcdMt4Sz+syuyUyjKO77 A8TG2gaOgE4lXvmCE8YFYz/FbnGqm9m4z5dLrNiT+BocQ/fGskOkdEbQyG5cMRN7fiBxlT +bUbeyTuTq2LusiBM4M70dd9yVwoGwtfBxPvjrkM287omMUGooZ3MxAt9vUMEL//JG0rxu 65wUsexUdd/wtHtzyUQoIgz/V82LpFBrmgqs7/X/Y4f9wPX0saOars205nUOK8n1WhjygB FGSdNyYkrJgKyRqQLM/JUokiVwmrdGOW93KHeo1ssP8F1mN07a991c98L5h6GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755001587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4PhTLTpnl+MhabrL1CPQqKsc+YyFy9gE1eVEfRWILPg=; b=AhFxYQPwfbXHNpNGB/SPMu7hFsXTrrE7adCwGKg+GwPNdk0dZn76b1puZEEeTlHuF1qWR7 pz61fL5kB0zQ92z7rTHHnjdch6vQbG76qCqOFjbtKIGdXa5LMUOkctNqpZQZE7al2FabIl 8OZdkAjVQ3NkeEX1H16ZbhgM5KzgJEUfel/X/WH4kCCjbhlxxKbaEHAa5GcZ6oFWcsIWZW t48W//o3YA1WTNtjA3lGCDtMGW5uzlPcVD21y1Fdck0RA8q48mA3MLJiyn6LgUtC0c9l1c xwCI4fMUu4l37IbXfOfdQBxMcs+T2d+BX7m3mnOgTSu2iAtJaGQlWn+KJuMOEg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1755001587; a=rsa-sha256; cv=none; b=TNlyqtZq5NfkB5QjJHwstu1G0wJjiWIlb0aUsJ+jb4iDb+rx7Jn9H0gFBVdNnR/vitWhYa x6X3sc6SG56zEJxjPcDSrrAwSMKdLPY1kx43w5/zarXhvuAbP3OomrtfITvtpZQgflsgu+ 682eiX9mrjui8XGhZmpyUtxttQRu3KaNa2xJrRjJLaRSgJ46oiP8sO7eWd6sV2Ldjigawo WPfjdHOL3kbkIdZ0aEdb7I7GSl8TCDCmrvnpTkrwOQXmXqbZSKL820SShKXqzbefN7AaQu GWCTN6F5NTDZn61tllj/JED5WhEJvh+V/RVmKFMp/8Gmunv6epOXm1Zhk4HQaQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4c1W2V6M7lzdk3; Tue, 12 Aug 2025 12:26:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 57CCQQt8032031; Tue, 12 Aug 2025 12:26:26 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 57CCQQPN032028; Tue, 12 Aug 2025 12:26:26 GMT (envelope-from git) Date: Tue, 12 Aug 2025 12:26:26 GMT Message-Id: <202508121226.57CCQQPN032028@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: 0312f80349ee - main - udp: use appropriate error counters List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0312f80349eedfc2b0d2f24b4fd073795148d3d5 Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=0312f80349eedfc2b0d2f24b4fd073795148d3d5 commit 0312f80349eedfc2b0d2f24b4fd073795148d3d5 Author: Michael Tuexen AuthorDate: 2025-08-12 12:24:20 +0000 Commit: Michael Tuexen CommitDate: 2025-08-12 12:24:20 +0000 udp: use appropriate error counters Since there are multicast and broadcast specific error counters, use them. Reviewed by: rrs MFC after: 1 week Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D51869 --- sys/netinet/udp_usrreq.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sys/netinet/udp_usrreq.c b/sys/netinet/udp_usrreq.c index df8f293f9426..2f2f9abf1c83 100644 --- a/sys/netinet/udp_usrreq.c +++ b/sys/netinet/udp_usrreq.c @@ -654,7 +654,11 @@ udp_input(struct mbuf **mp, int *offp, int proto) else UDP_PROBE(receive, NULL, NULL, ip, NULL, uh); UDPSTAT_INC(udps_noport); - if (m->m_flags & (M_BCAST | M_MCAST)) { + if (m->m_flags & M_MCAST) { + UDPSTAT_INC(udps_noportmcast); + goto badunlocked; + } + if (m->m_flags & M_BCAST) { UDPSTAT_INC(udps_noportbcast); goto badunlocked; }