From nobody Fri Aug 08 10:19:21 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bz0Pj6Jrmz63VZR; Fri, 08 Aug 2025 10:19:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bz0Pj3hHRz3D0D; Fri, 08 Aug 2025 10:19:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754648361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gQWauuS2/a2J1mi7SW//1TtINpyj9PHbKXNVTuwZIIY=; b=dLqbsjo/pVb4dnMCOJW9MXODWCobWzVtGyACgFAaTat0W8H43r4iE4fqoSwT64pI7e4NaO C1EkETCsjDZCw+h613MCDTErfSseB7pX/dQ4eSQVNuz1r986z5ZItriNhD+v1wWq2bCaL+ UmP11+sODUDOU2oNxZU4A6gF83p0ItfVuIrKbicg0I5wsNfElrP4LouKi9LWHuiULxeT/E 2kHiISSuZ1MuR4xadJO79D85XP0T36uEmo4hBxT7FEhQBRYqMVvZA5VrNBvH77sm9GsoUY i7in6I4kfswgdDwIFHXES59n5LK9dO5yma4e0JANErI4N9ea+IVDYJDgq1PU5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754648361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gQWauuS2/a2J1mi7SW//1TtINpyj9PHbKXNVTuwZIIY=; b=siy6obuJH3LoDwEJe2SZZBAA4FCHsoA5lj50mc+fXapNIPWZglxwvQ8HVl3Zz5rpEBTguV l5a6hex7LlJJ5gcUEr7uQSmenVwgdGZo8Fq7yJnlnap3KQKXQjTgRWKqYMJYiGv5XZBq7X bI0yDplaoD445mW3IW8XhNBzuXWAqxu4VtAaZQea56NAYkxZ9P3d0FeQj0WS8GjEdqRGd+ xcdbTkkGUvhQkei/CYmI32hiw2p5uKwOR35mE7QndeiEtqPqMsC2iInUEpUVyZ/M2ISsme pj77nUnSIOxAifmMqZgHyt9IS4cDUPHIPgh0VK6fB7zBq26n4Ow0xTFxogbfjg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1754648361; a=rsa-sha256; cv=none; b=dkDBTA0tfO606hPWjAV7DsbQztU5LXkPzrZn40kgNVmhugCcgC6rqQ2rw9zMdQm/o5dpf9 v9qiAkm5yHvPTCzb3l6gexK/EIcMykt4I37XBM1PJ2TDcGMRSUB5YmUEgs7+lJ84MqBdv4 wF3NMNSazNywuwDt+OoCVS4HPX2nWKfmYnOYw7p595BW3dkhLgSxn7VcIIpz7gsYc6gjI7 deKb55zx4Z3F2wzdf//XIbXc0pN+Gn9jMRe/ghhWv6FkEypiYpYliIzII99bXeYuE+a0Kt jQRDz8gwAUuWvVRgoHNaG9oFJUb0SnGZlMLRj4i8oGteNBArS1fk38L4K+Dwbw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bz0Pj21v5zXXk; Fri, 08 Aug 2025 10:19:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 578AJLPP060179; Fri, 8 Aug 2025 10:19:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 578AJLCh060176; Fri, 8 Aug 2025 10:19:21 GMT (envelope-from git) Date: Fri, 8 Aug 2025 10:19:21 GMT Message-Id: <202508081019.578AJLCh060176@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Zhenlei Huang Subject: git: f4744b8acb93 - main - EtherIP: Fix passing the address family from if_bridge(4) to gif(4) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f4744b8acb932fbb3e48b71d31b7cd585566b668 Auto-Submitted: auto-generated The branch main has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=f4744b8acb932fbb3e48b71d31b7cd585566b668 commit f4744b8acb932fbb3e48b71d31b7cd585566b668 Author: Zhenlei Huang AuthorDate: 2025-08-08 10:17:51 +0000 Commit: Zhenlei Huang CommitDate: 2025-08-08 10:17:51 +0000 EtherIP: Fix passing the address family from if_bridge(4) to gif(4) Given IPPROTO_IPV4, IPPROTO_IPV6 and IPPROTO_ETHERIP have different protocol numbers, then it is perfect valid to tunnel IPv4, IPv6 and Ethernet traffic over IPv[46] by the same interface. Since gif(4) has already utilized the inbound csum_data field to carry address family, also teach if_bridge(4) to do that, rather than checking if a gif(4) interface is member of a if_bridge(4) interface. Without this fix, tunnel IPv[46] over IPv[46] will not work when the gif(4) interface is member of a if_bridge(4) interface, aka the EtherIP setup, as the address family passed from gif_output() will be overwritten with the wrong one AF_LINK by gif_transmit(), and end up with incorrectly encapsulated packets. PR: 227450 Reviewed by: kp Tested by: meta Fixes: 8a0308722372 gif(4): Assert that gif_output() isn't called for EtherIP MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D51682 --- sys/net/if_bridge.c | 6 ++++++ sys/net/if_gif.c | 10 +++------- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/sys/net/if_bridge.c b/sys/net/if_bridge.c index 3aed54c58e04..1e444be93e9f 100644 --- a/sys/net/if_bridge.c +++ b/sys/net/if_bridge.c @@ -2441,6 +2441,12 @@ bridge_enqueue(struct bridge_softc *sc, struct ifnet *dst_ifp, struct mbuf *m, } M_ASSERTPKTHDR(m); /* We shouldn't transmit mbuf without pkthdr */ + /* + * XXXZL: gif(4) requires the af to be saved in csum_data field + * so that gif_transmit() routine can pull it back. + */ + if (dst_ifp->if_type == IFT_GIF) + m->m_pkthdr.csum_data = AF_LINK; if ((err = dst_ifp->if_transmit(dst_ifp, m))) { int n; diff --git a/sys/net/if_gif.c b/sys/net/if_gif.c index ef64c15074ed..272ab214a788 100644 --- a/sys/net/if_gif.c +++ b/sys/net/if_gif.c @@ -312,10 +312,7 @@ gif_transmit(struct ifnet *ifp, struct mbuf *m) goto err; } /* Now pull back the af that we stashed in the csum_data. */ - if (ifp->if_bridge) - af = AF_LINK; - else - af = m->m_pkthdr.csum_data; + af = m->m_pkthdr.csum_data; m->m_flags &= ~(M_BCAST|M_MCAST); M_SETFIB(m, sc->gif_fibnum); BPF_MTAP2(ifp, &af, sizeof(af), m); @@ -355,6 +352,8 @@ gif_transmit(struct ifnet *ifp, struct mbuf *m) break; #endif case AF_LINK: + KASSERT(ifp->if_bridge != NULL, + ("%s: bridge not attached", __func__)); proto = IPPROTO_ETHERIP; M_PREPEND(m, sizeof(struct etherip_header), M_NOWAIT); if (m == NULL) { @@ -405,9 +404,6 @@ gif_output(struct ifnet *ifp, struct mbuf *m, const struct sockaddr *dst, { uint32_t af; - KASSERT(ifp->if_bridge == NULL, - ("%s: unexpectedly called with bridge attached", __func__)); - /* BPF writes need to be handled specially. */ if (dst->sa_family == AF_UNSPEC || dst->sa_family == pseudo_AF_HDRCMPLT) memcpy(&af, dst->sa_data, sizeof(af));