From nobody Thu Aug 07 21:11:47 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4byfx01QsPz63Vy4; Thu, 07 Aug 2025 21:11:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4byfwz3jRgz46wZ; Thu, 07 Aug 2025 21:11:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754601107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uYX4es4T5OYrPEaHOEiVhYfZBgFCIr56RkDM0y/79Gs=; b=lSHEN64RwMuHJe+hfVcEvE1P6EI4Mnnln+EdUkOBxjsojzVdlsMGEgMkoeY7rdB+IikRPz +Ix2rTFZxdzRBfMHbBrnkvkYWYGFlMg76gMguh0yOGX9WcA9VPPSnxHJ131Nd8R1BoLtaA uH4KO9tiPlwWHwDm6sGlUOSjtxTCSlpbEMmf808YO4fn+5+qqFCG3GRp0Q53CLYX5ycmRj t+l6YO3KQdbU2rfr/KvjTQr2wMSdSi3fo9SHikdIk81psB6oCWtj3UHK84JSELXFkCuCHl /yTGoaMC5ryQVks1ZMV0vJCO7BlpWW6ndJV+SAImwp9UQcK/3/TWBFRA0o/nkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754601107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uYX4es4T5OYrPEaHOEiVhYfZBgFCIr56RkDM0y/79Gs=; b=ThSsYe112bt6zLg91d7kBxIoDrSjRw1hrSU5fR4RaNvfpQKyvtHzwAf6TIi+OPbaW41bvR 2WgR5PqVr0/ktCfPJ4qQNDk8VgzeJssOEq8+Lv1ze0O7AwnnaAtQzvD5tsuIl2TmmshKAg d5qm0sbSECXvbcr6wyfTBdtJKZTpPudYA5KMlFSGKdsKfL0LyGoby9fCqe1gXRUmRX+TCM x6Y4uSl0E0SbiTxekkykkx3nGSbuzlbAapuF6YGyQqaUSZwRiaBgobpLE8qVbdIfN8vCrQ 7UB0Wvh+DfAoSwGlbHHIeNFZOPj2vTu7MaiGVw40Onhy/ZUdKWndTsOGYxswDg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1754601107; a=rsa-sha256; cv=none; b=HoN6LdwIJUdutgEF/1C/3c/iZ7p9jZ8ljGLQi5uDWT2evbrGiderWyxncyJYwKPrWskMRZ FuPqijW7tjmAo/OQvKF0NzP8lq+gB70Px8BoDi/n9rjvmPzZag8pT6KQwzEnvtkYoG2GaD f3Mua3k7XdsfzYRAsgqsh1TQqmOyIBpkWsS2qkn10JGcAcWUltPGXCuYrPH9NjYY2NhEJC JBCNx3Bm85ACEDZQjwEHv7dOOg0xjZr65fm4G4St/bVVg6rwxaw5JECRn5h78t9vJX1xdh fxImfoNpicQ7pS417L1mvZHKCzfZHXC1Ze18+oq/NXYrhXqKQgLeJo3HHH0riA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4byfwz3F3Kz1MK2; Thu, 07 Aug 2025 21:11:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 577LBlxF094775; Thu, 7 Aug 2025 21:11:47 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 577LBl8R094772; Thu, 7 Aug 2025 21:11:47 GMT (envelope-from git) Date: Thu, 7 Aug 2025 21:11:47 GMT Message-Id: <202508072111.577LBl8R094772@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: ab328f4e33f8 - main - ctld: Catch exceptions by reference instead of by value List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ab328f4e33f8ba7adc7c285fd6aa74254c2e7971 Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=ab328f4e33f8ba7adc7c285fd6aa74254c2e7971 commit ab328f4e33f8ba7adc7c285fd6aa74254c2e7971 Author: John Baldwin AuthorDate: 2025-08-07 21:11:22 +0000 Commit: John Baldwin CommitDate: 2025-08-07 21:11:22 +0000 ctld: Catch exceptions by reference instead of by value Reported by: GCC -Wcatch-value Sponsored by: Chelsio Communications --- usr.sbin/ctld/conf.cc | 2 +- usr.sbin/ctld/uclparse.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/usr.sbin/ctld/conf.cc b/usr.sbin/ctld/conf.cc index ab76f8e2ed0b..56a149a58a25 100644 --- a/usr.sbin/ctld/conf.cc +++ b/usr.sbin/ctld/conf.cc @@ -466,7 +466,7 @@ parse_conf(const char *path) bool parsed; try { parsed = yyparse_conf(fp.get()); - } catch (std::bad_alloc) { + } catch (std::bad_alloc &) { log_warnx("failed to allocate memory parsing %s", path); return (false); } catch (...) { diff --git a/usr.sbin/ctld/uclparse.cc b/usr.sbin/ctld/uclparse.cc index cb3b0a17cd74..8a62636ffec6 100644 --- a/usr.sbin/ctld/uclparse.cc +++ b/usr.sbin/ctld/uclparse.cc @@ -1418,7 +1418,7 @@ uclparse_conf(const char *path) bool parsed; try { parsed = uclparse_toplevel(top); - } catch (std::bad_alloc) { + } catch (std::bad_alloc &) { log_warnx("failed to allocate memory parsing %s", path); parsed = false; } catch (...) {