From nobody Mon Aug 04 14:27:54 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bwf6L50w0z6463S; Mon, 04 Aug 2025 14:27:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bwf6L431zz3cQq; Mon, 04 Aug 2025 14:27:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754317674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JrYwRDNzKalmW+GNp0DXK0jRukIzXNpraadCRSR/Bb8=; b=SruSK4em5dfPUGxoGKpIwhva9SinR6TuthG9lr+oj2ohaTRNgx+FsEk4ZWDOaAWZVNjG4c Nh4DQQnSiOEfTCrH/1ljuA5C1TmfW1mw9dsh0+xbDbCwpmfpm8K/AXlQv6poOcE+unzOVf ca4Sn5FhA+WyCSY5WpQ9Sp+BBZ0gROsHSOF57e/U49P4OTEJh1RNPDQlIqaTKEqIgEveo2 st43NRk96qtVRpFgiMe3QaIldLdpChKK29oNAI0XLb2VEOq4OjEscKTTyRqUKi2KjV2rUR JQANw+bk+DNu1fI3F70+LlwKIAAVCjAAaQo7GKRfgMoMSxaaZ8td2ED1YM+OQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754317674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JrYwRDNzKalmW+GNp0DXK0jRukIzXNpraadCRSR/Bb8=; b=TXSdAXw8gdqPW/Yp8oYWXLi2wZgsFIf3x7yBOLjUl5Mkw4vB3NiSXk2Z7ghuTtTlNVqDpn XO2CZZuR/5bbHk6U4GULGFTLaDvPEMrKgS4BOLJR4Jlk9C8nXRLaAjJT5I2IXVD5SU5UlL qQcqfkNs2THldp0n3jPnFgvKeMcWAY52ETENFh3ykDPdWUJF4/E8Dbi9G6HVp2K+uLUgUe +E2WD8VH6Z2hBjCYsNS3ttq//geF7B/8lg0yAsn1OWwH9KSg0l4GCGI55kKPtwQI2ucBoN XK0ITPVP4FOjQyWXHTJWP8pf1TdB0VyvoOmCyqmi1ctKZjUpyKR6x/hoYjbL9A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1754317674; a=rsa-sha256; cv=none; b=jATljei2Xrq7no9kOqZ/5ywdm8rYUPHTS3yNdXLNalsNgq0B8kxYXm3mG89cS5n6ar04gp jsEiv2p5Bx3eSO/aZ12Sr72nPZNHw3aBMsa8YUu/i5gkG5GzuyRzyKlk3okP0H1e+jF+qa C24JZNFIv/8xXj3BWBSyPsnPxrkzPfMFkf3X6UKengkAUdRHzrRM0BGwbDUlB1uH7vm8EF BHu071Ym2Yl/2XvTWLkxGacoT2KBMw2nlpJWqFMHynydO1UYtFgcAeIe3p/KZx0OAV2N3/ 5EVzKmMhetf55duT8lgh8Cff1pYYnQBwlQCwJYR23olIaL9Id0xp1YC7wf66Rg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bwf6L3Fk2zsxM; Mon, 04 Aug 2025 14:27:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 574ERstl096157; Mon, 4 Aug 2025 14:27:54 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 574ERsd2096153; Mon, 4 Aug 2025 14:27:54 GMT (envelope-from git) Date: Mon, 4 Aug 2025 14:27:54 GMT Message-Id: <202508041427.574ERsd2096153@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 9a1b3303352b - main - vm_page: Clear VM_ALLOC_NOCREAT in vm_page_grab_pflags() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9a1b3303352beb44d48b8251b80656a316b7a2e9 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=9a1b3303352beb44d48b8251b80656a316b7a2e9 commit 9a1b3303352beb44d48b8251b80656a316b7a2e9 Author: Mark Johnston AuthorDate: 2025-08-01 23:34:46 +0000 Commit: Mark Johnston CommitDate: 2025-08-04 14:27:26 +0000 vm_page: Clear VM_ALLOC_NOCREAT in vm_page_grab_pflags() Otherwise vm_page_grab_zero_partial() and vm_page_grab_pages() can pass it to vm_page_alloc_*(), which results in an assertion failure since that flag is meaningless when allocating a page: panic: invalid request 0x8400 cpuid = 0 time = 1754074745 KDB: stack backtrace: db_trace_self_wrapper() at db_trace_self_wrapper+0x49/frame 0xfffffe00542859c0 vpanic() at vpanic+0x1ea/frame 0xfffffe0054285b00 panic() at panic+0x43/frame 0xfffffe0054285b60 vm_page_alloc_domain_iter() at vm_page_alloc_domain_iter+0x720/frame 0xfffffe0054285be0 vm_page_grab_zero_partial() at vm_page_grab_zero_partial+0x1d4/frame 0xfffffe0054285c90 shm_fspacectl() at shm_fspacectl+0x1cd/frame 0xfffffe0054285d30 kern_fspacectl() at kern_fspacectl+0x49f/frame 0xfffffe0054285db0 sys_fspacectl() at sys_fspacectl+0x5b/frame 0xfffffe0054285e00 amd64_syscall() at amd64_syscall+0x29c/frame 0xfffffe0054285f30 fast_syscall_common() at fast_syscall_common+0xf8/frame 0xfffffe0054285f30 Reported by: syzkaller Reviewed by: alc, kib MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D51692 --- sys/vm/vm_page.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/vm/vm_page.c b/sys/vm/vm_page.c index d3772af3c284..abad5efb8a79 100644 --- a/sys/vm/vm_page.c +++ b/sys/vm/vm_page.c @@ -4717,7 +4717,7 @@ vm_page_grab_pflags(int allocflags) pflags = allocflags & ~(VM_ALLOC_NOWAIT | VM_ALLOC_WAITOK | VM_ALLOC_WAITFAIL | - VM_ALLOC_NOBUSY | VM_ALLOC_IGN_SBUSY); + VM_ALLOC_NOBUSY | VM_ALLOC_IGN_SBUSY | VM_ALLOC_NOCREAT); if ((allocflags & VM_ALLOC_NOWAIT) == 0) pflags |= VM_ALLOC_WAITFAIL; if ((allocflags & VM_ALLOC_IGN_SBUSY) != 0)